Changeset 220717 in webkit

Timestamp:

Aug 14, 2017 3:00:27 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

The none smooth stroke applied to an SVG shape breaks its hit testing
​https://bugs.webkit.org/show_bug.cgi?id=175506

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-08-14
Reviewed by Simon Fraser.

Source/WebCore:

Clear RenderSVGShape::m_path when calling RenderSVGRect::updateShapeFromElement().
The m_path will be recalculated when RenderSVGShape::updateShapeFromElement()
is called from RenderSVGRect::shapeDependentStrokeContains().

Test: svg/stroke/stroke-linejoin-click.html

• rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):

• rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::clearPath):

LayoutTests:

• svg/stroke/stroke-linejoin-click-expected.html: Added.
• svg/stroke/stroke-linejoin-click.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/stroke/stroke-linejoin-click-expected.html (added)
• LayoutTests/svg/stroke/stroke-linejoin-click.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGRect.cpp (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGShape.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        The none smooth stroke applied to an SVG shape breaks its hit testing
+        https://bugs.webkit.org/show_bug.cgi?id=175506
+
+        Reviewed by Simon Fraser.
+
+        * svg/stroke/stroke-linejoin-click-expected.html: Added.
+        * svg/stroke/stroke-linejoin-click.html: Added.
+
 2017-08-14  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        The none smooth stroke applied to an SVG shape breaks its hit testing
+        https://bugs.webkit.org/show_bug.cgi?id=175506
+
+        Reviewed by Simon Fraser.
+
+        Clear RenderSVGShape::m_path when calling RenderSVGRect::updateShapeFromElement().
+        The m_path will be recalculated when RenderSVGShape::updateShapeFromElement()
+        is called from RenderSVGRect::shapeDependentStrokeContains().
+
+        Test: svg/stroke/stroke-linejoin-click.html
+
+        * rendering/svg/RenderSVGRect.cpp:
+        (WebCore::RenderSVGRect::updateShapeFromElement):
+        * rendering/svg/RenderSVGShape.h:
+        (WebCore::RenderSVGShape::clearPath):
+
 2017-08-14  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebCore/rendering/svg/RenderSVGRect.cpp

@@ -53 +53 @@
     m_innerStrokeRect = FloatRect();
     m_outerStrokeRect = FloatRect();
+    clearPath();
 
     SVGLengthContext lengthContext(&rectElement());

trunk/Source/WebCore/rendering/svg/RenderSVGShape.h

@@ -64 +64 @@
         return *m_path;
     }
+    void clearPath() { m_path = nullptr; }
 
 protected: