Changeset 220781 in webkit


Ignore:
Timestamp:
Aug 15, 2017 7:05:28 PM (7 years ago)
Author:
Simon Fraser
Message:

Remove ScrollView::clipsRepaints() which was only used by Chromium
https://bugs.webkit.org/show_bug.cgi?id=175594

Reviewed by Tim Horton.

clipsRepaints() was added in r74568 but was only used by Chromium. It's always
true for other platforms, so remove conditionals that test for it and assume true.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::setClipsRepaints): Deleted.

  • platform/ScrollView.h:

(WebCore::ScrollView::clipsRepaints const): Deleted.

Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r220780 r220781  
     12017-08-15  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Remove ScrollView::clipsRepaints() which was only used by Chromium
     4        https://bugs.webkit.org/show_bug.cgi?id=175594
     5
     6        Reviewed by Tim Horton.
     7
     8        clipsRepaints() was added in r74568 but was only used by Chromium. It's always
     9        true for other platforms, so remove conditionals that test for it and assume true.
     10
     11        * page/FrameView.cpp:
     12        (WebCore::FrameView::scrollContentsFastPath):
     13        * platform/ScrollView.cpp:
     14        (WebCore::ScrollView::repaintContentRectangle):
     15        (WebCore::ScrollView::setClipsRepaints): Deleted.
     16        * platform/ScrollView.h:
     17        (WebCore::ScrollView::clipsRepaints const): Deleted.
     18
    1192017-08-15  Simon Fraser  <simon.fraser@apple.com>
    220
  • trunk/Source/WebCore/page/FrameView.cpp

    r220503 r220781  
    23102310        IntRect updateRect = enclosingIntRect(layer->repaintRectIncludingNonCompositingDescendants());
    23112311        updateRect = contentsToRootView(updateRect);
    2312         if (!isCompositedContentLayer && clipsRepaints())
     2312        if (!isCompositedContentLayer)
    23132313            updateRect.intersect(rectToScroll);
    23142314        if (!updateRect.isEmpty())
     
    23302330            continue;
    23312331        }
    2332         if (clipsRepaints())
    2333             updateRect.intersect(rectToScroll);
     2332        updateRect.intersect(rectToScroll);
    23342333        frame().page()->chrome().invalidateContentsAndRootView(updateRect);
    23352334    }
  • trunk/Source/WebCore/platform/ScrollView.cpp

    r220503 r220781  
    193193}
    194194
    195 void ScrollView::setClipsRepaints(bool clipsRepaints)
    196 {
    197     m_clipsRepaints = clipsRepaints;
    198 }
    199 
    200195void ScrollView::setDelegatesScrolling(bool delegatesScrolling)
    201196{
     
    10721067{
    10731068    IntRect paintRect = rect;
    1074     if (clipsRepaints() && !paintsEntireContents())
     1069    if (!paintsEntireContents())
    10751070        paintRect.intersect(visibleContentRect(LegacyIOSDocumentVisibleRect));
    10761071    if (paintRect.isEmpty())
  • trunk/Source/WebCore/platform/ScrollView.h

    r216541 r220781  
    130130    WEBCORE_EXPORT void setPaintsEntireContents(bool);
    131131
    132     // By default, paint events are clipped to the visible area.  If set to
    133     // false, paint events are no longer clipped.  paintsEntireContents() implies !clipsRepaints().
    134     bool clipsRepaints() const { return m_clipsRepaints; }
    135     void setClipsRepaints(bool);
    136 
    137132    // By default programmatic scrolling is handled by WebCore and not by the UI application.
    138133    // In the case of using a tiled backing store, this mode can be set, so that the scroll requests
     
    482477
    483478    bool m_paintsEntireContents { false };
    484     bool m_clipsRepaints { true };
    485479    bool m_delegatesScrolling { false };
    486480
Note: See TracChangeset for help on using the changeset viewer.