Changeset 220793 in webkit

Timestamp:

Aug 16, 2017 4:26:39 AM (7 years ago)

Author:

magomez@igalia.com

Message:

[GTK] Crash of WebProcess with on-demand AC
​https://bugs.webkit.org/show_bug.cgi?id=171161

Reviewed by Carlos Garcia Campos.

Set the viewOverlayRootLayer to the previous layerTreeHost if it exists. This avoids a
crash when reusing the previous layerTreeHost, because it would keep a reference to an
already destroyed viewOverlayRootLayer.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::attachViewOverlayGraphicsLayer):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/AcceleratedDrawingArea.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-08-16  Miguel Gomez  <magomez@igalia.com>
+
+        [GTK] Crash of WebProcess with on-demand AC
+        https://bugs.webkit.org/show_bug.cgi?id=171161
+
+        Reviewed by Carlos Garcia Campos.
+
+        Set the viewOverlayRootLayer to the previous layerTreeHost if it exists. This avoids a
+        crash when reusing the previous layerTreeHost, because it would keep a reference to an
+        already destroyed viewOverlayRootLayer.
+
+        * WebProcess/WebPage/AcceleratedDrawingArea.cpp:
+        (WebKit::AcceleratedDrawingArea::attachViewOverlayGraphicsLayer):
+
 2017-08-16  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.cpp

@@ -475 +475 @@
     if (m_layerTreeHost)
         m_layerTreeHost->setViewOverlayRootLayer(viewOverlayRootLayer);
+    else if (m_previousLayerTreeHost)
+        m_previousLayerTreeHost->setViewOverlayRootLayer(viewOverlayRootLayer);
 }