Changeset 220799 in webkit
- Timestamp:
- Aug 16, 2017 10:30:39 AM (7 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/imported/w3c/ChangeLog
r220785 r220799 1 2017-08-16 Chris Dumez <cdumez@apple.com> 2 3 EventSource: ignore IDs with U+0000 4 https://bugs.webkit.org/show_bug.cgi?id=175178 5 6 Reviewed by Darin Adler. 7 8 Import WPT test coverage from: 9 - https://github.com/w3c/web-platform-tests/pull/6584 10 11 * web-platform-tests/eventsource/format-field-id-null-expected.txt: Added. 12 * web-platform-tests/eventsource/format-field-id-null.htm: Added. 13 * web-platform-tests/eventsource/resources/last-event-id.py: 14 (main): 15 * web-platform-tests/eventsource/w3c-import.log: 16 1 17 2017-08-15 Andy Estes <aestes@apple.com> 2 18 -
trunk/LayoutTests/imported/w3c/web-platform-tests/eventsource/resources/last-event-id.py
r220733 r220799 4 4 response.headers.set("Content-Type", "text/event-stream") 5 5 last_event_id = request.headers.get('Last-Event-ID', None) 6 value = request.GET.first("idvalue", "…") 6 7 7 8 if(last_event_id): 8 9 return "data: " + last_event_id + "\n\n" 9 10 else: 10 return "id: …\nretry: 200\ndata: hello\n\n"11 return "id: " + value + "\nretry: 200\ndata: hello\n\n" 11 12 -
trunk/LayoutTests/imported/w3c/web-platform-tests/eventsource/w3c-import.log
r220733 r220799 43 43 /LayoutTests/imported/w3c/web-platform-tests/eventsource/format-field-event.htm 44 44 /LayoutTests/imported/w3c/web-platform-tests/eventsource/format-field-id-2.htm 45 /LayoutTests/imported/w3c/web-platform-tests/eventsource/format-field-id-null.htm 45 46 /LayoutTests/imported/w3c/web-platform-tests/eventsource/format-field-id.htm 46 47 /LayoutTests/imported/w3c/web-platform-tests/eventsource/format-field-parsing.htm -
trunk/Source/WebCore/ChangeLog
r220797 r220799 1 2017-08-16 Chris Dumez <cdumez@apple.com> 2 3 EventSource: ignore IDs with U+0000 4 https://bugs.webkit.org/show_bug.cgi?id=175178 5 6 Reviewed by Darin Adler. 7 8 EventSource: ignore IDs with U+0000 as per: 9 https://github.com/whatwg/html/pull/2849 10 11 Test: imported/w3c/web-platform-tests/eventsource/format-field-id-null.htm 12 13 * page/EventSource.cpp: 14 (WebCore::EventSource::parseEventStreamLine): 15 1 16 2017-08-16 Fujii Hironori <Hironori.Fujii@sony.com> 2 17 -
trunk/Source/WebCore/page/EventSource.cpp
r219856 r220799 346 346 } else if (field == "event") 347 347 m_eventName = { &m_receiveBuffer[position], valueLength }; 348 else if (field == "id") 349 m_currentlyParsedEventId = { &m_receiveBuffer[position], valueLength }; 350 else if (field == "retry") { 348 else if (field == "id") { 349 StringView parsedEventId = { &m_receiveBuffer[position], valueLength }; 350 if (!parsedEventId.contains('\0')) 351 m_currentlyParsedEventId = parsedEventId.toString(); 352 } else if (field == "retry") { 351 353 if (!valueLength) 352 354 m_reconnectDelay = defaultReconnectDelay;
Note: See TracChangeset
for help on using the changeset viewer.