Changeset 220870 in webkit


Ignore:
Timestamp:
Aug 17, 2017 12:18:54 PM (7 years ago)
Author:
akling@apple.com
Message:

Disable CSS regions at compile time
https://bugs.webkit.org/show_bug.cgi?id=175630

Reviewed by Antti Koivisto.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Skip tests that are entirely about regions, and tweak logic
and/or expectations for tests that test regions in addition to
other things.

  • TestExpectations:
  • fast/css/will-change/resources/will-change-stacking-helper.js:
  • fast/dom/collection-iterators-expected.txt:
  • fast/dom/collection-iterators.html:
  • js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/ios/fast/dom/collection-iterators-expected.txt:
  • platform/mac-wk2/TestExpectations:
  • platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:
Location:
trunk
Files:
31 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r220734 r220870  
     12017-08-17  Andreas Kling  <akling@apple.com>
     2
     3        Disable CSS regions at compile time
     4        https://bugs.webkit.org/show_bug.cgi?id=175630
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * Source/cmake/OptionsGTK.cmake:
     9        * Source/cmake/OptionsMac.cmake:
     10        * Source/cmake/OptionsWPE.cmake:
     11        * Source/cmake/OptionsWin.cmake:
     12        * Source/cmake/tools/vsprops/FeatureDefines.props:
     13        * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
     14
    1152017-08-14  Simon Fraser  <simon.fraser@apple.com>
    216
  • trunk/LayoutTests/ChangeLog

    r220858 r220870  
     12017-08-17  Andreas Kling  <akling@apple.com>
     2
     3        Disable CSS regions at compile time
     4        https://bugs.webkit.org/show_bug.cgi?id=175630
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Skip tests that are entirely about regions, and tweak logic
     9        and/or expectations for tests that test regions in addition to
     10        other things.
     11
     12        * TestExpectations:
     13        * fast/css/will-change/resources/will-change-stacking-helper.js:
     14        * fast/dom/collection-iterators-expected.txt:
     15        * fast/dom/collection-iterators.html:
     16        * js/dom/dom-static-property-for-in-iteration-expected.txt:
     17        * platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
     18        * platform/ios/fast/dom/collection-iterators-expected.txt:
     19        * platform/mac-wk2/TestExpectations:
     20        * platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt:
     21        * platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:
     22
    1232017-08-17  Antti Koivisto  <antti@apple.com>
    224
  • trunk/LayoutTests/TestExpectations

    r220785 r220870  
    14461446webkit.org/b/175611 imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html [ Skip ]
    14471447webkit.org/b/175611 imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html [ Skip ]
     1448
     1449# CSS Regions are being phased out.
     1450fast/regions [ Skip ]
     1451compositing/regions [ Skip ]
     1452fast/ruby/ruby-rt-with-region-crash.html [ Skip ]
     1453inspector/dom/content-node-region-info.html [ Skip ]
     1454fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html [ Skip ]
  • trunk/LayoutTests/fast/css/will-change/resources/will-change-stacking-helper.js

    r190667 r220870  
    2525    { 'property' : '-webkit-transform', 'stacking' : true },
    2626    { 'property' : '-webkit-transform-style', 'stacking' : true },
    27     { 'property' : '-webkit-flow-from', 'stacking' : true },
    2827];
    2928
  • trunk/LayoutTests/fast/dom/collection-iterators-expected.txt

    r215892 r220870  
    4242* MimeTypeArray
    4343PASS obj.__proto__ is MimeTypeArray.prototype
    44 PASS Symbol.iterator in obj is true
    45 PASS for..of did not throw an exception
    46 PASS 'entries' in obj is false
    47 PASS 'keys' in obj is false
    48 PASS 'forEach' in obj is false
    49 PASS 'values' in obj is false
    50 
    51 * WebKitNamedFlowCollection
    5244PASS Symbol.iterator in obj is true
    5345PASS for..of did not throw an exception
  • trunk/LayoutTests/fast/dom/collection-iterators.html

    r215892 r220870  
    4646checkHasIterator("CSSValueList", window.getComputedStyle(document.body).getPropertyCSSValue('background-position'));
    4747checkHasIterator("MimeTypeArray", navigator.mimeTypes);
    48 checkHasIterator("WebKitNamedFlowCollection", document.webkitGetNamedFlows());
    4948if (navigator.plugins.length)
    5049    checkHasIterator("Plugin", navigator.plugins[0]);
  • trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt

    r216542 r220870  
    135135PASS a["innerHTML"] is nerget
    136136PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
    137 PASS a["webkitRegionOverset"] is undefined
    138137PASS a["oncopy"] is null
    139138PASS a["oncut"] is null
  • trunk/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt

    r218486 r220870  
    135135PASS a["innerHTML"] is nerget
    136136PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
    137 PASS a["webkitRegionOverset"] is undefined
    138137PASS a["oncopy"] is null
    139138PASS a["oncut"] is null
  • trunk/LayoutTests/platform/ios/fast/dom/collection-iterators-expected.txt

    r215892 r220870  
    4242* MimeTypeArray
    4343PASS obj.__proto__ is MimeTypeArray.prototype
    44 PASS Symbol.iterator in obj is true
    45 PASS for..of did not throw an exception
    46 PASS 'entries' in obj is false
    47 PASS 'keys' in obj is false
    48 PASS 'forEach' in obj is false
    49 PASS 'values' in obj is false
    50 
    51 * WebKitNamedFlowCollection
    5244PASS Symbol.iterator in obj is true
    5345PASS for..of did not throw an exception
  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r220507 r220870  
    748748
    749749webkit.org/b/175270 [ Debug ] plugins/crash-restoring-plugin-page-from-page-cache.html [ Skip ]
     750
     751# CSS Regions are being phased out.
     752tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html [ Skip ]
  • trunk/LayoutTests/platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt

    r163942 r220870  
    5151PASS a["scrollWidth"] is 0
    5252PASS a["attributes"] is [object NamedNodeMap]
    53 PASS a["webkitRegionOverset"] is undefined
    5453PASS a["ALLOW_KEYBOARD_INPUT"] is 1
    5554PASS a["offsetWidth"] is 39
  • trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt

    r217380 r220870  
    134134PASS a["innerHTML"] is nerget
    135135PASS a["outerHTML"] is <a id="foo" href="bar">nerget</a>
    136 PASS a["webkitRegionOverset"] is undefined
    137136PASS a["oncopy"] is null
    138137PASS a["oncut"] is null
  • trunk/Source/JavaScriptCore/ChangeLog

    r220860 r220870  
     12017-08-17  Andreas Kling  <akling@apple.com>
     2
     3        Disable CSS regions at compile time
     4        https://bugs.webkit.org/show_bug.cgi?id=175630
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * Configurations/FeatureDefines.xcconfig:
     9
    1102017-08-17  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
    211
  • trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig

    r220787 r220870  
    8080ENABLE_CSS_IMAGE_ORIENTATION = ;
    8181ENABLE_CSS_IMAGE_RESOLUTION = ;
    82 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
     82ENABLE_CSS_REGIONS = ;
    8383ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    8484ENABLE_CSS3_TEXT = ;
  • trunk/Source/WebCore/ChangeLog

    r220865 r220870  
     12017-08-17  Andreas Kling  <akling@apple.com>
     2
     3        Disable CSS regions at compile time
     4        https://bugs.webkit.org/show_bug.cgi?id=175630
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * Configurations/FeatureDefines.xcconfig:
     9
    1102017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
    211
  • trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig

    r220787 r220870  
    8080ENABLE_CSS_IMAGE_ORIENTATION = ;
    8181ENABLE_CSS_IMAGE_RESOLUTION = ;
    82 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
     82ENABLE_CSS_REGIONS = ;
    8383ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    8484ENABLE_CSS3_TEXT = ;
  • trunk/Source/WebCore/PAL/ChangeLog

    r220865 r220870  
     12017-08-17  Andreas Kling  <akling@apple.com>
     2
     3        Disable CSS regions at compile time
     4        https://bugs.webkit.org/show_bug.cgi?id=175630
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * Configurations/FeatureDefines.xcconfig:
     9
    1102017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
    211
  • trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig

    r220787 r220870  
    8080ENABLE_CSS_IMAGE_ORIENTATION = ;
    8181ENABLE_CSS_IMAGE_RESOLUTION = ;
    82 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
     82ENABLE_CSS_REGIONS = ;
    8383ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    8484ENABLE_CSS3_TEXT = ;
  • trunk/Source/WebKit/ChangeLog

    r220865 r220870  
     12017-08-17  Andreas Kling  <akling@apple.com>
     2
     3        Disable CSS regions at compile time
     4        https://bugs.webkit.org/show_bug.cgi?id=175630
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * Configurations/FeatureDefines.xcconfig:
     9
    1102017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
    211
  • trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig

    r220787 r220870  
    8080ENABLE_CSS_IMAGE_ORIENTATION = ;
    8181ENABLE_CSS_IMAGE_RESOLUTION = ;
    82 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
     82ENABLE_CSS_REGIONS = ;
    8383ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    8484ENABLE_CSS3_TEXT = ;
  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r220857 r220870  
     12017-08-17  Andreas Kling  <akling@apple.com>
     2
     3        Disable CSS regions at compile time
     4        https://bugs.webkit.org/show_bug.cgi?id=175630
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * Configurations/FeatureDefines.xcconfig:
     9
    1102017-08-17  Don Olmstead  <don.olmstead@sony.com>
    211
  • trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig

    r220787 r220870  
    8080ENABLE_CSS_IMAGE_ORIENTATION = ;
    8181ENABLE_CSS_IMAGE_RESOLUTION = ;
    82 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
     82ENABLE_CSS_REGIONS = ;
    8383ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    8484ENABLE_CSS3_TEXT = ;
  • trunk/Source/cmake/OptionsGTK.cmake

    r220713 r220870  
    155155WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_TRANSFORMS PRIVATE ON)
    156156WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE ON)
    157 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE ON)
     157WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE OFF)
    158158WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PRIVATE ON)
    159159WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PRIVATE ON)
  • trunk/Source/cmake/OptionsMac.cmake

    r220734 r220870  
    1818WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_ORIENTATION PRIVATE OFF)
    1919WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_RESOLUTION PRIVATE OFF)
    20 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE ON)
     20WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE OFF)
    2121WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PRIVATE ON)
    2222WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT PRIVATE OFF)
  • trunk/Source/cmake/OptionsWPE.cmake

    r220730 r220870  
    1414WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_TRANSFORMS PUBLIC ON)
    1515WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC OFF)
    16 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC ON)
     16WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC OFF)
    1717WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PUBLIC ON)
    1818WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DEVICE_ORIENTATION PUBLIC OFF)
  • trunk/Source/cmake/OptionsWin.cmake

    r220734 r220870  
    2323WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_BOX_DECORATION_BREAK PUBLIC ON)
    2424WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_COMPOSITING PUBLIC OFF)
    25 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC ON)
     25WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC OFF)
    2626WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PUBLIC ON)
    2727WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURSOR_VISIBILITY PUBLIC ON)
  • trunk/Source/cmake/tools/vsprops/FeatureDefines.props

    r220734 r220870  
    1313    <ENABLE_CSS_COMPOSITING />
    1414    <ENABLE_CSS_IMAGE_SET>ENABLE_CSS_IMAGE_SET</ENABLE_CSS_IMAGE_SET>
    15     <ENABLE_CSS_REGIONS>ENABLE_CSS_REGIONS</ENABLE_CSS_REGIONS>
     15    <ENABLE_CSS_REGIONS />
    1616    <ENABLE_CSS_SELECTORS_LEVEL4>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_SELECTORS_LEVEL4>
    1717    <ENABLE_CSS_SHADERS />
  • trunk/Source/cmake/tools/vsprops/FeatureDefinesCairo.props

    r220734 r220870  
    1313    <ENABLE_CSS_COMPOSITING />
    1414    <ENABLE_CSS_IMAGE_SET>ENABLE_CSS_IMAGE_SET</ENABLE_CSS_IMAGE_SET>
    15     <ENABLE_CSS_REGIONS>ENABLE_CSS_REGIONS</ENABLE_CSS_REGIONS>
     15    <ENABLE_CSS_REGIONS />
    1616    <ENABLE_CSS_SELECTORS_LEVEL4>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_SELECTORS_LEVEL4>
    1717    <ENABLE_CSS_SHADERS />
  • trunk/Tools/ChangeLog

    r220869 r220870  
     12017-08-17  Andreas Kling  <akling@apple.com>
     2
     3        Disable CSS regions at compile time
     4        https://bugs.webkit.org/show_bug.cgi?id=175630
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * Scripts/webkitperl/FeatureList.pm:
     9        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
     10
    1112017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
    212
  • trunk/Tools/Scripts/webkitperl/FeatureList.pm

    r220336 r220870  
    180180
    181181    { option => "css-regions", desc => "Toggle CSS Regions support",
    182       define => "ENABLE_CSS_REGIONS", default => 1, value => \$cssRegionsSupport },
     182      define => "ENABLE_CSS_REGIONS", default => 0, value => \$cssRegionsSupport },
    183183
    184184    { option => "css-shapes", desc => "Toggle CSS Shapes support",
  • trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig

    r220787 r220870  
    8080ENABLE_CSS_IMAGE_ORIENTATION = ;
    8181ENABLE_CSS_IMAGE_RESOLUTION = ;
    82 ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
     82ENABLE_CSS_REGIONS = ;
    8383ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
    8484ENABLE_CSS3_TEXT = ;
Note: See TracChangeset for help on using the changeset viewer.