Changeset 220902 in webkit


Ignore:
Timestamp:
Aug 17, 2017 11:27:26 PM (7 years ago)
Author:
Michael Catanzaro
Message:

[GTK] Make TestContextMenu work on Fedora
https://bugs.webkit.org/show_bug.cgi?id=175708

Reviewed by Carlos Garcia Campos.

TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
and my student last summer who was trying to work on a context menu API. It's trying to load
an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
don't care to investigate. Let's switch it to WebM so I can move on.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(prepareContextMenuTestView):

  • TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
  • TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
Location:
trunk/Tools
Files:
1 added
1 deleted
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r220896 r220902  
     12017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
     2
     3        [GTK] Make TestContextMenu work on Fedora
     4        https://bugs.webkit.org/show_bug.cgi?id=175708
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
     9        and my student last summer who was trying to work on a context menu API. It's trying to load
     10        an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
     11        entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
     12        don't care to investigate. Let's switch it to WebM so I can move on.
     13
     14        * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
     15        (prepareContextMenuTestView):
     16        * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
     17        * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
     18
    1192017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
    220
  • trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp

    r217209 r220902  
    441441        " <a style='position:absolute; left:1; top:20' href='http://www.webkitgtk.org/logo' title='WebKitGTK+ Logo'><img src='blank.ico' width=5 height=5></img></a>"
    442442        " <input style='position:absolute; left:1; top:30' size='10'></input>"
    443         " <video style='position:absolute; left:1; top:50' width='300' height='300' controls='controls' preload='none'><source src='silence.mpg' type='video/mpeg' /></video>"
     443        " <video style='position:absolute; left:1; top:50' width='300' height='300' controls='controls' preload='none'><source src='silence.webm' type='video/webm' /></video>"
    444444        " <audio style='position:absolute; left:1; top:60' width='50' height='20' controls='controls' preload='none'><source src='track.ogg' type='audio/ogg' /></audio>"
    445445        " <p style='position:absolute; left:1; top:90' id='text_to_select'>Lorem ipsum.</p>"
Note: See TracChangeset for help on using the changeset viewer.