Changeset 220910 in webkit

Timestamp:

Aug 18, 2017 1:58:34 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Show controls if a video element isn't allowed to play inline.
​https://bugs.webkit.org/show_bug.cgi?id=141705

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-18
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Test: covered by media/video-fullscreeen-only-controls.html [sic].

• Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.shouldHaveControls):

LayoutTests:

• platform/gtk/TestExpectations: enable test for this case.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-08-18  Ms2ger  <Ms2ger@gmail.com>
+
+        [GTK] Show controls if a video element isn't allowed to play inline.
+        https://bugs.webkit.org/show_bug.cgi?id=141705
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * platform/gtk/TestExpectations: enable test for this case.
+
 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -920 +920 @@
 webkit.org/b/141699 fast/attachment/attachment-respects-css-size.html [ ImageOnlyFailure ]
 
-webkit.org/b/141705 media/video-fullscreeen-only-controls.html [ Failure ]
-
 webkit.org/b/141831 svg/animations/animate-text-nested-transforms.html [ Failure ]
 webkit.org/b/98653  svg/text/lengthAdjust-text-metrics.html [ Failure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-18  Ms2ger  <Ms2ger@gmail.com>
+
+        [GTK] Show controls if a video element isn't allowed to play inline.
+        https://bugs.webkit.org/show_bug.cgi?id=141705
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Test: covered by media/video-fullscreeen-only-controls.html [sic].
+
+        * Modules/mediacontrols/mediaControlsGtk.js:
+        (ControllerGtk.prototype.shouldHaveControls):
+
 2017-08-18  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsGtk.js

@@ -57 +57 @@
     shouldHaveControls: function()
     {
+        if (!this.isAudio() && !this.host.allowsInlineMediaPlayback)
+            return true;
+
         return this.video.controls || this.isFullScreen();
     },