Changeset 220912 in webkit

Timestamp:

Aug 18, 2017 2:24:35 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Update track-datacue.html test to the current code.
​https://bugs.webkit.org/show_bug.cgi?id=175624

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-18
Reviewed by Eric Carlson.

• media/track/track-datacue-expected.txt: rebaselined.
• media/track/track-datacue.html: updated for IDL, exception changes, addition of a new constructor.
• platform/gtk/TestExpectations: removed failure expectation.
• platform/ios/TestExpectations: enable.
• platform/mac/TestExpectations: enable.
• platform/win/TestExpectations: enable.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/track/track-datacue-expected.txt (modified) (3 diffs)
• media/track/track-datacue.html (modified) (1 diff)
• platform/gtk/TestExpectations (modified) (1 diff)
• platform/ios/TestExpectations (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)
• platform/win/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-08-18  Ms2ger  <Ms2ger@igalia.com>
+
+        Update track-datacue.html test to the current code.
+        https://bugs.webkit.org/show_bug.cgi?id=175624
+
+        Reviewed by Eric Carlson.
+
+        * media/track/track-datacue-expected.txt: rebaselined.
+        * media/track/track-datacue.html: updated for IDL, exception changes, addition of a new constructor.
+        * platform/gtk/TestExpectations: removed failure expectation.
+        * platform/ios/TestExpectations: enable.
+        * platform/mac/TestExpectations: enable.
+        * platform/win/TestExpectations: enable.
+
 2017-08-18  Ms2ger  <Ms2ger@gmail.com>
 

trunk/LayoutTests/media/track/track-datacue-expected.txt

@@ -3 +3 @@
 
 *** Test DataCue's TextTrackCue interface.
-EXPECTED (cue instanceof '[object TextTrackCueConstructor]') OK
+EXPECTED (cue instanceof 'function TextTrackCue() { [native code] }') OK
 EXPECTED (cue.track == 'null') OK
 EXPECTED (cue.id == '') OK
@@ -11 +11 @@
 
 *** Test DataCue interface.
-EXPECTED (cue instanceof '[object DataCueConstructor]') OK
+EXPECTED (cue instanceof 'function DataCue() { [native code] }') OK
 EXPECTED (new Uint8Array(cue.data).length == '5') OK
 EXPECTED (new Uint8Array(cue.data)[0] == '4') OK
@@ -30 +30 @@
 
 *** Throw exception if data is not an ArrayBuffer.
-TEST(cue.data = null) THROWS('TypeError: Type error') OK
-TEST(cue.data = 'test') THROWS('TypeError: Type error') OK
-TEST(cue.data = [5]) THROWS('TypeError: Type error') OK
-TEST(badCue = new DataCue(1, 2, null)) THROWS('TypeError: Type error') OK
-TEST(badCue = new DataCue(1, 2, 'test')) THROWS('TypeError: Type error') OK
-TEST(badCue = new DataCue(1, 2, [5])) THROWS('TypeError: Type error') OK
+TEST(cue.data = null) THROWS('TypeError: The DataCue.data attribute must be an instance of ArrayBuffer') OK
+TEST(cue.data = 'test') THROWS('TypeError: The DataCue.data attribute must be an instance of ArrayBuffer') OK
+TEST(cue.data = [5]) THROWS('TypeError: The DataCue.data attribute must be an instance of ArrayBuffer') OK
+
+*** Constructor with value argument.
+EXPECTED (new DataCue(1, 2, null).value === 'null') OK
+EXPECTED (new DataCue(1, 2, 'test').value === 'test') OK
+EXPECTED (new DataCue(1, 2, [5]).value.length == '1') OK
+EXPECTED (new DataCue(1, 2, [5]).value[0] == '5') OK
 
 *** Test adding DataCue to track with kind = 'metadata'.

trunk/LayoutTests/media/track/track-datacue.html

@@ -42 +42 @@
 
                 consoleWrite("<br>*** Throw exception if data is not an ArrayBuffer.");
-                var error = "'TypeError: Type error'";
+                var error = "'TypeError: The DataCue.data attribute must be an instance of ArrayBuffer'";
                 testException("cue.data = null", error);
                 testException("cue.data = 'test'", error);
                 testException("cue.data = [5]", error);
-                testException("badCue = new DataCue(1, 2, null)", error);
-                testException("badCue = new DataCue(1, 2, 'test')", error);
-                testException("badCue = new DataCue(1, 2, [5])", error);
+
+                consoleWrite("<br>*** Constructor with value argument.");
+                testExpected("new DataCue(1, 2, null).value", null, "===");
+                testExpected("new DataCue(1, 2, 'test').value", 'test', "===");
+                testArraysEqual("new DataCue(1, 2, [5]).value", [5]);
 
                 consoleWrite("<br>*** Test adding DataCue to track with kind = 'metadata'.");

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -3246 +3246 @@
 webkit.org/b/168373 media/video-background-playback.html [ Failure Timeout ]
 webkit.org/b/168373 media/video-concurrent-playback.html [ Failure Timeout ]
-webkit.org/b/132055 media/track/track-datacue.html [ Failure ]
 
 # [GTK] Some reftest fail with only one or two pixel differences in diff image

trunk/LayoutTests/platform/ios/TestExpectations

@@ -159 +159 @@
 platform/ios/ios/fast/text/data-detectors/phone.html [ Skip ]
 platform/ios/ios/touch [ Skip ]
-
-# WebKitDataCue is supported, not DataCue
-media/track/track-datacue.html
 
 # Codecs not supported

trunk/LayoutTests/platform/mac/TestExpectations

@@ -800 +800 @@
 ## --- Start unimplemented media tests ---
 webkit.org/b/91611 media/media-higher-prio-audio-stream.html [ Skip ]
-
-# WebKitDataCue is supported, not DataCue
-media/track/track-datacue.html [ Skip ]
 
 webkit.org/b/158836 imported/w3c/web-platform-tests/encrypted-media [ Skip ]

trunk/LayoutTests/platform/win/TestExpectations

@@ -1050 +1050 @@
 media/track/track-cues-seeking.html [ Skip ] # Timeout
 media/track/track-cues-sorted-before-dispatch.html [ Skip ] # Timeout
-media/track/track-datacue.html [ Skip ] # Timeout
 media/track/track-forced-subtitles-in-band.html [ Skip ] # Timeout
 media/track/track-in-band-style.html [ Skip ] # Timeout