Changeset 220950 in webkit

Timestamp:

Aug 18, 2017 8:05:57 PM (7 years ago)

Author:

rniwa@webkit.org

Message:

REGRESSION(r219640): Speedometer no longer runs on Safari 7
​https://bugs.webkit.org/show_bug.cgi?id=175749

Reviewed by Joseph Pecoraro.

PerformanceTests:

Use regular string instead of template literal to make the script compatible with older versions of Safari.

• Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._runTest):

Websites/browserbench.org:

Fix the bug on browserbench.org.

• Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._runTest):

Location:

trunk

Files:

• PerformanceTests/ChangeLog (modified) (1 diff)
• PerformanceTests/Speedometer/resources/benchmark-runner.js (modified) (2 diffs)
• Websites/browserbench.org/ChangeLog (modified) (1 diff)
• Websites/browserbench.org/Speedometer/resources/benchmark-runner.js (modified) (2 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2017-08-18  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r219640): Speedometer no longer runs on Safari 7
+        https://bugs.webkit.org/show_bug.cgi?id=175749
+
+        Reviewed by Joseph Pecoraro.
+
+        Use regular string instead of template literal to make the script compatible with older versions of Safari.
+
+        * Speedometer/resources/benchmark-runner.js:
+        (BenchmarkRunner.prototype._runTest):
+
 2017-08-17  Mathias Bynens  <mathias@qiwi.be>
 

trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js

@@ -127 +127 @@
     var contentDocument = self._frame.contentDocument;
 
-    self._writeMark(`${suite.name}.${test.name}-start`);
+    self._writeMark(suite.name + '.' + test.name + '-start');
     var startTime = now();
     test.run(prepareReturnValue, contentWindow, contentDocument);
     var endTime = now();
-    self._writeMark(`${suite.name}.${test.name}-sync-end`);
+    self._writeMark(suite.name + '.' + test.name + '-sync-end');
 
     var syncTime = endTime - startTime;
@@ -138 +138 @@
     setTimeout(function () {
         var endTime = now();
-        self._writeMark(`${suite.name}.${test.name}-async-end`);
+        self._writeMark(suite.name + '.' + test.name + '-async-end');
         callback(syncTime, endTime - startTime);
     }, 0);

trunk/Websites/browserbench.org/ChangeLog

@@ +1 @@
+2017-08-18  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r219640): Speedometer no longer runs on Safari 7
+        https://bugs.webkit.org/show_bug.cgi?id=175749
+
+        Reviewed by Joseph Pecoraro.
+
+        Fix the bug on browserbench.org.
+
+        * Speedometer/resources/benchmark-runner.js:
+        (BenchmarkRunner.prototype._runTest):
+
 2017-07-18  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/browserbench.org/Speedometer/resources/benchmark-runner.js

@@ -127 +127 @@
     var contentDocument = self._frame.contentDocument;
 
-    self._writeMark(`${suite.name}.${test.name}-start`);
+    self._writeMark(suite.name + '.' + test.name + '-start');
     var startTime = now();
     test.run(prepareReturnValue, contentWindow, contentDocument);
     var endTime = now();
-    self._writeMark(`${suite.name}.${test.name}-sync-end`);
+    self._writeMark(suite.name + '.' + test.name + '-sync-end');
 
     var syncTime = endTime - startTime;
@@ -138 +138 @@
     setTimeout(function () {
         var endTime = now();
-        self._writeMark(`${suite.name}.${test.name}-async-end`);
+        self._writeMark(suite.name + '.' + test.name + '-async-end');
         callback(syncTime, endTime - startTime);
     }, 0);