Changeset 220974 in webkit
- Timestamp:
- Aug 21, 2017 12:06:36 PM (7 years ago)
- Location:
- trunk/LayoutTests
- Files:
-
- 4 edited
- 1 copied
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r220972 r220974 1 2017-08-21 Ms2ger <Ms2ger@gmail.com> 2 3 Re-enable tests based on media-fullscreen.js for GTK. 4 https://bugs.webkit.org/show_bug.cgi?id=175770 5 6 Reviewed by Eric Carlson. 7 8 The media-fullscreen-not-in-document test checks that a disconnected 9 element can go fullscreen, while the code explicitly disallows that 10 (in Document::requestFullScreenForElement). Update the test to match 11 the code. 12 13 The media-fullscreen-inline test will now fail more clearly if the 14 attempt to go fullscreen is rejected (which it isn't). 15 16 * media/media-fullscreen-not-in-document-expected.txt: rebaseline. 17 * media/media-fullscreen.js: 18 (fullscreenerror): pass the test if the webkitfullscreenerror 19 (addEventListeners): add a webkitfullscreenerror event handler 20 * platform/gtk/TestExpectations: remove failure expectations. 21 * platform/gtk/media/media-fullscreen-not-in-document-expected.txt: 22 Copied from LayoutTests/media/media-fullscreen-not-in-document-expected.txt. 23 This copy leaves out the webkitSupportsPresentationMode check that's 24 disabled on GTK. 25 1 26 2017-08-21 Matt Lewis <jlewis3@apple.com> 2 27 -
trunk/LayoutTests/media/media-fullscreen-not-in-document-expected.txt
r217176 r220974 17 17 * event handler triggered by user gesture 18 18 RUN(mediaElement.webkitEnterFullScreen()) 19 EVENT(webkitbeginfullscreen) 20 EXPECTED (mediaElement.webkitDisplayingFullscreen == 'true') OK 21 RUN(mediaElement.webkitExitFullScreen()) 22 EVENT(webkitendfullscreen) 19 EVENT(webkitfullscreenerror) 20 EXPECTED (mediaElement.webkitDisplayingFullscreen == 'false') OK 23 21 24 22 *** Creating <audio> element with "content/silence.mpg" not in the document, should NOT support fullscreen -
trunk/LayoutTests/media/media-fullscreen.js
r217176 r220974 45 45 { 46 46 setTimeout(openNextMovie, 10); 47 } 48 49 function fullscreenerror() 50 { 51 var movie = movieInfo.movies[movieInfo.current]; 52 if (movie.inline) { 53 failTest("Unexpected fullscreenerror event"); 54 } else { 55 testExpected("mediaElement.webkitDisplayingFullscreen", false); 56 openNextMovie(); 57 } 47 58 } 48 59 … … 127 138 waitForEvent('webkitendfullscreen', endfullscreen); 128 139 waitForEvent('webkitfullscreenchange', fullscreenchange); 140 waitForEvent('webkitfullscreenerror', fullscreenerror); 129 141 } 130 142 -
trunk/LayoutTests/platform/gtk/TestExpectations
r220965 r220974 156 156 # Requires media engine closed caption support. 157 157 media/media-captions.html [ WontFix Failure ] 158 159 # Legacy full screen API tests are now obsolete.160 # This passes while it's marked as a WontFix - check it.161 media/media-fullscreen-inline.html [ WontFix Crash Pass ]162 media/media-fullscreen-not-in-document.html [ WontFix Timeout Crash ]163 158 164 159 # Features that we want eventually: -
trunk/LayoutTests/platform/gtk/media/media-fullscreen-not-in-document-expected.txt
r220973 r220974 10 10 * event handler NOT triggered by a user gesture 11 11 EXPECTED (mediaElement.webkitSupportsFullscreen == 'true') OK 12 EXPECTED (mediaElement.webkitSupportsPresentationMode('fullscreen') == 'true') OK13 12 EXPECTED (mediaElement.webkitDisplayingFullscreen == 'false') OK 14 13 TEST(mediaElement.webkitEnterFullScreen()) THROWS(DOMException.INVALID_STATE_ERR) OK … … 17 16 * event handler triggered by user gesture 18 17 RUN(mediaElement.webkitEnterFullScreen()) 19 EVENT(webkitbeginfullscreen) 20 EXPECTED (mediaElement.webkitDisplayingFullscreen == 'true') OK 21 RUN(mediaElement.webkitExitFullScreen()) 22 EVENT(webkitendfullscreen) 18 EVENT(webkitfullscreenerror) 19 EXPECTED (mediaElement.webkitDisplayingFullscreen == 'false') OK 23 20 24 21 *** Creating <audio> element with "content/silence.mpg" not in the document, should NOT support fullscreen
Note: See TracChangeset
for help on using the changeset viewer.