Changeset 221008 in webkit

Timestamp:

Aug 22, 2017 2:51:22 AM (7 years ago)

Author:

zandobersek@gmail.com

Message:

GLContext: zero-initialize the GLContext pointer in ThreadGlobalGLContext
​https://bugs.webkit.org/show_bug.cgi?id=175819

Reviewed by Xabier Rodriguez-Calvar.

• platform/graphics/GLContext.cpp: The ThreadGlobalGLContext object is

allocated on heap, so the embedded GLContext pointer can contain a
non-null value that can cause problems when e.g. checking for a current
GLContext on some specific thread on which a GLContext hasn't yet been
made current. Zero-initializing this pointer will avoid false positives
that can occur in these circumstances.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/GLContext.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-22  Zan Dobersek  <zdobersek@igalia.com>
+
+        GLContext: zero-initialize the GLContext pointer in ThreadGlobalGLContext
+        https://bugs.webkit.org/show_bug.cgi?id=175819
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * platform/graphics/GLContext.cpp: The ThreadGlobalGLContext object is
+        allocated on heap, so the embedded GLContext pointer can contain a
+        non-null value that can cause problems when e.g. checking for a current
+        GLContext on some specific thread on which a GLContext hasn't yet been
+        made current. Zero-initializing this pointer will avoid false positives
+        that can occur in these circumstances.
+
 2017-08-21  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/graphics/GLContext.cpp

@@ -51 +51 @@
 
 private:
-    GLContext* m_context;
+    GLContext* m_context { nullptr };
 };