Changeset 221014 in webkit
- Timestamp:
- Aug 22, 2017 8:56:32 AM (7 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r220996 r221014 1 2017-08-21 Matt Rajca <mrajca@apple.com> 2 3 Call updateIsPlayingMedia whenever m_userHasInteractedWithMediaElement changes 4 https://bugs.webkit.org/show_bug.cgi?id=175796 5 6 Reviewed by Eric Carlson. 7 8 Skip the test on iOS like all the other tests that use runWithKeyDown. 9 10 * media/video-user-gesture-tracking-expected.txt: Added. 11 * media/video-user-gesture-tracking.html: Added. 12 1 13 2017-08-21 Chris Dumez <cdumez@apple.com> 2 14 -
trunk/LayoutTests/platform/ios/TestExpectations
r220912 r221014 2571 2571 media/video-playsinline.html 2572 2572 media/video-remote-control-playpause.html 2573 media/video-user-gesture-tracking.html 2573 2574 media/video-volume-slider-drag.html 2574 2575 media/video-webkit-playsinline.html -
trunk/Source/WebCore/ChangeLog
r221008 r221014 1 2017-08-21 Matt Rajca <mrajca@apple.com> 2 3 Call updateIsPlayingMedia whenever m_userHasInteractedWithMediaElement changes 4 https://bugs.webkit.org/show_bug.cgi?id=175796 5 6 Reviewed by Eric Carlson. 7 8 Test: media/video-user-gesture-tracking.html 9 10 The page media state depends on m_userHasInteractedWithMediaElement, so force it to update 11 as soon as m_userHasInteractedWithMediaElement changes. This fixes an issue where the media 12 state would not reflect the user interaction flag until a call to updateIsPlayingMedia was made. 13 14 * dom/Document.cpp: 15 (WebCore::Document::noteUserInteractionWithMediaElement): 16 * dom/Document.h: 17 (WebCore::Document::noteUserInteractionWithMediaElement): Deleted. 18 * testing/Internals.cpp: 19 (WebCore::Internals::pageMediaState): 20 1 21 2017-08-22 Zan Dobersek <zdobersek@igalia.com> 2 22 -
trunk/Source/WebCore/dom/Document.cpp
r220857 r221014 3607 3607 } 3608 3608 3609 void Document::noteUserInteractionWithMediaElement() 3610 { 3611 if (m_userHasInteractedWithMediaElement) 3612 return; 3613 3614 m_userHasInteractedWithMediaElement = true; 3615 updateIsPlayingMedia(); 3616 } 3617 3609 3618 void Document::updateIsPlayingMedia(uint64_t sourceElementID) 3610 3619 { -
trunk/Source/WebCore/dom/Document.h
r220957 r221014 1274 1274 WEBCORE_EXPORT void removeAudioProducer(MediaProducer*); 1275 1275 MediaProducer::MediaStateFlags mediaState() const { return m_mediaState; } 1276 void noteUserInteractionWithMediaElement() { m_userHasInteractedWithMediaElement = true; }1276 void noteUserInteractionWithMediaElement(); 1277 1277 bool isCapturing() const { return MediaProducer::isCapturing(m_mediaState); } 1278 1278 WEBCORE_EXPORT void updateIsPlayingMedia(uint64_t = HTMLMediaElementInvalidID); -
trunk/Source/WebCore/testing/Internals.cpp
r220734 r221014 3582 3582 if (state & MediaProducer::HasMutedVideoCaptureDevice) 3583 3583 string.append("HasMutedVideoCaptureDevice,"); 3584 if (state & MediaProducer::HasUserInteractedWithMediaElement) 3585 string.append("HasUserInteractedWithMediaElement,"); 3584 3586 3585 3587 if (string.isEmpty())
Note: See TracChangeset
for help on using the changeset viewer.