Changeset 221044 in webkit

Timestamp:

Aug 22, 2017 2:00:49 PM (7 years ago)

Author:

rniwa@webkit.org

Message:

Speedometer 2.0: Make it possible to change the iteration count via query string
​https://bugs.webkit.org/show_bug.cgi?id=175811

Reviewed by Saam Barati.

Added the support for specifying the iteration count by "iterationCount" query parameter, and replaced "ms"
query parameter by "unit=ms".

Finally, reduced the number of iterations from 20 to 10 to reduce the time needed to run the benchmark
since Speedometer 2.0 contains more than twice the number of libraries and frameworks than Speedometer 1.0.

• Speedometer/resources/main.js:

(window.benchmarkClient.didFinishLastIteration):
(startBenchmark):

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• Speedometer/resources/main.js (modified) (4 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2017-08-22  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Speedometer 2.0: Make it possible to change the iteration count via query string
+        https://bugs.webkit.org/show_bug.cgi?id=175811
+
+        Reviewed by Saam Barati.
+
+        Added the support for specifying the iteration count by "iterationCount" query parameter, and replaced "ms"
+        query parameter by "unit=ms".
+
+        Finally, reduced the number of iterations from 20 to 10 to reduce the time needed to run the benchmark
+        since Speedometer 2.0 contains more than twice the number of libraries and frameworks than Speedometer 1.0.
+
+        * Speedometer/resources/main.js:
+        (window.benchmarkClient.didFinishLastIteration):
+        (startBenchmark):
+
 2017-08-22  Mathias Bynens  <mathias@qiwi.be>
 

trunk/PerformanceTests/Speedometer/resources/main.js

@@ -1 +1 @@
 window.benchmarkClient = {
-    iterationCount: 20,
+    displayUnit: 'runs/min',
+    iterationCount: 10,
     testsCount: null,
     suitesCount: null,
@@ -31 +32 @@
         document.getElementById('logo-link').onclick = null;
 
-        var displayUnit = location.search == '?ms' || location.hash == '#ms' ? 'ms' : 'runs/min';
-        var results = this._computeResults(this._timeValues, displayUnit);
+        var results = this._computeResults(this._timeValues, this.displayUnit);
 
         this._updateGaugeNeedle(results.mean);
@@ -42 +42 @@
         document.getElementById('results-with-statistics').textContent = results.formattedMeanAndDelta;
 
-        if (displayUnit == 'ms') {
+        if (this.displayUnit == 'ms') {
             document.getElementById('show-summary').style.display = 'none';
             showResultDetails();
@@ -151 +151 @@
 
 function startBenchmark() {
+    if (location.search.length > 1) {
+        var parts = location.search.substring(1).split('&');
+        for (var i = 0; i < parts.length; i++) {
+            var keyValue = parts[i].split('=');
+            var key = keyValue[0];
+            var value = keyValue[1];
+            switch (key) {
+            case 'unit':
+                if (value == 'ms')
+                    benchmarkClient.displayUnit = 'ms';
+                else
+                    console.error('Invalid unit: ' + value);
+                break;
+            case 'iterationCount':
+                var parsedValue = parseInt(value);
+                if (!isNaN(value))
+                    benchmarkClient.iterationCount = parsedValue;
+                else
+                    console.error('Invalid iteration count: ' + value);
+                break;
+            }
+        }
+    }
+
     var enabledSuites = Suites.filter(function (suite) { return !suite.disabled });
     var totalSubtestCount = enabledSuites.reduce(function (testsCount, suite) { return testsCount + suite.tests.length; }, 0);