Changeset 221054 in webkit


Ignore:
Timestamp:
Aug 22, 2017 4:11:05 PM (7 years ago)
Author:
rniwa@webkit.org
Message:

REGRESSION(R220043): Speedometer 2.0: Fix vanilla JS examples
​https://bugs.webkit.org/show_bug.cgi?id=175815

Reviewed by Saam Barati.

Both vanilla ES2015 and Babel + WebPack test cases were failing to mark Todo items as completed since they were relying on
new Date().getTime() to generate an unique ID. That's not going to work if mulitple todo items are added within 1ms.

  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.71bb1f671e4e65604d05.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.71bb1f671e4e65604d05.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js.map: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.2102040c9a6e04cc046e.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.2102040c9a6e04cc046e.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.b16cc08e016d07886f5f.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.b16cc08e016d07886f5f.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/index.html:
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.71bb1f671e4e65604d05.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.71bb1f671e4e65604d05.css.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.b16cc08e016d07886f5f.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.b16cc08e016d07886f5f.css.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/store.js:
Location:
trunk/PerformanceTests
Files:
10 added
10 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/PerformanceTests/ChangeLog

    r221051 r221054  
     12017-08-22  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        REGRESSION(R220043): Speedometer 2.0: Fix vanilla JS examples
     4        https://bugs.webkit.org/show_bug.cgi?id=175815
     5
     6        Reviewed by Saam Barati.
     7
     8        Both vanilla ES2015 and Babel + WebPack test cases were failing to mark Todo items as completed since they were relying on
     9        `new Date().getTime()` to generate an unique ID. That's not going to work if mulitple todo items are added within 1ms.
     10
     11        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.71bb1f671e4e65604d05.js: Added.
     12        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.71bb1f671e4e65604d05.js.map: Added.
     13        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js: Removed.
     14        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js.map: Removed.
     15        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.2102040c9a6e04cc046e.js: Added.
     16        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.2102040c9a6e04cc046e.js.map: Added.
     17        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.b16cc08e016d07886f5f.js: Added.
     18        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.b16cc08e016d07886f5f.js.map: Added.
     19        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/index.html:
     20        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.71bb1f671e4e65604d05.css: Added.
     21        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.71bb1f671e4e65604d05.css.map: Added.
     22        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.b16cc08e016d07886f5f.css: Added.
     23        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.b16cc08e016d07886f5f.css.map: Added.
     24        * Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:
     25        * Speedometer/resources/todomvc/vanilla-examples/es2015/src/store.js:
     26
    1272017-08-22  JF Bastien  <jfbastien@apple.com>
    228

  • trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/index.html

    r219903 r221054  
    44    <meta charset="utf-8">
    55    <title>ES2015 + Babel + Webpack TodoMVC example</title>
    6     <script>!function(e){function r(n){if(t[n])return t[n].exports;var o=t[n]={i:n,l:!1,exports:{}};return e[n].call(o.exports,o,o.exports,r),o.l=!0,o.exports}var n=window.webpackJsonp;window.webpackJsonp=function(t,u,a){for(var i,c,f,l=0,s=[];l<t.length;l++)c=t[l],o[c]&&s.push(o[c][0]),o[c]=0;for(i in u)Object.prototype.hasOwnProperty.call(u,i)&&(e[i]=u[i]);for(n&&n(t,u,a);s.length;)s.shift()();if(a)for(l=0;l<a.length;l++)f=r(r.s=a[l]);return f};var t={},o={2:0};r.e=function(e){function n(){u.onerror=u.onload=null,clearTimeout(a);var r=o[e];0!==r&&(r&&r[1](new Error("Loading chunk "+e+" failed.")),o[e]=void 0)}if(0===o[e])return Promise.resolve();if(o[e])return o[e][2];var t=document.getElementsByTagName("head")[0],u=document.createElement("script");u.type="text/javascript",u.charset="utf-8",u.async=!0,u.timeout=12e4,u.src=r.p+"bundle."+e+"."+{0:"9debb1b0a94f14d0ebe9",1:"bade2cb8992d8a68d0d7"}[e]+".js";var a=setTimeout(n,12e4);u.onerror=u.onload=n,t.appendChild(u);var i=new Promise(function(r,n){o[e]=[r,n]});return o[e][2]=i},r.m=e,r.c=t,r.i=function(e){return e},r.d=function(e,r,n){Object.defineProperty(e,r,{configurable:!1,enumerable:!0,get:n})},r.n=function(e){var n=e&&e.__esModule?function(){return e["default"]}:function(){return e};return r.d(n,"a",n),n},r.o=function(e,r){return Object.prototype.hasOwnProperty.call(e,r)},r.p="",r.oe=function(e){throw console.error(e),e}}([]);
     6    <script>!function(e){function r(n){if(t[n])return t[n].exports;var o=t[n]={i:n,l:!1,exports:{}};return e[n].call(o.exports,o,o.exports,r),o.l=!0,o.exports}var n=window.webpackJsonp;window.webpackJsonp=function(t,u,c){for(var i,a,f,l=0,s=[];l<t.length;l++)a=t[l],o[a]&&s.push(o[a][0]),o[a]=0;for(i in u)Object.prototype.hasOwnProperty.call(u,i)&&(e[i]=u[i]);for(n&&n(t,u,c);s.length;)s.shift()();if(c)for(l=0;l<c.length;l++)f=r(r.s=c[l]);return f};var t={},o={2:0};r.e=function(e){function n(){u.onerror=u.onload=null,clearTimeout(c);var r=o[e];0!==r&&(r&&r[1](new Error("Loading chunk "+e+" failed.")),o[e]=void 0)}if(0===o[e])return Promise.resolve();if(o[e])return o[e][2];var t=document.getElementsByTagName("head")[0],u=document.createElement("script");u.type="text/javascript",u.charset="utf-8",u.async=!0,u.timeout=12e4,u.src=r.p+"bundle."+e+"."+{0:"71bb1f671e4e65604d05",1:"b16cc08e016d07886f5f"}[e]+".js";var c=setTimeout(n,12e4);u.onerror=u.onload=n,t.appendChild(u);var i=new Promise(function(r,n){o[e]=[r,n]});return o[e][2]=i},r.m=e,r.c=t,r.i=function(e){return e},r.d=function(e,r,n){Object.defineProperty(e,r,{configurable:!1,enumerable:!0,get:n})},r.n=function(e){var n=e&&e.__esModule?function(){return e["default"]}:function(){return e};return r.d(n,"a",n),n},r.o=function(e,r){return Object.prototype.hasOwnProperty.call(e,r)},r.p="",r.oe=function(e){throw console.error(e),e}}([]);
    77</script>
    8   <link href="styles.vendor.bade2cb8992d8a68d0d7.css" rel="stylesheet"><link href="styles.app.9debb1b0a94f14d0ebe9.css" rel="stylesheet"><script type="text/javascript" src="bundle.vendor.bade2cb8992d8a68d0d7.js"></script><script type="text/javascript" src="bundle.app.9debb1b0a94f14d0ebe9.js"></script></head>
     8  <link href="styles.vendor.b16cc08e016d07886f5f.css" rel="stylesheet"><link href="styles.app.71bb1f671e4e65604d05.css" rel="stylesheet"><script type="text/javascript" src="bundle.vendor.b16cc08e016d07886f5f.js"></script><script type="text/javascript" src="bundle.app.71bb1f671e4e65604d05.js"></script></head>
    99  <body>
    1010    <section class="todoapp">

  • trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js

    r216727 r221054  
    22import * as localStorageMemory from './memory'
    33export default Store
     4
     5var uniqueID = 1;
    46
    57/**
    … …  
    109111  } else {
    110112    // Generate an ID
    111     updateData.id = new Date().getTime()
     113    updateData.id = uniqueID++;
    112114
    113115    todos.push(updateData)

  • trunk/PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015/src/store.js

    r216718 r221054  
    11/*jshint eqeqeq:false */
    22'use strict';
     3
     4let uniqueID = 1;
    35
    46/**
    … …  
    100102        } else {
    101103            // Generate an ID
    102             updateData.id = new Date().getTime();
     104            updateData.id = uniqueID++;
    103105
    104106            todos.push(updateData);
Note: See TracChangeset for help on using the changeset viewer.