Changeset 221075 in webkit

Timestamp:

Aug 23, 2017 8:16:23 AM (7 years ago)

Author:

clopez@igalia.com

Message:

[WPE] Some event handlers not working.
​https://bugs.webkit.org/show_bug.cgi?id=175864

Reviewed by Michael Catanzaro.

Source/WebCore:

Share the EventHandler implementation with the GTK port and add ifdefs where needed.

Covered by existing tests.

• PlatformGTK.cmake:
• PlatformWPE.cmake:
• page/wpe/EventHandlerWPE.cpp: Removed.
• platform/glib/EventHandlerGlib.cpp: Renamed from Source/WebCore/page/gtk/EventHandlerGtk.cpp.

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

LayoutTests:

Remove expected failures for tests that now pass, add new expectation
for a test that is failing also on GTK+ and rebaseline a test with
the same expected result than on GTK+.

• platform/wpe/TestExpectations:
• platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/wpe/TestExpectations (modified) (6 diffs)
• LayoutTests/platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/PlatformGTK.cmake (modified) (1 diff)
• Source/WebCore/PlatformWPE.cmake (modified) (1 diff)
• Source/WebCore/page/wpe (deleted)
• Source/WebCore/platform/glib/EventHandlerGlib.cpp (moved) (moved from trunk/Source/WebCore/page/gtk/EventHandlerGtk.cpp) (6 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-08-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [WPE] Some event handlers not working.
+        https://bugs.webkit.org/show_bug.cgi?id=175864
+
+        Reviewed by Michael Catanzaro.
+
+        Remove expected failures for tests that now pass, add new expectation
+        for a test that is failing also on GTK+ and rebaseline a test with
+        the same expected result than on GTK+.
+
+        * platform/wpe/TestExpectations:
+        * platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.
+
 2017-08-23  Ms2ger  <Ms2ger@igalia.com>
 

trunk/LayoutTests/platform/wpe/TestExpectations

@@ -462 +462 @@
 # Most of them are probably failing because of missing support of event related
 # features in WPE.
-webkit.org/b/173419 fast/events/autoscroll-in-overflow-hidden-html.html [ Failure ]
 webkit.org/b/173419 fast/events/autoscroll-in-textarea.html [ Failure ]
 webkit.org/b/173419 fast/events/autoscroll-in-textfield.html [ Failure ]
@@ -484 +483 @@
 webkit.org/b/173419 fast/events/input-events-paste-rich-datatransfer.html [ Failure ]
 webkit.org/b/173419 fast/events/js-keyboard-event-creation.html [ Failure ]
-webkit.org/b/173419 fast/events/keydown-1.html [ Failure ]
 webkit.org/b/173419 fast/events/keydown-numpad-keys.html [ Failure ]
 webkit.org/b/173419 fast/events/mouse-cursor-image-set.html [ Failure ]
-webkit.org/b/173419 fast/events/mouse-drag-from-frame-to-other-frame.html [ Failure ]
-webkit.org/b/173419 fast/events/mouse-drag-from-frame.html [ Failure ]
-webkit.org/b/173419 fast/events/mouseenterleave-on-subframe.html [ Failure ]
 webkit.org/b/173419 fast/events/mouseover-button.html [ Failure ]
-webkit.org/b/173419 fast/events/mouseover-mouseout.html [ Failure ]
-webkit.org/b/173419 fast/events/mouseover-mouseout2.html [ Failure ]
 webkit.org/b/173419 fast/events/mouseup-from-button2.html [ Failure ]
 webkit.org/b/173419 fast/events/no-scroll-on-input-text-selection.html [ Failure ]
@@ -499 +492 @@
 webkit.org/b/173419 fast/events/onchange-range-slider.html [ Failure ]
 webkit.org/b/173419 fast/events/option-tab.html [ Failure ]
-webkit.org/b/173419 fast/events/page-scaled-mouse-click-iframe.html [ Failure ]
 webkit.org/b/173419 fast/events/platform-wheelevent-in-scrolling-div.html [ Failure ]
 webkit.org/b/173419 fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html [ Failure ]
@@ -533 +525 @@
 webkit.org/b/173419 fast/events/autoscroll-when-zoomed.html [ Timeout ]
 webkit.org/b/173419 fast/events/before-input-prevent-insert-replacement.html [ Timeout ]
-webkit.org/b/173419 fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html [ Timeout ]
 webkit.org/b/173419 fast/events/clipboard-dataTransferItemList.html [ Timeout ]
 webkit.org/b/173419 fast/events/drag-dataTransferItemList.html [ Timeout ]
 webkit.org/b/173419 fast/events/event-view-toString.html [ Timeout ]
-webkit.org/b/173419 fast/events/frame-detached-in-mousedown.html [ Timeout ]
-webkit.org/b/173419 fast/events/iframe-onmousemove.html [ Timeout ]
 webkit.org/b/173419 fast/events/input-event-insert-replacement.html [ Timeout ]
 webkit.org/b/173419 fast/events/mouse-force-changed.html [ Timeout ]
 webkit.org/b/173419 fast/events/mouse-force-down.html [ Timeout ]
 webkit.org/b/173419 fast/events/mouse-force-up.html [ Timeout ]
-webkit.org/b/173419 fast/events/mouse-moved-remove-frame-crash.html [ Timeout ]
 webkit.org/b/173419 fast/events/page-visibility-iframe-delete-test.html [ Timeout ]
 webkit.org/b/173419 fast/events/page-visibility-iframe-move-test.html [ Timeout ]
@@ -549 +537 @@
 webkit.org/b/173419 fast/events/page-visibility-onvisibilitychange.html [ Timeout ]
 webkit.org/b/173419 fast/events/page-visibility-transition-test.html [ Timeout ]
-webkit.org/b/173419 fast/events/popup-blocking-click-in-iframe.html [ Timeout ]
 webkit.org/b/173419 fast/events/scroll-after-click-on-tab-index.html [ Timeout ]
 webkit.org/b/173419 fast/events/standalone-image-drag-to-editable.html [ Timeout ]
-webkit.org/b/173419 fast/events/touch/emulated-touch-iframe.html [ Timeout ]
 webkit.org/b/173419 fast/events/touch/multi-touch-grouped-targets.html [ Timeout ]
 webkit.org/b/173419 fast/events/touch/multi-touch-inside-nested-iframes.html [ Timeout ]
@@ -558 +544 @@
 webkit.org/b/173419 fast/events/touch/touch-target-limited.html [ Timeout ]
 webkit.org/b/173419 fast/events/touch/touch-target.html [ Timeout ]
-webkit.org/b/173419 fast/events/wheel-event-destroys-frame.html [ Timeout ]
+
+webkit.org/b/173411 fast/events/touch/frame-hover-update.html [ Failure ]
 
 fast/events/ios [ Skip ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [WPE] Some event handlers not working.
+        https://bugs.webkit.org/show_bug.cgi?id=175864
+
+        Reviewed by Michael Catanzaro.
+
+        Share the EventHandler implementation with the GTK port and add ifdefs where needed.
+
+        Covered by existing tests.
+
+        * PlatformGTK.cmake:
+        * PlatformWPE.cmake:
+        * page/wpe/EventHandlerWPE.cpp: Removed.
+        * platform/glib/EventHandlerGlib.cpp: Renamed from Source/WebCore/page/gtk/EventHandlerGtk.cpp.
+        (WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):
+
 2017-08-22  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/PlatformGTK.cmake

@@ -146 +146 @@
 
     page/gtk/DragControllerGtk.cpp
-    page/gtk/EventHandlerGtk.cpp
+
+    platform/glib/EventHandlerGlib.cpp
 
     platform/graphics/PlatformDisplay.cpp

trunk/Source/WebCore/PlatformWPE.cmake

@@ -133 +133 @@
     editing/wpe/EditorWPE.cpp
 
-    page/wpe/EventHandlerWPE.cpp
+    platform/glib/EventHandlerGlib.cpp
 
     platform/graphics/egl/GLContextEGLWPE.cpp

trunk/Source/WebCore/platform/glib/EventHandlerGlib.cpp

@@ -1 +1 @@
 /*
  * Copyright (C) 2006 Zack Rusin <zack@kde.org>
+ * Copyright (C) 2014-2017 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -27 +28 @@
 #include "EventHandler.h"
 
-#include "DataTransfer.h"
-#include "FloatPoint.h"
 #include "FocusController.h"
 #include "Frame.h"
@@ -39 +38 @@
 #include "PlatformWheelEvent.h"
 #include "RenderWidget.h"
+
+#if ENABLE(DRAG_SUPPORT)
+#include "DataTransfer.h"
+#endif
+
+#if PLATFORM(GTK)
 #include "Scrollbar.h"
+#endif
 
 namespace WebCore {
@@ -81 +87 @@
 bool EventHandler::eventActivatedView(const PlatformMouseEvent&) const
 {
-    //GTK+ activation is not necessarily tied to mouse events, so it may
-    //not make sense to implement this
+    // GTK+ activation is not necessarily tied to mouse events, so it may
+    // not make sense to implement this
 
     notImplemented();
@@ -134 +140 @@
 bool EventHandler::shouldTurnVerticalTicksIntoHorizontal(const HitTestResult& result, const PlatformWheelEvent& event) const
 {
+#if PLATFORM(GTK)
     FrameView* view = m_frame.view();
     Scrollbar* scrollbar = view ? view->scrollbarAtPoint(event.position()) : nullptr;
@@ -139 +146 @@
         scrollbar = result.scrollbar();
     return scrollbar && scrollbar->orientation() == HorizontalScrollbar;
+#else
+    UNUSED_PARAM(result);
+    UNUSED_PARAM(event);
+    notImplemented();
+    return false;
+#endif
 }