Changeset 221114 in webkit

Timestamp:

Aug 23, 2017 4:04:13 PM (7 years ago)

Author:

rniwa@webkit.org

Message:

Speedometer 2.0: Add the capability to run a specific suite
​https://bugs.webkit.org/show_bug.cgi?id=175908

Reviewed by Saam Barati.

Added ?suite=X query parameter to specify a specific suite (e.g. React-TodoMVC) to run.

• Speedometer/resources/main.js:

(enableOneSuite): Added.
(startBenchmark): Return true if the benchmark actually had started running.
(startTest): Don't transition to the "running" state if the benchmark failed to start (e.g. no tests to run).

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• Speedometer/resources/main.js (modified) (4 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2017-08-23  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Speedometer 2.0: Add the capability to run a specific suite
+        https://bugs.webkit.org/show_bug.cgi?id=175908
+
+        Reviewed by Saam Barati.
+
+        Added ?suite=X query parameter to specify a specific suite (e.g. React-TodoMVC) to run.
+
+        * Speedometer/resources/main.js:
+        (enableOneSuite): Added.
+        (startBenchmark): Return true if the benchmark actually had started running.
+        (startTest): Don't transition to the "running" state if the benchmark failed to start (e.g. no tests to run).
+
 2017-08-23  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/PerformanceTests/Speedometer/resources/main.js

@@ -150 +150 @@
 }
 
+function enableOneSuite(suites, suiteToEnable)
+{
+    suiteToEnable = suiteToEnable.toLowerCase();
+    var found = false;
+    for (var i = 0; i < suites.length; i++) {
+        var currentSuite = suites[i];
+        if (currentSuite.name.toLowerCase() == suiteToEnable) {
+            currentSuite.disabled = false;
+            found = true;
+        } else
+            currentSuite.disabled = true;
+    }
+    return found;
+}
+
 function startBenchmark() {
+    var enabledSuites = Suites.filter(function (suite) { return !suite.disabled; });
+
     if (location.search.length > 1) {
         var parts = location.search.substring(1).split('&');
@@ -171 +188 @@
                     console.error('Invalid iteration count: ' + value);
                 break;
+            case 'suite':
+                if (!enableOneSuite(Suites, value)) {
+                    alert('No tests to run');
+                    return false;
+                }
+                break;
             }
         }
     }
 
-    var enabledSuites = Suites.filter(function (suite) { return !suite.disabled });
+    var enabledSuites = Suites.filter(function (suite) { return !suite.disabled; });
     var totalSubtestCount = enabledSuites.reduce(function (testsCount, suite) { return testsCount + suite.tests.length; }, 0);
     benchmarkClient.testsCount = benchmarkClient.iterationCount * totalSubtestCount;
@@ -181 +204 @@
     var runner = new BenchmarkRunner(Suites, benchmarkClient);
     runner.runMultipleIterations(benchmarkClient.iterationCount);
+
+    return true;
 }
 
@@ -206 +231 @@
 
 function startTest() {
-    showSection('running');
-    startBenchmark();
+    if (startBenchmark())
+        showSection('running');
 }