Changeset 221138 in webkit

Timestamp:

Aug 24, 2017 8:59:24 AM (7 years ago)

Author:

Chris Dumez

Message:

[iOS] ViewServices started by StoreKitUIService may get suspended unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=175922
<rdar://problem/34028921>

Reviewed by Tim Horton.

ViewServices started by StoreKitUIService may get suspended unexpectedly. This is
because StoreKitUIService is itself a ViewService and is therefore in the background.
To address the issue, treat StoreKitUIService as initially foreground in
ApplicationStateTracker so that its ViewServices do not get suspended. We don't
have good way to deal with ViewServices started by other ViewServices unfortunately.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/spi/ios/UIKitSPI.h (modified) (1 diff)
• UIProcess/ApplicationStateTracker.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-08-24  Chris Dumez  <cdumez@apple.com>
+
+        [iOS] ViewServices started by StoreKitUIService may get suspended unexpectedly
+        https://bugs.webkit.org/show_bug.cgi?id=175922
+        <rdar://problem/34028921>
+
+        Reviewed by Tim Horton.
+
+        ViewServices started by StoreKitUIService may get suspended unexpectedly. This is
+        because StoreKitUIService is itself a ViewService and is therefore in the background.
+        To address the issue, treat StoreKitUIService as initially foreground in
+        ApplicationStateTracker so that its ViewServices do not get suspended. We don't
+        have good way to deal with ViewServices started by other ViewServices unfortunately.
+
+        * Platform/spi/ios/UIKitSPI.h:
+        * UIProcess/ApplicationStateTracker.mm:
+        (WebKit::ApplicationStateTracker::ApplicationStateTracker):
+
 2017-08-23  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h

@@ -398 +398 @@
 @interface UIViewController (ViewService)
 - (pid_t)_hostProcessIdentifier;
+@property (readonly) NSString *_hostApplicationBundleIdentifier;
 @end
 

trunk/Source/WebKit/UIProcess/ApplicationStateTracker.mm

@@ -147 +147 @@
         [applicationStateMonitor invalidate];
 
+        // Workaround for <rdar://problem/34028921>. If the host application is StoreKitUIService then it is also a ViewService
+        // and is always in the background. We need to treat StoreKitUIService as foreground for the purpose of process suspension
+        // or its ViewServices will get suspended.
+        if ([serviceViewController._hostApplicationBundleIdentifier isEqualToString:@"com.apple.ios.StoreKitUIService"])
+            m_isInBackground = false;
+
         m_didEnterBackgroundObserver = [notificationCenter addObserverForName:@"_UIViewServiceHostDidEnterBackgroundNotification" object:serviceViewController queue:nil usingBlock:[this](NSNotification *) {
             applicationDidEnterBackground();