Changeset 221165 in webkit

Timestamp:

Aug 24, 2017 3:37:15 PM (7 years ago)

Author:

beidson@apple.com

Message:

Remove duplicate WebCore::URL encoder/decoder
​https://bugs.webkit.org/show_bug.cgi?id=175952

Reviewed by Chris Dumez.

Don't need the WebCoreArgumentCoder in WebKit since the URL class defines its own coders.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<URL>::encode): Deleted.
(IPC::ArgumentCoder<URL>::decode): Deleted.

• Shared/WebCoreArgumentCoders.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebCoreArgumentCoders.cpp (modified) (1 diff)
• Shared/WebCoreArgumentCoders.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-08-24  Brady Eidson  <beidson@apple.com>
+
+        Remove duplicate WebCore::URL encoder/decoder
+        https://bugs.webkit.org/show_bug.cgi?id=175952
+
+        Reviewed by Chris Dumez.
+
+        Don't need the WebCoreArgumentCoder in WebKit since the URL class defines its own coders.
+
+        * Shared/WebCoreArgumentCoders.cpp:
+        (IPC::ArgumentCoder<URL>::encode): Deleted.
+        (IPC::ArgumentCoder<URL>::decode): Deleted.
+        * Shared/WebCoreArgumentCoders.h:
+
 2017-08-24  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp

@@ -1817 +1817 @@
 }
 
-void ArgumentCoder<URL>::encode(Encoder& encoder, const URL& result)
-{
-    encoder << result.string();
-}
-    
-bool ArgumentCoder<URL>::decode(Decoder& decoder, URL& result)
-{
-    String urlAsString;
-    if (!decoder.decode(urlAsString))
-        return false;
-    result = URL(ParsedURLString, urlAsString);
-    return true;
-}
-
 void ArgumentCoder<UserStyleSheet>::encode(Encoder& encoder, const UserStyleSheet& userStyleSheet)
 {

trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h

@@ -486 +486 @@
     static bool decode(Decoder&, WebCore::TextCheckingResult&);
 };
-    
-template<> struct ArgumentCoder<WebCore::URL> {
-    static void encode(Encoder&, const WebCore::URL&);
-    static bool decode(Decoder&, WebCore::URL&);
-};
 
 template<> struct ArgumentCoder<WebCore::UserStyleSheet> {