Changeset 221174 in webkit

Timestamp:

Aug 24, 2017 5:57:42 PM (7 years ago)

Author:

webkit@devinrousso.com

Message:

Web Inspector: add filter for draw actions in Recordings
​https://bugs.webkit.org/show_bug.cgi?id=175448
<rdar://problem/34040764>

Reviewed by Matt Baker.

• Localizations/en.lproj/localizedStrings.js:

• UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel.prototype.initialLayout):
(WI.RecordingNavigationSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
Add button to filter visual actions.
Drive-by fix: ensure that frame folders are still visible when filtering.

• UserInterface/Images/Paint.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/PaintFlashing.svg.
• UserInterface/Images/gtk/Paint.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/PaintFlashing.svg.
• UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):
Rename PaintFlashing.svg to Paint.svg.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• UserInterface/Images/Paint.svg (moved) (moved from trunk/Source/WebInspectorUI/UserInterface/Images/PaintFlashing.svg)
• UserInterface/Images/gtk/Paint.svg (moved) (moved from trunk/Source/WebInspectorUI/UserInterface/Images/gtk/PaintFlashing.svg)
• UserInterface/Views/DOMTreeContentView.js (modified) (1 diff)
• UserInterface/Views/RecordingNavigationSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-08-24  Devin Rousso  <webkit@devinrousso.com>
+
+        Web Inspector: add filter for draw actions in Recordings
+        https://bugs.webkit.org/show_bug.cgi?id=175448
+        <rdar://problem/34040764>
+
+        Reviewed by Matt Baker.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        
+        * UserInterface/Views/RecordingNavigationSidebarPanel.js:
+        (WI.RecordingNavigationSidebarPanel.prototype.initialLayout):
+        (WI.RecordingNavigationSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
+        Add button to filter visual actions.
+        Drive-by fix: ensure that frame folders are still visible when filtering.
+
+        * UserInterface/Images/Paint.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/PaintFlashing.svg.
+        * UserInterface/Images/gtk/Paint.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/PaintFlashing.svg.
+        * UserInterface/Views/DOMTreeContentView.js:
+        (WI.DOMTreeContentView):
+        Rename PaintFlashing.svg to Paint.svg.
+
 2017-08-24  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -609 +609 @@
 localizedStrings["Online"] = "Online";
 localizedStrings["Only show resources with issues"] = "Only show resources with issues";
+localizedStrings["Only show visual actions"] = "Only show visual actions";
 localizedStrings["Opacity"] = "Opacity";
 localizedStrings["Open"] = "Open";
@@ -792 +793 @@
 localizedStrings["Show Scope Chain on pause"] = "Show Scope Chain on pause";
 localizedStrings["Show Source"] = "Show Source";
+localizedStrings["Show all actions"] = "Show all actions";
 localizedStrings["Show all resources"] = "Show all resources";
 localizedStrings["Show compositing borders"] = "Show compositing borders";

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js

@@ -37 +37 @@
 
         WI.showPaintRectsSetting.addEventListener(WI.Setting.Event.Changed, this._showPaintRectsSettingChanged, this);
-        this._paintFlashingButtonNavigationItem = new WI.ActivateButtonNavigationItem("paint-flashing", WI.UIString("Enable paint flashing"), WI.UIString("Disable paint flashing"), "Images/PaintFlashing.svg", 16, 16);
+        this._paintFlashingButtonNavigationItem = new WI.ActivateButtonNavigationItem("paint-flashing", WI.UIString("Enable paint flashing"), WI.UIString("Disable paint flashing"), "Images/Paint.svg", 16, 16);
         this._paintFlashingButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._togglePaintFlashing, this);
         this._paintFlashingButtonNavigationItem.enabled = !!PageAgent.setShowPaintRects;

trunk/Source/WebInspectorUI/UserInterface/Views/RecordingNavigationSidebarPanel.js

@@ -141 +141 @@
         const element = null;
         this.addSubview(new WI.NavigationBar(element, [importNavigationItem, exportNavigationItem]));
+
+        let filterFunction = (treeElement) => {
+            if (!(treeElement instanceof WI.RecordingActionTreeElement))
+                return false;
+
+            return treeElement.representedObject.isVisual;
+        };
+
+        const activatedByDefault = false;
+        const defaultToolTip = WI.UIString("Only show visual actions");
+        const activatedToolTip = WI.UIString("Show all actions");
+        this.filterBar.addFilterBarButton("recording-show-visual-only", filterFunction, activatedByDefault, defaultToolTip, activatedToolTip, "Images/Paint.svg", 15, 15);
+    }
+
+    matchTreeElementAgainstCustomFilters(treeElement)
+    {
+        // Keep recording frame tree elements.
+        if (treeElement instanceof WI.FolderTreeElement)
+            return true;
+
+        return super.matchTreeElementAgainstCustomFilters(treeElement);
     }