Changeset 221240 in webkit

Timestamp:

Aug 28, 2017 4:46:14 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Ensure that the alert function is called in TestWebExtensions.
​https://bugs.webkit.org/show_bug.cgi?id=175880

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-28
Reviewed by Carlos Garcia Campos.

The test relied on a bug in the HTMLDocument JavaScript bindings: when calling
document.open() with three arguments, it would call any function set as the
"open" property on the window object, rather than just the real Window::open()
method. This bug was fixed by the removal of custom bindings for HTMLDocument
in r218437. As a result, the test no longer called alert(), which caused it to
fail.

Instead, call the window.open() function directly.

• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionIsolatedWorld):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-08-28  Ms2ger  <Ms2ger@gmail.com>
+
+        Ensure that the alert function is called in TestWebExtensions.
+        https://bugs.webkit.org/show_bug.cgi?id=175880
+
+        Reviewed by Carlos Garcia Campos.
+
+        The test relied on a bug in the HTMLDocument JavaScript bindings: when calling
+        document.open() with three arguments, it would call any function set as the
+        "open" property on the window object, rather than just the real Window::open()
+        method. This bug was fixed by the removal of custom bindings for HTMLDocument
+        in r218437. As a result, the test no longer called alert(), which caused it to
+        fail.
+
+        Instead, call the window.open() function directly.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
+        (testWebExtensionIsolatedWorld):
+
 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp

@@ -149 +149 @@
         "document.getElementById('console').innerHTML = top.foo;\n"
         "window.open = function () { alert('Main World'); }\n"
-        "document.open(1, 2, 3);";
+        "window.open();";
     test->runJavaScriptAndWaitUntilFinished(mainWorldScript, 0);
     g_assert_cmpstr(scriptDialogResult.get(), ==, "Main World");
@@ -161 +161 @@
         "document.getElementById('console').innerHTML = top.foo;\n"
         "window.open = function () { alert('Isolated World'); }\n"
-        "document.open(1, 2, 3);";
+        "window.open();";
     GUniquePtr<char> extensionBusName(g_strdup_printf("org.webkit.gtk.WebExtensionTest%u", Test::s_webExtensionID));
     GRefPtr<GDBusProxy> proxy = adoptGRef(bus->createProxy(extensionBusName.get(),