Changeset 221372 in webkit


Ignore:
Timestamp:
Aug 30, 2017 8:06:43 AM (7 years ago)
Author:
clopez@igalia.com
Message:

[WPE] Enable MEMORY_SAMPLER
https://bugs.webkit.org/show_bug.cgi?id=176099

Reviewed by Michael Catanzaro.

.:

Enable the otion at build time by default on Linux (currently
there are only Linux and Mac implementations of this feature).

  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsGTK.cmake:

Source/WebKit:

Enable it at runtime if the environment variable WEBKIT_SAMPLE_MEMORY is set.

  • UIProcess/API/wpe/WPEView.cpp:

(WKWPE::m_compositingManagerProxy):

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r221368 r221372  
     12017-08-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [WPE] Enable MEMORY_SAMPLER
     4        https://bugs.webkit.org/show_bug.cgi?id=176099
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Enable the otion at build time by default on Linux (currently
     9        there are only Linux and Mac implementations of this feature).
     10
     11        * Source/cmake/OptionsWPE.cmake:
     12        * Source/cmake/OptionsGTK.cmake:
     13
    1142017-08-30  Carlos Garcia Campos  <cgarcia@igalia.com>
    215
  • trunk/Source/WebKit/ChangeLog

    r221351 r221372  
     12017-08-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
     2
     3        [WPE] Enable MEMORY_SAMPLER
     4        https://bugs.webkit.org/show_bug.cgi?id=176099
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Enable it at runtime if the environment variable WEBKIT_SAMPLE_MEMORY is set.
     9
     10        * UIProcess/API/wpe/WPEView.cpp:
     11        (WKWPE::m_compositingManagerProxy):
     12
    1132017-08-30  Andy Estes  <aestes@apple.com>
    214
  • trunk/Source/WebKit/UIProcess/API/wpe/WPEView.cpp

    r218741 r221372  
    6666    auto* pool = configuration->processPool();
    6767    m_pageProxy = pool->createWebPage(*m_pageClient, WTFMove(configuration));
     68
     69#if ENABLE(MEMORY_SAMPLER)
     70    if (getenv("WEBKIT_SAMPLE_MEMORY"))
     71        pool->startMemorySampler(0);
     72#endif
    6873
    6974    m_backend = backend;
  • trunk/Source/cmake/OptionsGTK.cmake

    r221368 r221372  
    124124
    125125if (CMAKE_SYSTEM_NAME MATCHES "Linux")
    126     WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PUBLIC ON)
     126    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE ON)
    127127    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON)
    128128else ()
    129     WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PUBLIC OFF)
     129    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE OFF)
    130130    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF)
    131131endif ()
  • trunk/Source/cmake/OptionsWPE.cmake

    r221072 r221372  
    3737
    3838if (CMAKE_SYSTEM_NAME MATCHES "Linux")
     39    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE ON)
    3940    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON)
    4041else ()
     42    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEMORY_SAMPLER PRIVATE OFF)
    4143    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF)
    4244endif ()
Note: See TracChangeset for help on using the changeset viewer.