Changeset 221401 in webkit

Timestamp:

Aug 30, 2017 3:45:26 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Speedometer 2.0: jQuery test fails occasionally
​https://bugs.webkit.org/show_bug.cgi?id=176017

Patch by Shiyu Zhang <​shiyu.zhang@intel.com> on 2017-08-30
Reviewed by Ryosuke Niwa.

Create a dummy node to notify that app is ready for jQuery suite. It prevents Speedometer injecting items before app.js is loaded.

• Speedometer/resources/tests.js:

(Suites.push.prepare):

• Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js:

(jQuery.App.init):

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• Speedometer/resources/tests.js (modified) (1 diff)
• Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js (modified) (1 diff)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2017-08-30  Shiyu Zhang  <shiyu.zhang@intel.com>
+
+        Speedometer 2.0: jQuery test fails occasionally
+        https://bugs.webkit.org/show_bug.cgi?id=176017
+
+        Reviewed by Ryosuke Niwa.
+
+        Create a dummy node to notify that app is ready for jQuery suite. It prevents Speedometer injecting items before app.js is loaded.
+
+        * Speedometer/resources/tests.js:
+        (Suites.push.prepare):
+        * Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js:
+        (jQuery.App.init):
+
 2017-08-25  Mathias Bynens  <mathias@qiwi.be>
 

trunk/PerformanceTests/Speedometer/resources/tests.js

@@ -356 +356 @@
     url: 'todomvc/architecture-examples/jquery/index.html',
     prepare: function (runner, contentWindow, contentDocument) {
-        return runner.waitForElement('#new-todo').then(function (element) {
-            element.focus();
-            return element;
+        return runner.waitForElement('#appIsReady').then(function (element) {
+            var newTodo = contentDocument.getElementById('new-todo');
+            newTodo.focus();
+            return newTodo;
         });
     },

trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js

@@ -47 +47 @@
                 }.bind(this)
             }).init('/all');
+
+            var dummyNodeToNotifyAppIsReady = document.createElement('div');
+            dummyNodeToNotifyAppIsReady.id = 'appIsReady';
+            document.body.appendChild(dummyNodeToNotifyAppIsReady);
         },
         bindEvents: function () {