Changeset 221589 in webkit

Timestamp:

Sep 4, 2017 9:27:38 AM (7 years ago)

Author:

Darin Adler

Message:

REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=175329

Reviewed by Wenson Hsieh.

These tests rely on using setTimeout to wait a run loop iteration for the
video controls to appear. With changes to how loading occurs, it can now
take two run loop iterations. The concept here is inherently a bit flaky
and racy -- end users will not be able to tell how many run loop cycles it
takes for controls to come up, and websites can't tell either -- but for now
changing the tests to wait one more run loop should get rid of the flakiness.

• TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm: Re-enable test.

• TestWebKitAPI/Tests/WebKitCocoa/full-size-autoplaying-video-with-audio.html: Add a

second setTimeout and a comment.

• TestWebKitAPI/Tests/WebKitCocoa/skinny-autoplaying-video-with-audio.html: Ditto.
• TestWebKitAPI/Tests/WebKitCocoa/wide-autoplaying-video-with-audio.html: Ditto.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/full-size-autoplaying-video-with-audio.html (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/skinny-autoplaying-video-with-audio.html (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/wide-autoplaying-video-with-audio.html (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-09-03  Darin Adler  <darin@apple.com>
+
+        REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=175329
+
+        Reviewed by Wenson Hsieh.
+
+        These tests rely on using setTimeout to wait a run loop iteration for the
+        video controls to appear. With changes to how loading occurs, it can now
+        take two run loop iterations. The concept here is inherently a bit flaky
+        and racy -- end users will not be able to tell how many run loop cycles it
+        takes for controls to come up, and websites can't tell either -- but for now
+        changing the tests to wait one more run loop should get rid of the flakiness.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm: Re-enable test.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/full-size-autoplaying-video-with-audio.html: Add a
+        second setTimeout and a comment.
+        * TestWebKitAPI/Tests/WebKitCocoa/skinny-autoplaying-video-with-audio.html: Ditto.
+        * TestWebKitAPI/Tests/WebKitCocoa/wide-autoplaying-video-with-audio.html: Ditto.
+
 2017-09-03  Sam Weinig  <sam@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm

@@ -433 +433 @@
 }
 
-// FIXME: Re-enable this test once <webkit.org/b/175329> is resolved.
-TEST(VideoControlsManager, DISABLED_VideoControlsManagerWideMediumSizedVideoInWideMainFrame)
+TEST(VideoControlsManager, VideoControlsManagerWideMediumSizedVideoInWideMainFrame)
 {
     RetainPtr<VideoControlsManagerTestWebView*> webView = setUpWebViewForTestingVideoControlsManager(NSMakeRect(0, 0, 1600, 800));

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/full-size-autoplaying-video-with-audio.html

@@ -9 +9 @@
     </style>
     <script>
-    function finishTest() {
-        setTimeout(function() {
-            try {
-                window.webkit.messageHandlers.testHandler.postMessage("playing");
-            } catch(e) { }
-        }, 0);
-    }
-   </script>
+        function finishTest()
+        {
+            // As of this writing, two times through the run loop is long enough for the controls to come up.
+            // There's no guarantee; whether the controls are visible is not web exposed, so it doesn't have
+            // to happen in a certain number of timeouts.
+            setTimeout(function() {
+                setTimeout(function() {
+                    webkit.messageHandlers.testHandler.postMessage("playing");
+                }, 0);
+            }, 0);
+        }
+    </script>
 </head>
 <body>

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/skinny-autoplaying-video-with-audio.html

@@ -9 +9 @@
     </style>
     <script>
-    function finishTest() {
-        setTimeout(function() {
-            try {
-                window.webkit.messageHandlers.testHandler.postMessage("playing");
-            } catch(e) { }
-        }, 0);
-    }
-   </script>
+        function finishTest()
+        {
+            // As of this writing, two times through the run loop is long enough for the controls to come up.
+            // There's no guarantee; whether the controls are visible is not web exposed, so it doesn't have
+            // to happen in a certain number of timeouts.
+            setTimeout(function() {
+                setTimeout(function() {
+                    webkit.messageHandlers.testHandler.postMessage("playing");
+                }, 0);
+            }, 0);
+        }
+    </script>
 </head>
 <body>

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/wide-autoplaying-video-with-audio.html

@@ -9 +9 @@
     </style>
     <script>
-    function finishTest() {
-        setTimeout(function() {
-            try {
-                window.webkit.messageHandlers.testHandler.postMessage("playing");
-            } catch(e) { }
-        }, 0);
-    }
-   </script>
+        function finishTest()
+        {
+            // As of this writing, two times through the run loop is long enough for the controls to come up.
+            // There's no guarantee; whether the controls are visible is not web exposed, so it doesn't have
+            // to happen in a certain number of timeouts.
+            setTimeout(function() {
+                setTimeout(function() {
+                    webkit.messageHandlers.testHandler.postMessage("playing");
+                }, 0);
+            }, 0);
+        }
+    </script>
 </head>
 <body>