Changeset 221833 in webkit

Timestamp:

Sep 10, 2017 2:54:31 AM (7 years ago)

Author:

Michael Catanzaro

Message:

[GTK] Improve Ctrl+W and Ctrl+Q shortcuts in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=176619

Reviewed by Carlos Garcia Campos.

There are two different problems here. First, Ctrl+W is closing the entire window. That made
sense when I implemented the shortcut a couple years ago, but now MiniBrowser supports tabs
and it should really close only one single tab. Fix that.

Next, the keyboard shortcuts are not using webkit_web_view_try_close() and so are bypassing
onbeforeunload handlers, which are respected when closing with the mouse. Fix that too.

• MiniBrowser/gtk/BrowserWindow.c:

(browserWindowTryCloseCurrentWebView):
(browserWindowTryClose):
(browser_window_init):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/gtk/BrowserWindow.c (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [GTK] Improve Ctrl+W and Ctrl+Q shortcuts in MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=176619
+
+        Reviewed by Carlos Garcia Campos.
+
+        There are two different problems here. First, Ctrl+W is closing the entire window. That made
+        sense when I implemented the shortcut a couple years ago, but now MiniBrowser supports tabs
+        and it should really close only one single tab. Fix that.
+
+        Next, the keyboard shortcuts are not using webkit_web_view_try_close() and so are bypassing
+        onbeforeunload handlers, which are respected when closing with the mouse. Fix that too.
+
+        * MiniBrowser/gtk/BrowserWindow.c:
+        (browserWindowTryCloseCurrentWebView):
+        (browserWindowTryClose):
+        (browser_window_init):
+
 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Tools/MiniBrowser/gtk/BrowserWindow.c

@@ -255 +255 @@
 }
 
+static void browserWindowTryCloseCurrentWebView(BrowserWindow *window)
+{
+    int currentPage = gtk_notebook_get_current_page(GTK_NOTEBOOK(window->notebook));
+    BrowserTab *tab = (BrowserTab *)gtk_notebook_get_nth_page(GTK_NOTEBOOK(window->notebook), currentPage);
+    webkit_web_view_try_close(browser_tab_get_web_view(tab));
+}
+
+static void browserWindowTryClose(BrowserWindow *window)
+{
+    GSList *webViews = NULL;
+    int n = gtk_notebook_get_n_pages(GTK_NOTEBOOK(window->notebook));
+    int i;
+
+    for (i = 0; i < n; ++i) {
+        BrowserTab *tab = (BrowserTab *)gtk_notebook_get_nth_page(GTK_NOTEBOOK(window->notebook), i);
+        webViews = g_slist_prepend(webViews, browser_tab_get_web_view(tab));
+    }
+
+    GSList *link;
+    for (link = webViews; link; link = link->next)
+        webkit_web_view_try_close(link->data);
+}
+
 static void backForwardlistChanged(WebKitBackForwardList *backForwardlist, WebKitBackForwardListItem *itemAdded, GList *itemsRemoved, BrowserWindow *window)
 {
@@ -934 +957 @@
     /* Quit */
     gtk_accel_group_connect(window->accelGroup, GDK_KEY_Q, GDK_CONTROL_MASK, GTK_ACCEL_VISIBLE,
-        g_cclosure_new_swap(G_CALLBACK(gtk_widget_destroy), window, NULL));
+        g_cclosure_new_swap(G_CALLBACK(browserWindowTryClose), window, NULL));
     gtk_accel_group_connect(window->accelGroup, GDK_KEY_W, GDK_CONTROL_MASK, GTK_ACCEL_VISIBLE,
-        g_cclosure_new_swap(G_CALLBACK(gtk_widget_destroy), window, NULL));
+        g_cclosure_new_swap(G_CALLBACK(browserWindowTryCloseCurrentWebView), window, NULL));
 
     /* Print */
@@ -1046 +1069 @@
 }
 
-static void browserWindowTryClose(BrowserWindow *window)
-{
-    GSList *webViews = NULL;
-    int n = gtk_notebook_get_n_pages(GTK_NOTEBOOK(window->notebook));
-    int i;
-
-    for (i = 0; i < n; ++i) {
-        BrowserTab *tab = (BrowserTab *)gtk_notebook_get_nth_page(GTK_NOTEBOOK(window->notebook), i);
-        webViews = g_slist_prepend(webViews, browser_tab_get_web_view(tab));
-    }
-
-    GSList *link;
-    for (link = webViews; link; link = link->next)
-        webkit_web_view_try_close(link->data);
-}
-
 static gboolean browserWindowDeleteEvent(GtkWidget *widget, GdkEventAny* event)
 {