Changeset 221879 in webkit


Ignore:
Timestamp:
Sep 11, 2017 2:52:27 PM (7 years ago)
Author:
jdiggs@igalia.com
Message:

AX: [ATK] aria-autocomplete not exposed on comboboxes
https://bugs.webkit.org/show_bug.cgi?id=176724

Reviewed by Chris Fleizach.

Source/WebCore:

Add a check to AccessibilityObject::supportsARIAAutoComplete() for
combobox because isARIATextControl() returns false for that role.

Add new combobox test cases to existing aria-autocomplete.html test.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIAAutoComplete const):

LayoutTests:

  • accessibility/gtk/aria-autocomplete-expected.txt: Updated for new test cases
  • accessibility/gtk/aria-autocomplete.html: New test cases for combobox added
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r221867 r221879  
     12017-09-11  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [ATK] aria-autocomplete not exposed on comboboxes
     4        https://bugs.webkit.org/show_bug.cgi?id=176724
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * accessibility/gtk/aria-autocomplete-expected.txt: Updated for new test cases
     9        * accessibility/gtk/aria-autocomplete.html: New test cases for combobox added
     10
    1112017-09-11  Zan Dobersek  <zdobersek@igalia.com>
    212
  • trunk/LayoutTests/accessibility/gtk/aria-autocomplete-expected.txt

    r215989 r221879  
    4646test14 supports autocompletion: false
    4747AXPlatformAttributes: computed-role:group, xml-roles:group, html-id:test14, tag:div, toolkit:WebKitGtk
     48
     49test15 supports autocompletion: false
     50AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, html-id:test15, tag:div, toolkit:WebKitGtk
     51
     52test16 supports autocompletion: false
     53AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:none, html-id:test16, tag:div, toolkit:WebKitGtk
     54
     55test17 supports autocompletion: false
     56AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:none, html-id:test17, tag:div, toolkit:WebKitGtk
     57
     58test18 supports autocompletion: false
     59AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:none, html-id:test18, tag:div, toolkit:WebKitGtk
     60
     61test19 supports autocompletion: true
     62AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:both, html-id:test19, tag:div, toolkit:WebKitGtk
     63
     64test20 supports autocompletion: true
     65AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:inline, html-id:test20, tag:div, toolkit:WebKitGtk
     66
     67test21 supports autocompletion: true
     68AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:list, html-id:test21, tag:div, toolkit:WebKitGtk
    4869PASS successfullyParsed is true
    4970
  • trunk/LayoutTests/accessibility/gtk/aria-autocomplete.html

    r215989 r221879  
    2020  <div id="test13" role="group" aria-autocomplete="inline">X</div>
    2121  <div id="test14" role="group" aria-autocomplete="list">X</div>
     22  <div id="test15" role="combobox">X</div>
     23  <div id="test16" role="combobox" aria-autocomplete="">X</div>
     24  <div id="test17" role="combobox" aria-autocomplete="foo">X</div>
     25  <div id="test18" role="combobox" aria-autocomplete="none">X</div>
     26  <div id="test19" role="combobox" aria-autocomplete="both">X</div>
     27  <div id="test20" role="combobox" aria-autocomplete="inline">X</div>
     28  <div id="test21" role="combobox" aria-autocomplete="list">X</div>
    2229</div>
    2330<p id="description"></p>
     
    3744    description("This tests the exposure of aria-current");
    3845    if (window.accessibilityController) {
    39         for (var i = 1; i <= 14; i++) {
     46        for (var i = 1; i <= 21; i++) {
    4047            var axElement = accessibilityController.accessibleElementById("test" + i);
    4148            debug("\ntest" + i + " supports autocompletion: " + axElement.boolAttributeValue("AXSupportsAutoCompletion"));
  • trunk/Source/WebCore/ChangeLog

    r221876 r221879  
     12017-09-11  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [ATK] aria-autocomplete not exposed on comboboxes
     4        https://bugs.webkit.org/show_bug.cgi?id=176724
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Add a check to AccessibilityObject::supportsARIAAutoComplete() for
     9        combobox because isARIATextControl() returns false for that role.
     10
     11        Add new combobox test cases to existing aria-autocomplete.html test.
     12
     13        * accessibility/AccessibilityObject.cpp:
     14        (WebCore::AccessibilityObject::supportsARIAAutoComplete const):
     15
    1162017-09-11  Ryan Haddad  <ryanhaddad@apple.com>
    217
  • trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

    r220042 r221879  
    16811681bool AccessibilityObject::supportsARIAAutoComplete() const
    16821682{
    1683     return isARIATextControl() && hasAttribute(aria_autocompleteAttr);
     1683    return (isComboBox() || isARIATextControl()) && hasAttribute(aria_autocompleteAttr);
    16841684}
    16851685
Note: See TracChangeset for help on using the changeset viewer.