Changeset 221879 in webkit
- Timestamp:
- Sep 11, 2017 2:52:27 PM (7 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r221867 r221879 1 2017-09-11 Joanmarie Diggs <jdiggs@igalia.com> 2 3 AX: [ATK] aria-autocomplete not exposed on comboboxes 4 https://bugs.webkit.org/show_bug.cgi?id=176724 5 6 Reviewed by Chris Fleizach. 7 8 * accessibility/gtk/aria-autocomplete-expected.txt: Updated for new test cases 9 * accessibility/gtk/aria-autocomplete.html: New test cases for combobox added 10 1 11 2017-09-11 Zan Dobersek <zdobersek@igalia.com> 2 12 -
trunk/LayoutTests/accessibility/gtk/aria-autocomplete-expected.txt
r215989 r221879 46 46 test14 supports autocompletion: false 47 47 AXPlatformAttributes: computed-role:group, xml-roles:group, html-id:test14, tag:div, toolkit:WebKitGtk 48 49 test15 supports autocompletion: false 50 AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, html-id:test15, tag:div, toolkit:WebKitGtk 51 52 test16 supports autocompletion: false 53 AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:none, html-id:test16, tag:div, toolkit:WebKitGtk 54 55 test17 supports autocompletion: false 56 AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:none, html-id:test17, tag:div, toolkit:WebKitGtk 57 58 test18 supports autocompletion: false 59 AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:none, html-id:test18, tag:div, toolkit:WebKitGtk 60 61 test19 supports autocompletion: true 62 AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:both, html-id:test19, tag:div, toolkit:WebKitGtk 63 64 test20 supports autocompletion: true 65 AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:inline, html-id:test20, tag:div, toolkit:WebKitGtk 66 67 test21 supports autocompletion: true 68 AXPlatformAttributes: computed-role:combobox, xml-roles:combobox, readonly:false, haspopup:listbox, autocomplete:list, html-id:test21, tag:div, toolkit:WebKitGtk 48 69 PASS successfullyParsed is true 49 70 -
trunk/LayoutTests/accessibility/gtk/aria-autocomplete.html
r215989 r221879 20 20 <div id="test13" role="group" aria-autocomplete="inline">X</div> 21 21 <div id="test14" role="group" aria-autocomplete="list">X</div> 22 <div id="test15" role="combobox">X</div> 23 <div id="test16" role="combobox" aria-autocomplete="">X</div> 24 <div id="test17" role="combobox" aria-autocomplete="foo">X</div> 25 <div id="test18" role="combobox" aria-autocomplete="none">X</div> 26 <div id="test19" role="combobox" aria-autocomplete="both">X</div> 27 <div id="test20" role="combobox" aria-autocomplete="inline">X</div> 28 <div id="test21" role="combobox" aria-autocomplete="list">X</div> 22 29 </div> 23 30 <p id="description"></p> … … 37 44 description("This tests the exposure of aria-current"); 38 45 if (window.accessibilityController) { 39 for (var i = 1; i <= 14; i++) {46 for (var i = 1; i <= 21; i++) { 40 47 var axElement = accessibilityController.accessibleElementById("test" + i); 41 48 debug("\ntest" + i + " supports autocompletion: " + axElement.boolAttributeValue("AXSupportsAutoCompletion")); -
trunk/Source/WebCore/ChangeLog
r221876 r221879 1 2017-09-11 Joanmarie Diggs <jdiggs@igalia.com> 2 3 AX: [ATK] aria-autocomplete not exposed on comboboxes 4 https://bugs.webkit.org/show_bug.cgi?id=176724 5 6 Reviewed by Chris Fleizach. 7 8 Add a check to AccessibilityObject::supportsARIAAutoComplete() for 9 combobox because isARIATextControl() returns false for that role. 10 11 Add new combobox test cases to existing aria-autocomplete.html test. 12 13 * accessibility/AccessibilityObject.cpp: 14 (WebCore::AccessibilityObject::supportsARIAAutoComplete const): 15 1 16 2017-09-11 Ryan Haddad <ryanhaddad@apple.com> 2 17 -
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
r220042 r221879 1681 1681 bool AccessibilityObject::supportsARIAAutoComplete() const 1682 1682 { 1683 return isARIATextControl() && hasAttribute(aria_autocompleteAttr);1683 return (isComboBox() || isARIATextControl()) && hasAttribute(aria_autocompleteAttr); 1684 1684 } 1685 1685
Note: See TracChangeset
for help on using the changeset viewer.