Changeset 221977 in webkit

Timestamp:

Sep 13, 2017 10:50:48 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Add a lambda-based map for Vectors
​https://bugs.webkit.org/show_bug.cgi?id=176487

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-13
Reviewed by Darin Adler.

Source/WebKit:

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::readCachesFromDisk):

Source/WTF:

This helper routine allows refactoring the reserveInitialCapacity/uncheckedAppend pattern, the mapper between source and destination item being a lambda.

• wtf/Vector.h:

(WTF::Mapper::transform):
(WTF::Mapper::map):
(WTF::map):

Tools:

• TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

Location:

trunk

Files:

• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/Vector.h (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WTF/Vector.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2017-09-13  Youenn Fablet  <youenn@apple.com>
+
+        Add a lambda-based map for Vectors
+        https://bugs.webkit.org/show_bug.cgi?id=176487
+
+        Reviewed by Darin Adler.
+
+        This helper routine allows refactoring the reserveInitialCapacity/uncheckedAppend pattern, the mapper between source and destination item being a lambda.
+
+        * wtf/Vector.h:
+        (WTF::Mapper::transform):
+        (WTF::Mapper::map):
+        (WTF::map):
+
 2017-09-12  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/WTF/wtf/Vector.h

@@ -1561 +1561 @@
 }
 
+template<typename Transformer, typename SourceType> struct Mapper {
+    using RealSourceType = typename std::remove_reference<SourceType>::type;
+    using SourceItemType = typename RealSourceType::ValueType;
+    using DestinationItemType = typename std::result_of<Transformer(SourceItemType&&)>::type;
+
+    static Vector<DestinationItemType> map(const RealSourceType& source, const Transformer& transformer)
+    {
+        Vector<DestinationItemType> result;
+        result.reserveInitialCapacity(source.size());
+        for (auto& item : source)
+            result.uncheckedAppend(transformer(item));
+        return result;
+    }
+
+    static Vector<DestinationItemType> map(RealSourceType&& source, const Transformer& transformer)
+    {
+        Vector<DestinationItemType> result;
+        result.reserveInitialCapacity(source.size());
+        for (auto& item : source)
+            result.uncheckedAppend(transformer(std::forward<SourceItemType>(item)));
+        return result;
+    }
+};
+
+template<typename Transformer, typename VectorType>
+Vector<typename Mapper<Transformer, VectorType>::DestinationItemType> map(VectorType&& source, const Transformer& transformer)
+{
+    return Mapper<Transformer, VectorType>::map(std::forward<VectorType>(source), transformer);
+}
+
 } // namespace WTF
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-09-13  Youenn Fablet  <youenn@apple.com>
+
+        Add a lambda-based map for Vectors
+        https://bugs.webkit.org/show_bug.cgi?id=176487
+
+        Reviewed by Darin Adler.
+
+        * NetworkProcess/cache/CacheStorageEngineCaches.cpp:
+        (WebKit::CacheStorage::Caches::readCachesFromDisk):
+
 2017-09-13  John Wilander  <wilander@apple.com>
 

trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp

@@ -241 +241 @@
             return;
         }
-        Vector<Cache> caches;
-        caches.reserveInitialCapacity(result.value().size());
-        for (auto& name : result.value())
-            caches.uncheckedAppend(Cache { *this, m_engine->nextCacheIdentifier(), Cache::State::Uninitialized, WTFMove(name) });
-
-        callback(WTFMove(caches));
+        callback(WTF::map(WTFMove(result.value()), [this] (String&& name) {
+            return Cache { *this, m_engine->nextCacheIdentifier(), Cache::State::Uninitialized, WTFMove(name) };
+        }));
     });
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2017-09-13  Youenn Fablet  <youenn@apple.com>
+
+        Add a lambda-based map for Vectors
+        https://bugs.webkit.org/show_bug.cgi?id=176487
+
+        Reviewed by Darin Adler.
+
+        * TestWebKitAPI/Tests/WTF/Vector.cpp:
+        (TestWebKitAPI::TEST):
+
 2017-09-13  John Wilander  <wilander@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WTF/Vector.cpp

@@ -652 +652 @@
 }
 
+TEST(WTF_Vector, MapLambda)
+{
+    Vector<int> vector { 2, 3, 4};
+
+    int counter = 0;
+    auto mapped = WTF::map(vector, [&] (int item) {
+        counter += 2;
+        return counter <= item;
+    });
+
+    EXPECT_EQ(3U, mapped.size());
+    EXPECT_TRUE(mapped[0]);
+    EXPECT_FALSE(mapped[1]);
+    EXPECT_FALSE(mapped[2]);
+}
+
+TEST(WTF_Vector, MapLambdaMove)
+{
+    Vector<MoveOnly> vector;
+
+    vector.reserveInitialCapacity(3);
+    for (unsigned i = 0; i < 3; ++i)
+        vector.uncheckedAppend(MoveOnly { i });
+
+
+    unsigned counter = 0;
+    auto mapped = WTF::map(WTFMove(vector), [&] (MoveOnly&& item) {
+        item = item.value() + ++counter;
+        return WTFMove(item);
+    });
+
+    EXPECT_EQ(3U, mapped.size());
+    EXPECT_EQ(1U, mapped[0].value());
+    EXPECT_EQ(3U, mapped[1].value());
+    EXPECT_EQ(5U, mapped[2].value());
+}
+
 } // namespace TestWebKitAPI