Changeset 222123 in webkit

Timestamp:

Sep 15, 2017 6:11:27 PM (7 years ago)

Author:

Dewei Zhu

Message:

Should not mark a platform as missing in summary page if all expecting metrics are exlucded.
​https://bugs.webkit.org/show_bug.cgi?id=176970

Reviewed by Ryosuke Niwa.

In summary page, if all metrics for a test are excluded in excludedConfigurations for a platform, this platform should not be marked as missing.

• public/v3/pages/summary-page.js:

(SummaryPageConfigurationGroup):

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/v3/pages/summary-page.js (modified) (2 diffs)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2017-09-15  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Should not mark a platform as missing in summary page if all expecting metrics are exlucded.
+        https://bugs.webkit.org/show_bug.cgi?id=176970
+
+        Reviewed by Ryosuke Niwa.
+
+        In summary page, if all metrics for a test are excluded in excludedConfigurations for a platform, this platform should not be marked as missing.
+
+        * public/v3/pages/summary-page.js:
+        (SummaryPageConfigurationGroup):
+
 2017-09-11  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js

@@ -260 +260 @@
         this._smallerIsBetter = metrics.length ? metrics[0].isSmallerBetter() : null;
 
-        for (var platform of platforms) {
+        for (const platform of platforms) {
             console.assert(platform instanceof Platform);
-            var foundInSomeMetric = false;
-            for (var metric of metrics) {
+            let foundInSomeMetric = false;
+            let excludedMerticCount = 0;
+            for (const metric of metrics) {
                 console.assert(metric instanceof Metric);
                 console.assert(this._smallerIsBetter == metric.isSmallerBetter());
                 metric.isSmallerBetter();
 
-                if (excludedConfigurations && platform.id() in excludedConfigurations && excludedConfigurations[platform.id()].includes(+metric.id()))
+                if (excludedConfigurations && platform.id() in excludedConfigurations && excludedConfigurations[platform.id()].includes(+metric.id())) {
+                    excludedMerticCount += 1;
                     continue;
+                }
                 if (!platform.hasMetric(metric))
                     continue;
@@ -276 +279 @@
                 this._configurationList.push([platform.id(), metric.id()]);
             }
-            if (!foundInSomeMetric)
+            if (!foundInSomeMetric && excludedMerticCount < metrics.length)
                 this._missingPlatforms.add(platform);
         }