Changeset 222171 in webkit

Timestamp:

Sep 18, 2017 11:56:39 AM (7 years ago)

Author:

webkit@devinrousso.com

Message:

Web Inspector: REGRESSION(r221901): Single frame recordings don't reset the recording navigation item
​https://bugs.webkit.org/show_bug.cgi?id=176893

Reviewed by Matt Baker.

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.recordingFinished):
Set the _recordingCanvas to null whenever a recording has finished and been sent to the
frontend. It is also necessary to do this inside stopRecording, as it is possible for the
user to start and stop a recording before any actions are recorded, meaning that no
recording would be sent to the frontend and this function will never get called.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/CanvasManager.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-09-18  Devin Rousso  <webkit@devinrousso.com>
+
+        Web Inspector: REGRESSION(r221901): Single frame recordings don't reset the recording navigation item
+        https://bugs.webkit.org/show_bug.cgi?id=176893
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Controllers/CanvasManager.js:
+        (WI.CanvasManager.prototype.recordingFinished):
+        Set the `_recordingCanvas` to null whenever a recording has finished and been sent to the
+        frontend. It is also necessary to do this inside `stopRecording`, as it is possible for the
+        user to start and stop a recording before any actions are recorded, meaning that no
+        recording would be sent to the frontend and this function will never get called.
+
 2017-09-17  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js

@@ -149 +149 @@
         // Called from WI.CanvasObserver.
 
+        this._recordingCanvas = null;
+
         let canvas = this._canvasIdentifierMap.get(canvasIdentifier);
         console.assert(canvas);