Changeset 222204 in webkit

Timestamp:

Sep 18, 2017 11:41:42 PM (7 years ago)

Author:

Carlos Garcia Campos

Message:

WebDriver: wrong key name for capabilities in new session response
​https://bugs.webkit.org/show_bug.cgi?id=177074

Reviewed by Brian Burg.

We are using "value", it should be "capabilities".
​https://w3c.github.io/webdriver/webdriver-spec.html#new-session

• WebDriverService.cpp:

(WebDriver::WebDriverService::newSession):

Location:

trunk/Source/WebDriver

Files:

• ChangeLog (modified) (1 diff)
• WebDriverService.cpp (modified) (1 diff)

trunk/Source/WebDriver/ChangeLog

@@ +1 @@
+2017-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: wrong key name for capabilities in new session response
+        https://bugs.webkit.org/show_bug.cgi?id=177074
+
+        Reviewed by Brian Burg.
+
+        We are using "value", it should be "capabilities".
+        https://w3c.github.io/webdriver/webdriver-spec.html#new-session
+
+        * WebDriverService.cpp:
+        (WebDriver::WebDriverService::newSession):
+
 2017-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebDriver/WebDriverService.cpp

@@ -626 +626 @@
                 }
             }
-            resultObject->setObject(ASCIILiteral("value"), WTFMove(capabilitiesObject));
+            resultObject->setObject(ASCIILiteral("capabilities"), WTFMove(capabilitiesObject));
             completionHandler(CommandResult::success(WTFMove(resultObject)));
         });