Changeset 222441 in webkit

Timestamp:

Sep 25, 2017 1:39:48 AM (7 years ago)

Author:

Manuel Rego Casasnovas

Message:

[css-grid] Small refactoring adding RenderGrid::contentAlignment()
​https://bugs.webkit.org/show_bug.cgi?id=177130

Reviewed by Sergio Villar Senin.

As a follow-up of r221931, this patch does a small refactoring
adding a new method RenderGrid::contentAlignment()
that is used from RenderGrid and GridTrackSizingAlgorithm.

No new tests, no change of behavior.

• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::stretchAutoTracks):

• rendering/RenderGrid.cpp:

(WebCore::contentAlignmentNormalBehaviorGrid):
(WebCore::RenderGrid::contentAlignment const):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset const):
(WebCore::RenderGrid::contentAlignmentNormalBehaviorGrid): Deleted.

• rendering/RenderGrid.h:
• rendering/style/RenderStyle.cpp:

(WebCore::resolvedContentAlignment):
(WebCore::RenderStyle::resolvedAlignContent const):
(WebCore::RenderStyle::resolvedJustifyContent const):

• rendering/style/RenderStyle.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/GridTrackSizingAlgorithm.cpp (modified) (1 diff)
• rendering/RenderGrid.cpp (modified) (2 diffs)
• rendering/RenderGrid.h (modified) (1 diff)
• rendering/style/RenderStyle.cpp (modified) (1 diff)
• rendering/style/RenderStyle.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-09-25  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [css-grid] Small refactoring adding RenderGrid::contentAlignment()
+        https://bugs.webkit.org/show_bug.cgi?id=177130
+
+        Reviewed by Sergio Villar Senin.
+
+        As a follow-up of r221931, this patch does a small refactoring
+        adding a new method RenderGrid::contentAlignment()
+        that is used from RenderGrid and GridTrackSizingAlgorithm.
+
+        No new tests, no change of behavior.
+
+        * rendering/GridTrackSizingAlgorithm.cpp:
+        (WebCore::GridTrackSizingAlgorithm::stretchAutoTracks):
+        * rendering/RenderGrid.cpp:
+        (WebCore::contentAlignmentNormalBehaviorGrid):
+        (WebCore::RenderGrid::contentAlignment const):
+        (WebCore::RenderGrid::computeContentPositionAndDistributionOffset const):
+        (WebCore::RenderGrid::contentAlignmentNormalBehaviorGrid): Deleted.
+        * rendering/RenderGrid.h:
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::resolvedContentAlignment):
+        (WebCore::RenderStyle::resolvedAlignContent const):
+        (WebCore::RenderStyle::resolvedJustifyContent const):
+        * rendering/style/RenderStyle.h:
+
 2017-09-25  Manuel Rego Casasnovas  <rego@igalia.com>
 

trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

@@ -1072 +1072 @@
 void GridTrackSizingAlgorithm::stretchAutoTracks()
 {
-    if (m_autoSizedTracksForStretchIndex.isEmpty())
-        return;
-
     auto currentFreeSpace = freeSpace(m_direction);
-    if (!currentFreeSpace
+    if (m_autoSizedTracksForStretchIndex.isEmpty()
+        || !currentFreeSpace
         || currentFreeSpace.value() <= 0
-        || (m_direction == ForColumns && m_renderGrid->style().resolvedJustifyContentDistribution(m_renderGrid->contentAlignmentNormalBehaviorGrid()) != ContentDistributionStretch)
-        || (m_direction == ForRows && m_renderGrid->style().resolvedAlignContentDistribution(m_renderGrid->contentAlignmentNormalBehaviorGrid()) != ContentDistributionStretch))
+        || (m_renderGrid->contentAlignment(m_direction).distribution() != ContentDistributionStretch))
         return;
 

trunk/Source/WebCore/rendering/RenderGrid.cpp

@@ -878 +878 @@
 }
 
-const StyleContentAlignmentData& RenderGrid::contentAlignmentNormalBehaviorGrid()
+static const StyleContentAlignmentData& contentAlignmentNormalBehaviorGrid()
 {
     static const StyleContentAlignmentData normalBehavior = {ContentPositionNormal, ContentDistributionStretch};
@@ -1582 +1582 @@
 }
 
+StyleContentAlignmentData RenderGrid::contentAlignment(GridTrackSizingDirection direction) const
+{
+    return direction == ForColumns ? style().resolvedJustifyContent(contentAlignmentNormalBehaviorGrid()) : style().resolvedAlignContent(contentAlignmentNormalBehaviorGrid());
+}
+
 ContentAlignmentData RenderGrid::computeContentPositionAndDistributionOffset(GridTrackSizingDirection direction, const LayoutUnit& availableFreeSpace, unsigned numberOfGridTracks) const
 {
     bool isRowAxis = direction == ForColumns;
-    auto position = isRowAxis ? style().resolvedJustifyContentPosition(contentAlignmentNormalBehaviorGrid()) : style().resolvedAlignContentPosition(contentAlignmentNormalBehaviorGrid());
-    auto distribution = isRowAxis ? style().resolvedJustifyContentDistribution(contentAlignmentNormalBehaviorGrid()) : style().resolvedAlignContentDistribution(contentAlignmentNormalBehaviorGrid());
+    auto contentAlignmentData = contentAlignment(direction);
+    auto position = contentAlignmentData.position();
     // If <content-distribution> value can't be applied, 'position' will become the associated
     // <content-position> fallback value.
-    auto contentAlignment = contentDistributionOffset(availableFreeSpace, position, distribution, numberOfGridTracks);
+    auto contentAlignment = contentDistributionOffset(availableFreeSpace, position, contentAlignmentData.distribution(), numberOfGridTracks);
     if (contentAlignment.isValid())
         return contentAlignment;
 
-    auto overflow = (isRowAxis ? style().justifyContent() : style().alignContent()).overflow();
-    if (availableFreeSpace <= 0 && overflow == OverflowAlignmentSafe)
+    if (availableFreeSpace <= 0 && contentAlignmentData.overflow() == OverflowAlignmentSafe)
         return {0, 0};
 

trunk/Source/WebCore/rendering/RenderGrid.h

@@ -66 +66 @@
     LayoutUnit guttersSize(const Grid&, GridTrackSizingDirection, unsigned startLine, unsigned span, std::optional<LayoutUnit> availableSize) const;
 
-    static const StyleContentAlignmentData& contentAlignmentNormalBehaviorGrid();
+    StyleContentAlignmentData contentAlignment(GridTrackSizingDirection) const;
 
 protected:

trunk/Source/WebCore/rendering/style/RenderStyle.cpp

@@ -279 +279 @@
         return resolvedSelfAlignment(justifySelf(), normalValueBehaviour);
     return parentStyle->resolvedJustifyItems(normalValueBehaviour);
+}
+
+static inline StyleContentAlignmentData resolvedContentAlignment(const StyleContentAlignmentData& value, const StyleContentAlignmentData& normalValueBehavior)
+{
+    return (value.position() == ContentPositionNormal && value.distribution() == ContentDistributionDefault) ? normalValueBehavior : value;
+}
+
+StyleContentAlignmentData RenderStyle::resolvedAlignContent(const StyleContentAlignmentData& normalValueBehavior) const
+{
+    // We will return the behaviour of 'normal' value if needed, which is specific of each layout model.
+    return resolvedContentAlignment(alignContent(), normalValueBehavior);
+}
+
+StyleContentAlignmentData RenderStyle::resolvedJustifyContent(const StyleContentAlignmentData& normalValueBehavior) const
+{
+    // We will return the behaviour of 'normal' value if needed, which is specific of each layout model.
+    return resolvedContentAlignment(justifyContent(), normalValueBehavior);
 }
 

trunk/Source/WebCore/rendering/style/RenderStyle.h

@@ -167 +167 @@
     StyleSelfAlignmentData resolvedAlignItems(ItemPosition normalValueBehaviour) const;
     StyleSelfAlignmentData resolvedAlignSelf(const RenderStyle* parentStyle, ItemPosition normalValueBehaviour) const;
+    StyleContentAlignmentData resolvedAlignContent(const StyleContentAlignmentData& normalValueBehaviour) const;
     StyleSelfAlignmentData resolvedJustifyItems(ItemPosition normalValueBehaviour) const;
     StyleSelfAlignmentData resolvedJustifySelf(const RenderStyle* parentStyle, ItemPosition normalValueBehaviour) const;
+    StyleContentAlignmentData resolvedJustifyContent(const StyleContentAlignmentData& normalValueBehaviour) const;
 
     PseudoId styleType() const { return static_cast<PseudoId>(m_nonInheritedFlags.styleType); }