Changeset 222444 in webkit


Ignore:
Timestamp:
Sep 25, 2017 6:38:57 AM (7 years ago)
Author:
Ms2ger@igalia.com
Message:

Update waitSync and the TIMEOUT_IGNORED constant to use signed integers.
https://bugs.webkit.org/show_bug.cgi?id=177239

Reviewed by Žan Doberšek.

This matches the specification.

Source/WebCore:

Test: fast/canvas/webgl/webgl2/constants.html

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::waitSync):

  • html/canvas/WebGL2RenderingContext.h:
  • html/canvas/WebGL2RenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/webgl2/constants-expected.txt: Added.
  • fast/canvas/webgl/webgl2/constants.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r222440 r222444  
     12017-09-25  Ms2ger  <Ms2ger@igalia.com>
     2
     3        Update waitSync and the TIMEOUT_IGNORED constant to use signed integers.
     4        https://bugs.webkit.org/show_bug.cgi?id=177239
     5
     6        Reviewed by Žan Doberšek.
     7
     8        This matches the specification.
     9
     10        * fast/canvas/webgl/webgl2/constants-expected.txt: Added.
     11        * fast/canvas/webgl/webgl2/constants.html: Added.
     12
    1132017-09-25  Manuel Rego Casasnovas  <rego@igalia.com>
    214
  • trunk/Source/WebCore/ChangeLog

    r222443 r222444  
     12017-09-25  Ms2ger  <Ms2ger@igalia.com>
     2
     3        Update waitSync and the TIMEOUT_IGNORED constant to use signed integers.
     4        https://bugs.webkit.org/show_bug.cgi?id=177239
     5
     6        Reviewed by Žan Doberšek.
     7
     8        This matches the specification.
     9
     10        Test: fast/canvas/webgl/webgl2/constants.html
     11
     12        * html/canvas/WebGL2RenderingContext.cpp:
     13        (WebCore::WebGL2RenderingContext::waitSync):
     14        * html/canvas/WebGL2RenderingContext.h:
     15        * html/canvas/WebGL2RenderingContext.idl:
     16
    1172017-09-25  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
    218
  • trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp

    r222258 r222444  
    839839}
    840840
    841 void WebGL2RenderingContext::waitSync(WebGLSync&, GC3Dbitfield, GC3Duint64)
     841void WebGL2RenderingContext::waitSync(WebGLSync&, GC3Dbitfield, GC3Dint64)
    842842{
    843843}
  • trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h

    r222258 r222444  
    139139    void deleteSync(WebGLSync*);
    140140    GC3Denum clientWaitSync(WebGLSync&, GC3Dbitfield flags, GC3Duint64 timeout);
    141     void waitSync(WebGLSync&, GC3Dbitfield flags, GC3Duint64 timeout);
     141    void waitSync(WebGLSync&, GC3Dbitfield flags, GC3Dint64 timeout);
    142142    WebGLAny getSyncParameter(WebGLSync&, GC3Denum pname);
    143143   
  • trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.idl

    r222258 r222444  
    338338    const GLenum VERTEX_ATTRIB_ARRAY_DIVISOR_ANGLE             = 0x88FE;
    339339
    340     const GLuint64 TIMEOUT_IGNORED                             = 0xFFFFFFFFFFFFFFFF;
     340    const GLint64 TIMEOUT_IGNORED                              = -1;
    341341
    342342    /* Buffer objects */
     
    433433    void deleteSync(WebGLSync? sync);
    434434    GLenum clientWaitSync(WebGLSync sync, GLbitfield flags, GLuint64 timeout);
    435     void waitSync(WebGLSync sync, GLbitfield flags, GLuint64 timeout);
     435    void waitSync(WebGLSync sync, GLbitfield flags, GLint64 timeout);
    436436    [OverrideIDLType=IDLWebGLAny] any getSyncParameter(WebGLSync sync, GLenum pname);
    437437
Note: See TracChangeset for help on using the changeset viewer.