Changeset 222520 in webkit


Ignore:
Timestamp:
Sep 26, 2017 1:42:14 PM (7 years ago)
Author:
Brent Fulgham
Message:

Harden our access to the vector of URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=177470
<rdar://problem/33881522>

Reviewed by Chris Dumez.

Instead of asserting, use MESSAGE_CHECK so that we actually refuse to access an invalid iterator.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startURLSchemeTask):
(WebKit::WebPageProxy::stopURLSchemeTask):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r222505 r222520  
     12017-09-26  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Harden our access to the vector of URL schemes.
     4        https://bugs.webkit.org/show_bug.cgi?id=177470
     5        <rdar://problem/33881522>
     6
     7        Reviewed by Chris Dumez.
     8
     9        Instead of asserting, use MESSAGE_CHECK so that we actually refuse to access an invalid iterator.
     10
     11        * UIProcess/WebPageProxy.cpp:
     12        (WebKit::WebPageProxy::startURLSchemeTask):
     13        (WebKit::WebPageProxy::stopURLSchemeTask):
     14
    1152017-09-26  Jer Noble  <jer.noble@apple.com>
    216
  • trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

    r222492 r222520  
    70227022{
    70237023    auto iterator = m_urlSchemeHandlersByIdentifier.find(handlerIdentifier);
    7024     ASSERT(iterator != m_urlSchemeHandlersByIdentifier.end());
     7024    MESSAGE_CHECK(iterator != m_urlSchemeHandlersByIdentifier.end());
    70257025
    70267026    iterator->value->startTask(*this, taskIdentifier, request);
     
    70307030{
    70317031    auto iterator = m_urlSchemeHandlersByIdentifier.find(handlerIdentifier);
    7032     ASSERT(iterator != m_urlSchemeHandlersByIdentifier.end());
     7032    MESSAGE_CHECK(iterator != m_urlSchemeHandlersByIdentifier.end());
    70337033
    70347034    iterator->value->stopTask(*this, taskIdentifier);
Note: See TracChangeset for help on using the changeset viewer.