Changeset 222527 in webkit


Ignore:
Timestamp:
Sep 26, 2017 3:19:12 PM (7 years ago)
Author:
jdiggs@igalia.com
Message:

AX: ARIA grids claim to be multiselectable even with aria-multiselectable is set to false
​https://bugs.webkit.org/show_bug.cgi?id=177498

Reviewed by Chris Fleizach.

Source/WebCore:

AccessibilityARIAGrid::isMultiSelectable() was unconditionally returning
true. Modify it to return false if aria-multiselectable has been set to
false by the author.

Test: accessibility/aria-multiselectable-grid.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::isMultiSelectable const):

  • accessibility/AccessibilityARIAGrid.h:

LayoutTests:

  • accessibility/aria-multiselectable-grid-expected.txt: Added.
  • accessibility/aria-multiselectable-grid.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r222525 r222527  
     12017-09-26  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: ARIA grids claim to be multiselectable even with aria-multiselectable is set to false
     4        https://bugs.webkit.org/show_bug.cgi?id=177498
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * accessibility/aria-multiselectable-grid-expected.txt: Added.
     9        * accessibility/aria-multiselectable-grid.html: Added.
     10
    1112017-09-26  Joanmarie Diggs  <jdiggs@igalia.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r222525 r222527  
     12017-09-26  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: ARIA grids claim to be multiselectable even with aria-multiselectable is set to false
     4        https://bugs.webkit.org/show_bug.cgi?id=177498
     5
     6        Reviewed by Chris Fleizach.
     7
     8        AccessibilityARIAGrid::isMultiSelectable() was unconditionally returning
     9        true. Modify it to return false if aria-multiselectable has been set to
     10        false by the author.
     11
     12        Test: accessibility/aria-multiselectable-grid.html
     13
     14        * accessibility/AccessibilityARIAGrid.cpp:
     15        (WebCore::AccessibilityARIAGrid::isMultiSelectable const):
     16        * accessibility/AccessibilityARIAGrid.h:
     17
    1182017-09-26  Joanmarie Diggs  <jdiggs@igalia.com>
    219

  • trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp

    r188203 r222527  
    8383}
    8484
     85bool AccessibilityARIAGrid::isMultiSelectable() const
     86{
     87    const AtomicString& ariaMultiSelectable = getAttribute(HTMLNames::aria_multiselectableAttr);
     88    return !equalLettersIgnoringASCIICase(ariaMultiSelectable, "false");
     89}
     90
    8591void AccessibilityARIAGrid::addRowDescendant(AccessibilityObject* rowChild, HashSet<AccessibilityObject*>& appendedRows, unsigned& columnCount)
    8692{

  • trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.h

    r208179 r222527  
    4949    // ARIA treegrids and grids support selected rows.
    5050    bool supportsSelectedRows() override { return true; }
    51     bool isMultiSelectable() const override { return true; }
     51    bool isMultiSelectable() const override;
    5252    bool computeIsTableExposableThroughAccessibility() const override { return true; }
    5353    bool isAriaTable() const override { return true; }
Note: See TracChangeset for help on using the changeset viewer.