Changeset 222557 in webkit

Timestamp:

Sep 27, 2017 10:08:58 AM (7 years ago)

Author:

Antti Koivisto

Message:

Ref element keys in CSSAnimationControllerPrivate
​https://bugs.webkit.org/show_bug.cgi?id=177543

Reviewed by Zalan Bujtas.

For safety.

• page/animation/CSSAnimationControllerPrivate.h:

This won't create ref cycle as elements are removed from the m_compositeAnimations maps when they
are removed from the tree. We have assertions that verify the map is always cleared.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/animation/CSSAnimationControllerPrivate.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-09-27  Antti Koivisto  <antti@apple.com>
+
+        Ref element keys in CSSAnimationControllerPrivate
+        https://bugs.webkit.org/show_bug.cgi?id=177543
+
+        Reviewed by Zalan Bujtas.
+
+        For safety.
+
+        * page/animation/CSSAnimationControllerPrivate.h:
+
+        This won't create ref cycle as elements are removed from the m_compositeAnimations maps when they
+        are removed from the tree. We have assertions that verify the map is always cleared.
+
 2017-09-27  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/page/animation/CSSAnimationControllerPrivate.h

@@ -125 +125 @@
     void startTimeResponse(double t);
 
-    HashMap<Element*, RefPtr<CompositeAnimation>> m_compositeAnimations;
+    HashMap<RefPtr<Element>, RefPtr<CompositeAnimation>> m_compositeAnimations;
     Timer m_animationTimer;
     Timer m_updateStyleIfNeededDispatcher;