Changeset 222616 in webkit


Ignore:
Timestamp:
Sep 28, 2017 10:56:16 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

[mac-wk1] Layout test webrtc/datachannel/bufferedAmountLowThreshold tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=177462

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-28
Reviewed by Alex Christensen.

  • webrtc/datachannel/bufferedAmountLowThreshold-default.html: Filling buffer until bufferedAmount is bug enough to trigger bufferedAmountLow event.
  • webrtc/datachannel/bufferedAmountLowThreshold-expected.txt:
  • webrtc/datachannel/bufferedAmountLowThreshold.html: Removing test that is inherently flaky on bots that are not fast enough

to continue filling the webrtc data channel buffer.

Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r222613 r222616  
     12017-09-28  Youenn Fablet  <youenn@apple.com>
     2
     3        [mac-wk1] Layout test webrtc/datachannel/bufferedAmountLowThreshold tests are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=177462
     5
     6        Reviewed by Alex Christensen.
     7
     8        * webrtc/datachannel/bufferedAmountLowThreshold-default.html: Filling buffer until bufferedAmount is bug enough to trigger bufferedAmountLow event.
     9        * webrtc/datachannel/bufferedAmountLowThreshold-expected.txt:
     10        * webrtc/datachannel/bufferedAmountLowThreshold.html: Removing test that is inherently flaky on bots that are not fast enough
     11        to continue filling the webrtc data channel buffer.
     12
    1132017-09-28  Chris Dumez  <cdumez@apple.com>
    214

  • trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-default.html

    r218795 r222616  
    2929function sendMessages(channel)
    3030{
    31     channel.send(longString);
    32     channel.send(longString);
    33     channel.send(longString);
     31    while(channel.bufferedAmount < 1000)
     32        channel.send(longString);
    3433}
    3534

  • trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold-expected.txt

    r218795 r222616  
    11
    22PASS Large buffer threshold reached
    3 PASS Medium buffer threshold not reached
    43

  • trunk/LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html

    r218795 r222616  
    6767    });
    6868}, "Large buffer threshold reached");
    69 
    70 promise_test((test) => {
    71     counter = 0;
    72     var gotEvent = false;
    73     return new Promise((resolve, reject) => {
    74         createConnections((localConnection) => {
    75             localChannel = localConnection.createDataChannel('sendDataChannel');
    76             localChannel.onopen = () => {
    77                 sendContinuouslyMessages(localChannel);
    78                 localChannel.onbufferedamountlow = () => {
    79                     reject();
    80                 }
    81             };
    82             localChannel.bufferedAmountLowThreshold = 10;
    83         }, (remoteConnection) => {
    84             remoteConnection.ondatachannel = (event) => {
    85                 remoteChannel = event.channel;
    86                 remoteChannel.onmessage = receiveMessages;
    87             };
    88         });
    89         setTimeout(resolve, 50);
    90     });
    91 }, "Medium buffer threshold not reached");
    9269    </script>
    9370  </body>
Note: See TracChangeset for help on using the changeset viewer.