Changeset 222619 in webkit
- Timestamp:
- Sep 28, 2017 11:37:22 AM (7 years ago)
- Location:
- trunk/Source
- Files:
-
- 18 edited
- 1 moved
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r222613 r222619 1 2017-09-28 Ross Kirsling <ross.kirsling@sony.com> 2 3 [PAL] Move HysteresisActivity into PAL 4 https://bugs.webkit.org/show_bug.cgi?id=177516 5 6 Reviewed by Alex Christensen. 7 8 * WebCore.xcodeproj/project.pbxproj: 9 * platform/UserActivity.cpp: 10 (WebCore::UserActivity::UserActivity): 11 (WebCore::UserActivity::hysteresisUpdated): 12 * platform/UserActivity.h: 13 * platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp: 14 (WebCore::BackingStoreBackendCairoImpl::BackingStoreBackendCairoImpl): 15 * platform/graphics/cairo/BackingStoreBackendCairoImpl.h: 16 * platform/ios/WebSQLiteDatabaseTrackerClient.h: 17 * platform/ios/WebSQLiteDatabaseTrackerClient.mm: 18 (WebCore::WebSQLiteDatabaseTrackerClient::WebSQLiteDatabaseTrackerClient): 19 (WebCore::WebSQLiteDatabaseTrackerClient::hysteresisUpdated): 20 1 21 2017-09-28 Chris Dumez <cdumez@apple.com> 2 22 -
trunk/Source/WebCore/PAL/ChangeLog
r222613 r222619 1 2017-09-28 Ross Kirsling <ross.kirsling@sony.com> 2 3 [PAL] Move HysteresisActivity into PAL 4 https://bugs.webkit.org/show_bug.cgi?id=177516 5 6 Reviewed by Alex Christensen. 7 8 * PAL.xcodeproj/project.pbxproj: 9 * pal/HysteresisActivity.h: Renamed from Source/WebCore/platform/HysteresisActivity.h. 10 1 11 2017-09-28 Chris Dumez <cdumez@apple.com> 2 12 -
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
r222515 r222619 128 128 A3788E9C1F05B78200679425 /* Sound.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A3788E9B1F05B78200679425 /* Sound.cpp */; }; 129 129 A3788E9E1F05B78E00679425 /* SoundMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = A3788E9D1F05B78E00679425 /* SoundMac.mm */; }; 130 A39DE74E1F7C443D007BCB00 /* HysteresisActivity.h in Headers */ = {isa = PBXBuildFile; fileRef = A39DE74D1F7C443C007BCB00 /* HysteresisActivity.h */; }; 130 131 A3AB6E521F3D1DC5009C14B1 /* SleepDisabler.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A3AB6E511F3D1DC5009C14B1 /* SleepDisabler.cpp */; }; 131 132 A3AB6E561F3D1DDB009C14B1 /* SleepDisabler.h in Headers */ = {isa = PBXBuildFile; fileRef = A3AB6E531F3D1DDB009C14B1 /* SleepDisabler.h */; }; … … 263 264 A3788E9B1F05B78200679425 /* Sound.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Sound.cpp; sourceTree = "<group>"; }; 264 265 A3788E9D1F05B78E00679425 /* SoundMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SoundMac.mm; sourceTree = "<group>"; }; 266 A39DE74D1F7C443C007BCB00 /* HysteresisActivity.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HysteresisActivity.h; sourceTree = "<group>"; }; 265 267 A3AB6E511F3D1DC5009C14B1 /* SleepDisabler.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SleepDisabler.cpp; sourceTree = "<group>"; }; 266 268 A3AB6E531F3D1DDB009C14B1 /* SleepDisabler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SleepDisabler.h; sourceTree = "<group>"; }; … … 430 432 0CF99CA71F738437007EE793 /* CoreMediaSoftLink.h */, 431 433 ); 432 name = cf; 433 path = "New Group"; 434 path = cf; 434 435 sourceTree = "<group>"; 435 436 }; … … 462 463 A30D411D1F0DD0AC00B71954 /* text */, 463 464 0C2D9E721EEF5AF600DBC317 /* ExportMacros.h */, 465 A39DE74D1F7C443C007BCB00 /* HysteresisActivity.h */, 464 466 0708AC321F4C874A001F788F /* Logger.h */, 465 467 07377ADB1F5777D70027F16D /* LoggerHelper.h */, … … 594 596 A102658E1F567E9D00B4C844 /* HIServicesSPI.h in Headers */, 595 597 A10265891F56747A00B4C844 /* HIToolboxSPI.h in Headers */, 598 A39DE74E1F7C443D007BCB00 /* HysteresisActivity.h in Headers */, 596 599 0C2DA11F1F3BE9E000DBC317 /* ImageIOSPI.h in Headers */, 597 600 0C2DA1421F3BEB4900DBC317 /* IOPMLibSPI.h in Headers */, -
trunk/Source/WebCore/PAL/pal/HysteresisActivity.h
r222618 r222619 24 24 */ 25 25 26 #ifndef HysteresisActivity_h 27 #define HysteresisActivity_h 26 #pragma once 28 27 29 28 #include <wtf/RunLoop.h> 30 29 #include <wtf/Seconds.h> 31 30 32 namespace WebCore{31 namespace PAL { 33 32 34 33 static const Seconds defaultHysteresisDuration { 5_s }; … … 96 95 }; 97 96 98 } // namespace WebCore 99 100 #endif // HysteresisActivity_h 97 } // namespace PAL -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r222595 r222619 3730 3730 861C2EA413FB4FDD00062ABB /* LoadTiming.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 861C2EA313FB4FDD00062ABB /* LoadTiming.cpp */; }; 3731 3731 862F129E18C1576F005C54AF /* CountedUserActivity.h in Headers */ = {isa = PBXBuildFile; fileRef = 862F129D18C1572C005C54AF /* CountedUserActivity.h */; settings = {ATTRIBUTES = (Private, ); }; }; 3732 862F12A018C1DD02005C54AF /* HysteresisActivity.h in Headers */ = {isa = PBXBuildFile; fileRef = 862F129F18C1DCE4005C54AF /* HysteresisActivity.h */; settings = {ATTRIBUTES = (Private, ); }; };3733 3732 86512EDE154A2AEF00A90426 /* PerformanceResourceTiming.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 86512EDB154A2AEE00A90426 /* PerformanceResourceTiming.cpp */; }; 3734 3733 86512EDF154A2AEF00A90426 /* PerformanceResourceTiming.h in Headers */ = {isa = PBXBuildFile; fileRef = 86512EDC154A2AEF00A90426 /* PerformanceResourceTiming.h */; }; … … 12067 12066 861C2EA313FB4FDD00062ABB /* LoadTiming.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LoadTiming.cpp; sourceTree = "<group>"; }; 12068 12067 862F129D18C1572C005C54AF /* CountedUserActivity.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CountedUserActivity.h; sourceTree = "<group>"; }; 12069 862F129F18C1DCE4005C54AF /* HysteresisActivity.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HysteresisActivity.h; sourceTree = "<group>"; };12070 12068 86512EDB154A2AEE00A90426 /* PerformanceResourceTiming.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PerformanceResourceTiming.cpp; sourceTree = "<group>"; }; 12071 12069 86512EDC154A2AEF00A90426 /* PerformanceResourceTiming.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PerformanceResourceTiming.h; sourceTree = "<group>"; }; … … 24611 24609 A8748BDF12CBF2DC001FBA41 /* HashTools.h */, 24612 24610 BC3BC29B0E91AB0F00835588 /* HostWindow.h */, 24613 862F129F18C1DCE4005C54AF /* HysteresisActivity.h */,24614 24611 1AE00D57182DAC8D00087DD7 /* KeyedCoding.h */, 24615 24612 E15FF7D418C9553800FE4C87 /* KeypressCommand.h */, … … 28139 28136 514C76730CE923A1007EF3CD /* HTTPParsers.h in Headers */, 28140 28137 375CD232119D43C800A2A859 /* Hyphenation.h in Headers */, 28141 862F12A018C1DD02005C54AF /* HysteresisActivity.h in Headers */,28142 28138 5EBB89331C77782900C65D41 /* IceCandidate.h in Headers */, 28143 28139 B275356E0B053814002CE64F /* Icon.h in Headers */, -
trunk/Source/WebCore/platform/UserActivity.cpp
r177295 r222619 46 46 47 47 UserActivity::UserActivity(const char* description) 48 : HysteresisActivity([this](HysteresisState state) { hysteresisUpdated(state); })48 : PAL::HysteresisActivity([this](PAL::HysteresisState state) { hysteresisUpdated(state); }) 49 49 , m_impl(description) 50 50 { 51 51 } 52 52 53 void UserActivity::hysteresisUpdated( HysteresisState state)53 void UserActivity::hysteresisUpdated(PAL::HysteresisState state) 54 54 { 55 if (state == HysteresisState::Started)55 if (state == PAL::HysteresisState::Started) 56 56 m_impl.beginActivity(); 57 57 else -
trunk/Source/WebCore/platform/UserActivity.h
r183746 r222619 27 27 #define UserActivity_h 28 28 29 #include "HysteresisActivity.h"29 #include <pal/HysteresisActivity.h> 30 30 31 31 #if HAVE(NS_ACTIVITY) … … 41 41 // a user initiated or visible action is taking place, and as such that 42 42 // resources should be allocated to the process accordingly. 43 class UserActivity : public HysteresisActivity {43 class UserActivity : public PAL::HysteresisActivity { 44 44 public: 45 45 class Impl { … … 60 60 61 61 private: 62 void hysteresisUpdated( HysteresisState);62 void hysteresisUpdated(PAL::HysteresisState); 63 63 64 64 Impl m_impl; -
trunk/Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp
r221521 r222619 42 42 BackingStoreBackendCairoImpl::BackingStoreBackendCairoImpl(const IntSize& size, float deviceScaleFactor) 43 43 : BackingStoreBackendCairo(size) 44 , m_scrolledHysteresis([this]( HysteresisState state) { if (state ==HysteresisState::Stopped) m_scrollSurface = nullptr; }, scrollHysteresisDuration)44 , m_scrolledHysteresis([this](PAL::HysteresisState state) { if (state == PAL::HysteresisState::Stopped) m_scrollSurface = nullptr; }, scrollHysteresisDuration) 45 45 { 46 46 IntSize scaledSize = m_size; -
trunk/Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.h
r221521 r222619 21 21 #if USE(CAIRO) 22 22 #include "BackingStoreBackendCairo.h" 23 #include < WebCore/HysteresisActivity.h>23 #include <pal/HysteresisActivity.h> 24 24 25 25 namespace WebCore { … … 34 34 35 35 RefPtr<cairo_surface_t> m_scrollSurface; 36 WebCore::HysteresisActivity m_scrolledHysteresis;36 PAL::HysteresisActivity m_scrolledHysteresis; 37 37 }; 38 38 -
trunk/Source/WebCore/platform/ios/WebSQLiteDatabaseTrackerClient.h
r219595 r222619 28 28 #if PLATFORM(IOS) 29 29 30 #include "HysteresisActivity.h"31 30 #include "SQLiteDatabaseTrackerClient.h" 31 #include <pal/HysteresisActivity.h> 32 32 #include <wtf/Forward.h> 33 33 #include <wtf/Noncopyable.h> … … 48 48 virtual ~WebSQLiteDatabaseTrackerClient(); 49 49 50 void hysteresisUpdated( HysteresisState);50 void hysteresisUpdated(PAL::HysteresisState); 51 51 52 HysteresisActivity m_hysteresis;52 PAL::HysteresisActivity m_hysteresis; 53 53 }; 54 54 -
trunk/Source/WebCore/platform/ios/WebSQLiteDatabaseTrackerClient.mm
r218864 r222619 51 51 52 52 WebSQLiteDatabaseTrackerClient::WebSQLiteDatabaseTrackerClient() 53 : m_hysteresis([this]( HysteresisState state) { hysteresisUpdated(state); }, hysteresisDuration)53 : m_hysteresis([this](PAL::HysteresisState state) { hysteresisUpdated(state); }, hysteresisDuration) 54 54 { 55 55 } … … 73 73 } 74 74 75 void WebSQLiteDatabaseTrackerClient::hysteresisUpdated( HysteresisState state)75 void WebSQLiteDatabaseTrackerClient::hysteresisUpdated(PAL::HysteresisState state) 76 76 { 77 if (state == HysteresisState::Started)77 if (state == PAL::HysteresisState::Started) 78 78 [WebDatabaseTransactionBackgroundTaskController startBackgroundTask]; 79 79 else -
trunk/Source/WebKit/ChangeLog
r222613 r222619 1 2017-09-28 Ross Kirsling <ross.kirsling@sony.com> 2 3 [PAL] Move HysteresisActivity into PAL 4 https://bugs.webkit.org/show_bug.cgi?id=177516 5 6 Reviewed by Alex Christensen. 7 8 * NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp: 9 (WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::PendingFrameLoad): 10 * Shared/WebSQLiteDatabaseTracker.cpp: 11 (WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker): 12 (WebKit::WebSQLiteDatabaseTracker::hysteresisUpdated): 13 * Shared/WebSQLiteDatabaseTracker.h: 14 * WebProcess/WebPage/WebPage.cpp: 15 (WebKit::m_pageScrolledHysteresis): 16 (WebKit::m_userActivityHysteresis): 17 (WebKit::WebPage::updateUserActivity): 18 * WebProcess/WebPage/WebPage.h: 19 * WebProcess/WebProcess.cpp: 20 (WebKit::WebProcess::WebProcess): 21 * WebProcess/WebProcess.h: 22 1 23 2017-09-28 Chris Dumez <cdumez@apple.com> 2 24 -
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp
r220267 r222619 35 35 #include "NetworkProcess.h" 36 36 #include <WebCore/DiagnosticLoggingKeys.h> 37 #include < WebCore/HysteresisActivity.h>37 #include <pal/HysteresisActivity.h> 38 38 #include <wtf/HashCountedSet.h> 39 39 #include <wtf/NeverDestroyed.h> … … 208 208 , m_mainResourceKey(mainResourceKey) 209 209 , m_loadCompletionHandler(WTFMove(loadCompletionHandler)) 210 , m_loadHysteresisActivity([this]( HysteresisState state) { if (state ==HysteresisState::Stopped) markLoadAsCompleted(); })210 , m_loadHysteresisActivity([this](PAL::HysteresisState state) { if (state == PAL::HysteresisState::Stopped) markLoadAsCompleted(); }) 211 211 { 212 212 m_loadHysteresisActivity.impulse(); … … 240 240 Vector<std::unique_ptr<SubresourceLoad>> m_subresourceLoads; 241 241 WTF::Function<void()> m_loadCompletionHandler; 242 HysteresisActivity m_loadHysteresisActivity;242 PAL::HysteresisActivity m_loadHysteresisActivity; 243 243 std::unique_ptr<SubresourcesEntry> m_existingEntry; 244 244 bool m_didFinishLoad { false }; -
trunk/Source/WebKit/Shared/WebSQLiteDatabaseTracker.cpp
r182323 r222619 40 40 WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker(NetworkProcess& process) 41 41 : m_process(process) 42 , m_hysteresis([this]( HysteresisState state) { hysteresisUpdated(state); })42 , m_hysteresis([this](PAL::HysteresisState state) { hysteresisUpdated(state); }) 43 43 , m_childProcessType(ChildProcessType::Network) 44 44 { … … 48 48 WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker(WebProcess& process) 49 49 : m_process(process) 50 , m_hysteresis([this]( HysteresisState state) { hysteresisUpdated(state); })50 , m_hysteresis([this](PAL::HysteresisState state) { hysteresisUpdated(state); }) 51 51 , m_childProcessType(ChildProcessType::WebContent) 52 52 { … … 68 68 } 69 69 70 void WebSQLiteDatabaseTracker::hysteresisUpdated( HysteresisState state)70 void WebSQLiteDatabaseTracker::hysteresisUpdated(PAL::HysteresisState state) 71 71 { 72 72 switch (m_childProcessType) { 73 73 case ChildProcessType::WebContent: 74 m_process.parentProcessConnection()->send(Messages::WebProcessProxy::SetIsHoldingLockedFiles(state == HysteresisState::Started), 0);74 m_process.parentProcessConnection()->send(Messages::WebProcessProxy::SetIsHoldingLockedFiles(state == PAL::HysteresisState::Started), 0); 75 75 break; 76 76 case ChildProcessType::Network: 77 m_process.parentProcessConnection()->send(Messages::NetworkProcessProxy::SetIsHoldingLockedFiles(state == HysteresisState::Started), 0);77 m_process.parentProcessConnection()->send(Messages::NetworkProcessProxy::SetIsHoldingLockedFiles(state == PAL::HysteresisState::Started), 0); 78 78 break; 79 79 } -
trunk/Source/WebKit/Shared/WebSQLiteDatabaseTracker.h
r197563 r222619 27 27 #define WebSQLiteDatabaseTracker_h 28 28 29 #include <WebCore/HysteresisActivity.h>30 29 #include <WebCore/SQLiteDatabaseTrackerClient.h> 30 #include <pal/HysteresisActivity.h> 31 31 #include <wtf/Noncopyable.h> 32 32 … … 48 48 49 49 private: 50 void hysteresisUpdated( WebCore::HysteresisState);50 void hysteresisUpdated(PAL::HysteresisState); 51 51 52 52 ChildProcess& m_process; 53 WebCore::HysteresisActivity m_hysteresis;53 PAL::HysteresisActivity m_hysteresis; 54 54 enum class ChildProcessType { Network, WebContent }; 55 55 ChildProcessType m_childProcessType; -
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
r222613 r222619 340 340 , m_userMediaPermissionRequestManager { std::make_unique<UserMediaPermissionRequestManager>(*this) } 341 341 #endif 342 , m_pageScrolledHysteresis([this]( HysteresisState state) { if (state ==HysteresisState::Stopped) pageStoppedScrolling(); }, pageScrollHysteresisDuration)342 , m_pageScrolledHysteresis([this](PAL::HysteresisState state) { if (state == PAL::HysteresisState::Stopped) pageStoppedScrolling(); }, pageScrollHysteresisDuration) 343 343 , m_canRunBeforeUnloadConfirmPanel(parameters.canRunBeforeUnloadConfirmPanel) 344 344 , m_canRunModal(parameters.canRunModal) … … 353 353 , m_processSuppressionEnabled(true) 354 354 , m_userActivity("Process suppression disabled for page.") 355 , m_userActivityHysteresis([this]( HysteresisState) { updateUserActivity(); })355 , m_userActivityHysteresis([this](PAL::HysteresisState) { updateUserActivity(); }) 356 356 , m_userInterfaceLayoutDirection(parameters.userInterfaceLayoutDirection) 357 357 , m_overrideContentSecurityPolicy { parameters.overrideContentSecurityPolicy } … … 621 621 void WebPage::updateUserActivity() 622 622 { 623 if (m_userActivityHysteresis.state() == HysteresisState::Started)623 if (m_userActivityHysteresis.state() == PAL::HysteresisState::Started) 624 624 m_userActivity.start(); 625 625 else -
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
r222492 r222619 50 50 #include <WebCore/DictionaryPopupInfo.h> 51 51 #include <WebCore/FrameLoaderTypes.h> 52 #include <WebCore/HysteresisActivity.h>53 52 #include <WebCore/IntRect.h> 54 53 #include <WebCore/IntSizeHash.h> … … 62 61 #include <WebCore/WebCoreKeyboardUIMode.h> 63 62 #include <memory> 63 #include <pal/HysteresisActivity.h> 64 64 #include <wtf/HashMap.h> 65 65 #include <wtf/MonotonicTime.h> … … 1454 1454 Vector<RefPtr<SandboxExtension>> m_pendingDropExtensionsForFileUpload; 1455 1455 1456 WebCore::HysteresisActivity m_pageScrolledHysteresis;1456 PAL::HysteresisActivity m_pageScrolledHysteresis; 1457 1457 1458 1458 bool m_canRunBeforeUnloadConfirmPanel { false }; … … 1554 1554 bool m_processSuppressionEnabled; 1555 1555 UserActivity m_userActivity; 1556 WebCore::HysteresisActivity m_userActivityHysteresis;1556 PAL::HysteresisActivity m_userActivityHysteresis; 1557 1557 1558 1558 uint64_t m_pendingNavigationID { 0 }; -
trunk/Source/WebKit/WebProcess/WebProcess.cpp
r221768 r222619 163 163 , m_webLoaderStrategy(*new WebLoaderStrategy) 164 164 , m_cacheStorageProvider(WebCacheStorageProvider::create()) 165 , m_dnsPrefetchHystereris([this]( HysteresisState state) { if (state ==HysteresisState::Stopped) m_dnsPrefetchedHosts.clear(); })165 , m_dnsPrefetchHystereris([this](PAL::HysteresisState state) { if (state == PAL::HysteresisState::Stopped) m_dnsPrefetchedHosts.clear(); }) 166 166 #if ENABLE(NETSCAPE_PLUGIN_API) 167 167 , m_pluginProcessConnectionManager(PluginProcessConnectionManager::create()) -
trunk/Source/WebKit/WebProcess/WebProcess.h
r221743 r222619 35 35 #include "WebInspectorInterruptDispatcher.h" 36 36 #include <WebCore/ActivityState.h> 37 #include <WebCore/HysteresisActivity.h>38 37 #include <WebCore/Timer.h> 38 #include <pal/HysteresisActivity.h> 39 39 #include <pal/SessionID.h> 40 40 #include <wtf/Forward.h> … … 390 390 391 391 HashSet<String> m_dnsPrefetchedHosts; 392 WebCore::HysteresisActivity m_dnsPrefetchHystereris;392 PAL::HysteresisActivity m_dnsPrefetchHystereris; 393 393 394 394 std::unique_ptr<WebAutomationSessionProxy> m_automationSessionProxy;
Note: See TracChangeset
for help on using the changeset viewer.