Changeset 222623 in webkit


Ignore:
Timestamp:
Sep 28, 2017 12:22:47 PM (7 years ago)
Author:
Brent Fulgham
Message:

Add ports 6679 and 6697 (IRC SSL) to port blacklist
​https://bugs.webkit.org/show_bug.cgi?id=177544
<rdar://problem/34666525>

Reviewed by Alex Christensen.

Source/WebCore:

Test: security/block-test.html

  • platform/URL.cpp:

(WebCore::portAllowed): Also block port 6679.

LayoutTests:

Update test and expectations for new port.

  • security/block-test-expected.txt:
  • security/block-test.html:
  • platform/gtk/security/block-test-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • platform/wpe/security/block-test-expected.txt:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r222616 r222623  
     12017-09-28  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Add ports 6679 and 6697 (IRC SSL) to port blacklist
     4        https://bugs.webkit.org/show_bug.cgi?id=177544
     5        <rdar://problem/34666525>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Update test and expectations for new port.
     10
     11        * security/block-test-expected.txt:
     12        * security/block-test.html:
     13        * platform/gtk/security/block-test-expected.txt:
     14        * platform/mac/security/block-test-expected.txt:
     15        * platform/wpe/security/block-test-expected.txt:
     16
    1172017-09-28  Youenn Fablet  <youenn@apple.com>
    218

  • trunk/LayoutTests/platform/gtk/security/block-test-expected.txt

    r114976 r222623  
    128128http://255.255.255.255:6669/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6669/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
    129129http://255.255.255.255:6669/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6669/test.jpg">
     130http://255.255.255.255:6679/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6679/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
     131http://255.255.255.255:6679/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6679/test.jpg">
     132http://255.255.255.255:6697/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6697/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
     133http://255.255.255.255:6697/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6697/test.jpg">
    130134http://255.255.255.255:65535/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:65535/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
    131135http://255.255.255.255:65535/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:65535/test.jpg">

  • trunk/LayoutTests/platform/mac/security/block-test-expected.txt

    r207162 r222623  
    130130http://255.255.255.255:6669/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6669/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
    131131http://255.255.255.255:6669/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6669/test.jpg">
     132http://255.255.255.255:6679/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6679/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
     133http://255.255.255.255:6679/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6679/test.jpg">
     134http://255.255.255.255:6697/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6697/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
     135http://255.255.255.255:6697/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6697/test.jpg">
    132136http://255.255.255.255:65535/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:65535/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
    133137http://255.255.255.255:65535/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:65535/test.jpg">

  • trunk/LayoutTests/platform/wpe/security/block-test-expected.txt

    r216500 r222623  
    130130http://255.255.255.255:6669/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6669/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
    131131http://255.255.255.255:6669/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6669/test.jpg">
     132http://255.255.255.255:6679/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6679/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
     133http://255.255.255.255:6679/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6679/test.jpg">
     134http://255.255.255.255:6697/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6697/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
     135http://255.255.255.255:6697/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6697/test.jpg">
    132136http://255.255.255.255:65535/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:65535/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
    133137http://255.255.255.255:65535/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:65535/test.jpg">

  • trunk/LayoutTests/security/block-test-expected.txt

    r207162 r222623  
    130130http://255.255.255.255:6669/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6669/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
    131131http://255.255.255.255:6669/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6669/test.jpg">
     132http://255.255.255.255:6679/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6679/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
     133http://255.255.255.255:6679/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6679/test.jpg">
     134http://255.255.255.255:6697/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:6697/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
     135http://255.255.255.255:6697/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:6697/test.jpg">
    132136http://255.255.255.255:65535/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255:65535/test.jpg, main document URL block-test.html, http method GET> redirectResponse (null)
    133137http://255.255.255.255:65535/test.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://255.255.255.255:65535/test.jpg">

  • trunk/LayoutTests/security/block-test.html

    r200056 r222623  
    77      143, 179, 389, 465, 512, 513, 514, 515, 526, 530, 531, 532,
    88      540, 556, 563, 587, 601, 636, 993, 995, 2049, 3659, 4045,
    9       4190, 6000, 6665, 6666, 6667, 6668, 6669,
     9      4190, 6000, 6665, 6666, 6667, 6668, 6669, 6679, 6697,
    1010
    1111      // Port numbers that we consider to be invalid due to being out of range.

  • trunk/Source/WebCore/ChangeLog

    r222622 r222623  
     12017-09-28  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Add ports 6679 and 6697 (IRC SSL) to port blacklist
     4        https://bugs.webkit.org/show_bug.cgi?id=177544
     5        <rdar://problem/34666525>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Test: security/block-test.html
     10
     11        * platform/URL.cpp:
     12        (WebCore::portAllowed): Also block port 6679.
     13
    1142017-09-28  Chris Dumez  <cdumez@apple.com>
    215

  • trunk/Source/WebCore/platform/URL.cpp

    r222093 r222623  
    12791279        6668, // Alternate IRC [Apple addition]
    12801280        6669, // Alternate IRC [Apple addition]
     1281        6679, // Alternate IRC SSL [Apple addition]
     1282        6697, // IRC+SSL [Apple addition]
    12811283        invalidPortNumber, // Used to block all invalid port numbers
    12821284    };
Note: See TracChangeset for help on using the changeset viewer.