Changeset 222821 in webkit


Ignore:
Timestamp:
Oct 3, 2017 5:03:12 PM (6 years ago)
Author:
jdiggs@igalia.com
Message:

AX: [ATK] aria-rowindex set on row element is not being exposed
https://bugs.webkit.org/show_bug.cgi?id=177821

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the value of aria-rowindex when set on a row as an object
attribute, as we already do when it's set on a cell.

Test: accessibility/gtk/aria-rowindex-on-row.html

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

LayoutTests:

  • accessibility/gtk/aria-rowindex-on-row-expected.txt: Added.
  • accessibility/gtk/aria-rowindex-on-row.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r222818 r222821  
     12017-10-03  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [ATK] aria-rowindex set on row element is not being exposed
     4        https://bugs.webkit.org/show_bug.cgi?id=177821
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * accessibility/gtk/aria-rowindex-on-row-expected.txt: Added.
     9        * accessibility/gtk/aria-rowindex-on-row.html: Added.
     10
    1112017-10-03  Ms2ger  <Ms2ger@igalia.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r222819 r222821  
     12017-10-03  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [ATK] aria-rowindex set on row element is not being exposed
     4        https://bugs.webkit.org/show_bug.cgi?id=177821
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Expose the value of aria-rowindex when set on a row as an object
     9        attribute, as we already do when it's set on a cell.
     10
     11        Test: accessibility/gtk/aria-rowindex-on-row.html
     12
     13        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
     14        (webkitAccessibleGetAttributes):
     15
    1162017-10-03  Daniel Bates  <dabates@apple.com>
    217
  • trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

    r222787 r222821  
    4040#include "AccessibilityTable.h"
    4141#include "AccessibilityTableCell.h"
     42#include "AccessibilityTableRow.h"
    4243#include "Document.h"
    4344#include "Editing.h"
     
    471472        if (columnCount)
    472473            attributeSet = addToAtkAttributeSet(attributeSet, "colcount", String::number(columnCount).utf8().data());
    473     }
    474 
    475     if (is<AccessibilityTableCell>(*coreObject)) {
     474    } else if (is<AccessibilityTableRow>(*coreObject)) {
     475        auto& row = downcast<AccessibilityTableRow>(*coreObject);
     476        int rowIndex = row.ariaRowIndex();
     477        if (rowIndex != -1)
     478            attributeSet = addToAtkAttributeSet(attributeSet, "rowindex", String::number(rowIndex).utf8().data());
     479    } else if (is<AccessibilityTableCell>(*coreObject)) {
    476480        auto& cell = downcast<AccessibilityTableCell>(*coreObject);
    477481        int rowIndex = cell.ariaRowIndex();
Note: See TracChangeset for help on using the changeset viewer.