Changeset 222870 in webkit


Ignore:
Timestamp:
Oct 4, 2017 12:47:32 PM (7 years ago)
Author:
Ryan Haddad
Message:

Unreviewed, rolling out r222840.

This change breaks internal builds.

Reverted changeset:

"Generate a compile error if release is built without compiler
optimizations"
​https://bugs.webkit.org/show_bug.cgi?id=177665
​http://trac.webkit.org/changeset/222840

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/CMakeLists.txt

    r222840 r222870  
    1 # -----------------------------------------------------------------------------
    2 # Determine CMake version and build type.
    3 # -----------------------------------------------------------------------------
    41cmake_minimum_required(VERSION 3.3)
    5 
    6 if (NOT CMAKE_BUILD_TYPE)
    7     message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo.")
    8     set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build." FORCE)
    9 else ()
    10     message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}")
    11 endif ()
    12 
    132project(WebKit)
    143

  • trunk/ChangeLog

    r222869 r222870  
     12017-10-04  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, rolling out r222840.
     4
     5        This change breaks internal builds.
     6
     7        Reverted changeset:
     8
     9        "Generate a compile error if release is built without compiler
     10        optimizations"
     11        https://bugs.webkit.org/show_bug.cgi?id=177665
     12        http://trac.webkit.org/changeset/222840
     13
    1142017-10-04  Commit Queue  <commit-queue@webkit.org>
    215

  • trunk/Source/JavaScriptCore/ChangeLog

    r222840 r222870  
     12017-10-04  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, rolling out r222840.
     4
     5        This change breaks internal builds.
     6
     7        Reverted changeset:
     8
     9        "Generate a compile error if release is built without compiler
     10        optimizations"
     11        https://bugs.webkit.org/show_bug.cgi?id=177665
     12        http://trac.webkit.org/changeset/222840
     13
    1142017-10-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
    215

  • trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r222840 r222870  
    345345                0F61833C1C45F62A0072450B /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 51F0EB6105C86C6B00E6DF1B /* Foundation.framework */; };
    346346                0F61833D1C45F62A0072450B /* JavaScriptCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 932F5BD90822A1C700736975 /* JavaScriptCore.framework */; };
    347                 0F6183451C45F6600072450B /* testair.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F6183441C45F6600072450B /* testair.cpp */; settings = {COMPILER_FLAGS = "-O0 -DRELEASE_WITHOUT_OPTIMIZATIONS"; }; };
     347                0F6183451C45F6600072450B /* testair.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F6183441C45F6600072450B /* testair.cpp */; settings = {COMPILER_FLAGS = "-O0"; }; };
    348348                0F620174143FCD330068B77C /* DFGVariableAccessData.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F620172143FCD2F0068B77C /* DFGVariableAccessData.h */; };
    349349                0F620176143FCD3B0068B77C /* DFGBasicBlock.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F620170143FCD2F0068B77C /* DFGBasicBlock.h */; };
    … …  
    637637                0FEC85A31BDB5CF10080FF74 /* Foundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 51F0EB6105C86C6B00E6DF1B /* Foundation.framework */; };
    638638                0FEC85A41BDB5CF10080FF74 /* JavaScriptCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 932F5BD90822A1C700736975 /* JavaScriptCore.framework */; };
    639                 0FEC85AF1BDB5D5E0080FF74 /* testb3.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0FEC85AE1BDB5D5E0080FF74 /* testb3.cpp */; settings = {COMPILER_FLAGS = "-O0 -DRELEASE_WITHOUT_OPTIMIZATIONS"; }; };
     639                0FEC85AF1BDB5D5E0080FF74 /* testb3.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0FEC85AE1BDB5D5E0080FF74 /* testb3.cpp */; settings = {COMPILER_FLAGS = "-O0"; }; };
    640640                0FEC85B31BDED9570080FF74 /* B3ConstPtrValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FEC85B21BDED9570080FF74 /* B3ConstPtrValue.h */; };
    641641                0FEC85BA1BE1462F0080FF74 /* B3InsertionSet.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FEC85B51BE1462F0080FF74 /* B3InsertionSet.h */; };

  • trunk/Source/WTF/ChangeLog

    r222840 r222870  
     12017-10-04  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, rolling out r222840.
     4
     5        This change breaks internal builds.
     6
     7        Reverted changeset:
     8
     9        "Generate a compile error if release is built without compiler
     10        optimizations"
     11        https://bugs.webkit.org/show_bug.cgi?id=177665
     12        http://trac.webkit.org/changeset/222840
     13
    1142017-10-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
    215

  • trunk/Source/WTF/wtf/Compiler.h

    r222840 r222870  
    105105#endif /* COMPILER(GCC) */
    106106
    107 #if COMPILER(GCC_OR_CLANG) && defined(NDEBUG) && !defined(__OPTIMIZE__) && !defined(RELEASE_WITHOUT_OPTIMIZATIONS)
    108 #error "Building release without compiler optimizations: WebKit will be slow. Set -DRELEASE_WITHOUT_OPTIMIZATIONS if this is intended."
    109 #endif
    110 
    111107/* COMPILER(MINGW) - MinGW GCC */
    112108
Note: See TracChangeset for help on using the changeset viewer.