Changeset 222974 in webkit


Ignore:
Timestamp:
Oct 6, 2017 3:22:37 AM (7 years ago)
Author:
Ms2ger@igalia.com
Message:

Create bindings for WebGL2's versions of compressedTexImage2D.
​https://bugs.webkit.org/show_bug.cgi?id=177481

Reviewed by Žan Doberšek.

No new tests: not much point in adding tests now; this method doesn't
do anything anyway.

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::compressedTexImage2D):

  • html/canvas/WebGL2RenderingContext.h:
  • html/canvas/WebGL2RenderingContext.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLRenderingContextBase.idl:
Location:
trunk/Source/WebCore
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r222972 r222974  
     12017-10-06  Ms2ger  <Ms2ger@igalia.com>
     2
     3        Create bindings for WebGL2's versions of compressedTexImage2D.
     4        https://bugs.webkit.org/show_bug.cgi?id=177481
     5
     6        Reviewed by Žan Doberšek.
     7
     8        No new tests: not much point in adding tests now; this method doesn't
     9        do anything anyway.
     10
     11        * html/canvas/WebGL2RenderingContext.cpp:
     12        (WebCore::WebGL2RenderingContext::compressedTexImage2D):
     13        * html/canvas/WebGL2RenderingContext.h:
     14        * html/canvas/WebGL2RenderingContext.idl:
     15        * html/canvas/WebGLRenderingContext.idl:
     16        * html/canvas/WebGLRenderingContextBase.idl:
     17
    1182017-10-06  Enrique Ocaña González  <eocanha@igalia.com>
    219

  • trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp

    r222496 r222974  
    493493
    494494void WebGL2RenderingContext::copyTexSubImage3D(GC3Denum, GC3Dint, GC3Dint, GC3Dint, GC3Dint, GC3Dint, GC3Dint, GC3Dsizei, GC3Dsizei)
     495{
     496}
     497
     498void WebGL2RenderingContext::compressedTexImage2D(GC3Denum, GC3Dint, GC3Denum, GC3Dsizei, GC3Dsizei, GC3Dint, GC3Dsizei, GC3Dint64)
     499{
     500}
     501
     502void WebGL2RenderingContext::compressedTexImage2D(GC3Denum, GC3Dint, GC3Denum, GC3Dsizei, GC3Dsizei, GC3Dint, ArrayBufferView&, GC3Duint, GC3Duint)
    495503{
    496504}

  • trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h

    r222496 r222974  
    7373
    7474    void copyTexSubImage3D(GC3Denum target, GC3Dint level, GC3Dint xoffset, GC3Dint yoffset, GC3Dint zoffset, GC3Dint x, GC3Dint y, GC3Dsizei width, GC3Dsizei height);
     75
     76    void compressedTexImage2D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dint border, GC3Dsizei imageSize, GC3Dint64 offset);
     77    void compressedTexImage2D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dint border, ArrayBufferView& data, GC3Duint, GC3Duint);
    7578    void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, GC3Dsizei imageSize, GC3Dint64 offset);
    7679    void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, ArrayBufferView& srcData, GC3Duint srcOffset, GC3Duint srcLengthOverride);

  • trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.idl

    r222496 r222974  
    371371    void copyTexSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLint x, GLint y, GLsizei width, GLsizei height);
    372372
     373    void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLint border, GLsizei imageSize, GLintptr offset);
     374    void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLint border, ArrayBufferView srcData, optional GLuint srcOffset = 0, optional GLuint srcLengthOverride = 0);
     375
    373376    void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, GLsizei imageSize, GLintptr offset);
    374377    void compressedTexImage3D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLsizei depth, GLint border, ArrayBufferView srcData, optional GLuint srcOffset = 0, optional GLuint srcLengthOverride = 0);

  • trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl

    r221232 r222974  
    2424 */
    2525
     26typedef unsigned long GLenum;
     27typedef long GLint;
     28typedef long GLsizei;
     29
    2630[
    2731    Conditional=WEBGL,
    … …  
    3236    CallTracingCallback=recordCanvasAction,
    3337] interface WebGLRenderingContext {
     38    // This method is placed outside of WebGLRenderingContextBase to avoid
     39    // conficts with overloads in WebGL2RenderingContext.
     40    void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat, GLsizei width, GLsizei height, GLint border, ArrayBufferView data);
    3441};
    3542

  • trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl

    r219343 r222974  
    508508    void compileShader(WebGLShader? shader);
    509509
    510     void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat,
    511     GLsizei width, GLsizei height, GLint border, ArrayBufferView data);
     510    // compressedTexImage2D is split between WebGLRenderingContext and
     511    // WebGL2RenderingContext because the ArrayBufferView overloads are
     512    // indistinguishable.
     513
    512514    void compressedTexSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
    513515        GLsizei width, GLsizei height, GLenum format, ArrayBufferView data);
Note: See TracChangeset for help on using the changeset viewer.