Changeset 223126 in webkit
- Timestamp:
- Oct 10, 2017 1:55:18 AM (6 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r223118 r223126 1 2017-10-10 Joanmarie Diggs <jdiggs@igalia.com> 2 3 AX: [ATK] STATE_CHECKABLE should be removed from radio buttons in radiogroups with aria-readonly="true" 4 https://bugs.webkit.org/show_bug.cgi?id=177931 5 6 Reviewed by Chris Fleizach. 7 8 * accessibility/gtk/aria-readonly-radiogroup-expected.txt: Added. 9 * accessibility/gtk/aria-readonly-radiogroup.html: Added. 10 1 11 2017-10-09 Chris Dumez <cdumez@apple.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r223118 r223126 1 2017-10-10 Joanmarie Diggs <jdiggs@igalia.com> 2 3 AX: [ATK] STATE_CHECKABLE should be removed from radio buttons in radiogroups with aria-readonly="true" 4 https://bugs.webkit.org/show_bug.cgi?id=177931 5 6 Reviewed by Chris Fleizach. 7 8 Add a check in canSetValueAttribute() for readonly radiogroup ancestors of 9 radio buttons. 10 11 Test: accessibility/gtk/aria-readonly-radiogroup.html 12 13 * accessibility/AccessibilityNodeObject.cpp: 14 (WebCore::AccessibilityNodeObject::canSetValueAttribute const): 15 * accessibility/AccessibilityObject.cpp: 16 (WebCore::AccessibilityObject::radioGroupAncestor const): 17 * accessibility/AccessibilityObject.h: 18 1 19 2017-10-09 Chris Dumez <cdumez@apple.com> 2 20 -
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
r222544 r223126 2100 2100 // In ATK, input types which support aria-readonly are treated as having a 2101 2101 // settable value if the user can modify the widget's value or its state. 2102 if (supportsARIAReadOnly() || isRadioButton()) 2103 return true; 2102 if (supportsARIAReadOnly()) 2103 return true; 2104 2105 if (isRadioButton()) { 2106 auto radioGroup = radioGroupAncestor(); 2107 return radioGroup ? radioGroup->ariaReadOnlyValue() != "true" : true; 2108 } 2104 2109 #endif 2105 2110 -
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
r223048 r223126 3315 3315 } 3316 3316 3317 AccessibilityObject* AccessibilityObject::radioGroupAncestor() const 3318 { 3319 return const_cast<AccessibilityObject*>(AccessibilityObject::matchedParent(*this, false, [] (const AccessibilityObject& object) { 3320 return object.isRadioGroup(); 3321 })); 3322 } 3323 3317 3324 bool AccessibilityObject::isStyleFormatGroup() const 3318 3325 { -
trunk/Source/WebCore/accessibility/AccessibilityObject.h
r223048 r223126 1163 1163 void ariaElementsReferencedByAttribute(AccessibilityChildrenVector&, const QualifiedName&) const; 1164 1164 1165 AccessibilityObject* radioGroupAncestor() const; 1166 1165 1167 #if PLATFORM(GTK) && HAVE(ACCESSIBILITY) 1166 1168 bool allowsTextRanges() const;
Note: See TracChangeset
for help on using the changeset viewer.