Changeset 223168 in webkit

Timestamp:

Oct 10, 2017 10:48:47 PM (7 years ago)

Author:

calvaris@igalia.com

Message:

[GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc
​https://bugs.webkit.org/show_bug.cgi?id=178079

Reviewed by Žan Doberšek.

When the downloadbuffer GStreamer element requests two seeks too
close to each other there's some rare race condition where our
source answers that it is not seekable and ends up with
downloadbuffer element to seek beyond the file size, which causes
the server to issue a 416 HTTP error code eventually, causing our
MediaPlayer to stop.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStop): We only unset he seekable attribute if we are
not seeking.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-10  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc
+        https://bugs.webkit.org/show_bug.cgi?id=178079
+
+        Reviewed by Žan Doberšek.
+
+        When the downloadbuffer GStreamer element requests two seeks too
+        close to each other there's some rare race condition where our
+        source answers that it is not seekable and ends up with
+        downloadbuffer element to seek beyond the file size, which causes
+        the server to issue a 416 HTTP error code eventually, causing our
+        MediaPlayer to stop.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (webKitWebSrcStop): We only unset he seekable attribute if we are
+        not seeking.
+
 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

@@ -59 +59 @@
 private:
 #if USE(SOUP)
-    char* getOrCreateReadBuffer(PlatformMediaResource&, size_t requestedSize, size_t& actualSize);
+    char* getOrCreateReadBuffer(PlatformMediaResource&, size_t requestedSize, size_t& actualSize) override;
 #endif
     // PlatformMediaResourceClient virtual methods.
@@ -374 +374 @@
 
     priv->offset = 0;
-    priv->seekable = FALSE;
 
     if (!wasSeeking) {
@@ -380 +379 @@
         priv->requestedOffset = 0;
         priv->player = nullptr;
+        priv->seekable = FALSE;
     }