Changeset 223190 in webkit


Ignore:
Timestamp:
Oct 11, 2017 10:04:42 AM (6 years ago)
Author:
jdiggs@igalia.com
Message:

[ATK] Expose value of aria-keyshortcuts as object attribute
https://bugs.webkit.org/show_bug.cgi?id=171175

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the author-provided string through the "keyshortcuts" object attribute.

Test: accessibility/gtk/aria-keyshortcuts.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaKeyShortcutsValue const):

  • accessibility/AccessibilityObject.h:
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

  • html/HTMLAttributeNames.in:

LayoutTests:

  • accessibility/gtk/aria-keyshortcuts-expected.txt: Added.
  • accessibility/gtk/aria-keyshortcuts.html: Added.
Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r223189 r223190  
     12017-10-11  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        [ATK] Expose value of aria-keyshortcuts as object attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=171175
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * accessibility/gtk/aria-keyshortcuts-expected.txt: Added.
     9        * accessibility/gtk/aria-keyshortcuts.html: Added.
     10
    1112017-10-11  Youenn Fablet  <youenn@apple.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r223173 r223190  
     12017-10-11  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        [ATK] Expose value of aria-keyshortcuts as object attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=171175
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Expose the author-provided string through the "keyshortcuts" object attribute.
     9
     10        Test: accessibility/gtk/aria-keyshortcuts.html
     11
     12        * accessibility/AccessibilityObject.cpp:
     13        (WebCore::AccessibilityObject::ariaKeyShortcutsValue const):
     14        * accessibility/AccessibilityObject.h:
     15        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
     16        (webkitAccessibleGetAttributes):
     17        * html/HTMLAttributeNames.in:
     18
    1192017-10-11  Yusuke Suzuki  <utatane.tea@gmail.com>
    220
  • trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

    r223126 r223190  
    24462446}
    24472447   
     2448const AtomicString& AccessibilityObject::ariaKeyShortcutsValue() const
     2449{
     2450    return getAttribute(aria_keyshortcutsAttr);
     2451}
     2452
    24482453Element* AccessibilityObject::element() const
    24492454{
  • trunk/Source/WebCore/accessibility/AccessibilityObject.h

    r223126 r223190  
    704704    String ariaCurrentValue() const;
    705705    bool supportsARIACurrent() const;
     706    const AtomicString& ariaKeyShortcutsValue() const;
    706707   
    707708    // This function checks if the object should be ignored when there's a modal dialog displayed.
  • trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

    r223145 r223190  
    601601    else if (coreObject->supportsARIADragging())
    602602        attributeSet = addToAtkAttributeSet(attributeSet, "grabbed", "false");
     603
     604    // The Core AAM states the author-provided value should be exposed as-is.
     605    const AtomicString& keyShortcuts = coreObject->ariaKeyShortcutsValue();
     606    if (!keyShortcuts.isEmpty())
     607        attributeSet = addToAtkAttributeSet(attributeSet, "keyshortcuts", keyShortcuts.string().utf8().data());
    603608
    604609    return attributeSet;
  • trunk/Source/WebCore/html/HTMLAttributeNames.in

    r221177 r223190  
    3636aria-hidden
    3737aria-invalid
     38aria-keyshortcuts
    3839aria-label
    3940aria-labeledby
Note: See TracChangeset for help on using the changeset viewer.