Changeset 223222 in webkit


Ignore:
Timestamp:
Oct 11, 2017 5:53:45 PM (6 years ago)
Author:
sbarati@apple.com
Message:

Runtime disable poly proto because it may be a 3-4% Speedometer regression
https://bugs.webkit.org/show_bug.cgi?id=178192

Reviewed by JF Bastien.

Source/JavaScriptCore:

  • runtime/Options.h:
  • runtime/StructureInlines.h:

(JSC::Structure::shouldConvertToPolyProto):

Tools:

  • Scripts/run-jsc-stress-tests:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r223202 r223222  
     12017-10-11  Saam Barati  <sbarati@apple.com>
     2
     3        Runtime disable poly proto because it may be a 3-4% Speedometer regression
     4        https://bugs.webkit.org/show_bug.cgi?id=178192
     5
     6        Reviewed by JF Bastien.
     7
     8        * runtime/Options.h:
     9        * runtime/StructureInlines.h:
     10        (JSC::Structure::shouldConvertToPolyProto):
     11
    1122017-10-11  Commit Queue  <commit-queue@webkit.org>
    213
  • trunk/Source/JavaScriptCore/runtime/Options.h

    r223047 r223222  
    474474    v(bool, useObjectRestSpread, true, Normal, "If true, we will enable Object Rest/Spread feature.") \
    475475    v(bool, useArrayAllocationProfiling, true, Normal, "If true, we will use our normal array allocation profiling. If false, the allocation profile will always claim to be undecided.")\
     476    v(bool, usePolyProto, false, Normal, "If true, we may convert allocations to generate poly proto structures.") \
    476477    v(bool, forcePolyProto, false, Normal, "If true, create_this will always create an object with a poly proto structure.")
    477478
  • trunk/Source/JavaScriptCore/runtime/StructureInlines.h

    r222827 r223222  
    448448ALWAYS_INLINE bool Structure::shouldConvertToPolyProto(const Structure* a, const Structure* b)
    449449{
     450    if (!Options::usePolyProto())
     451        return false;
     452
    450453    if (!a || !b)
    451454        return false;
  • trunk/Tools/ChangeLog

    r223213 r223222  
     12017-10-11  Saam Barati  <sbarati@apple.com>
     2
     3        Runtime disable poly proto because it may be a 3-4% Speedometer regression
     4        https://bugs.webkit.org/show_bug.cgi?id=178192
     5
     6        Reviewed by JF Bastien.
     7
     8        * Scripts/run-jsc-stress-tests:
     9
    1102017-10-11  Youenn Fablet  <youenn@apple.com>
    211
  • trunk/Tools/Scripts/run-jsc-stress-tests

    r223202 r223222  
    452452
    453453# We force all tests to use a smaller (1.5M) stack so that stack overflow tests can run faster.
    454 BASE_OPTIONS = ["--useFTLJIT=false", "--useFunctionDotArguments=true", "--validateExceptionChecks=true", "--maxPerThreadStackUsage=1572864"]
    455 EAGER_OPTIONS = ["--thresholdForJITAfterWarmUp=10", "--thresholdForJITSoon=10", "--thresholdForOptimizeAfterWarmUp=20", "--thresholdForOptimizeAfterLongWarmUp=20", "--thresholdForOptimizeSoon=20", "--thresholdForFTLOptimizeAfterWarmUp=20", "--thresholdForFTLOptimizeSoon=20", "--maximumEvalCacheableSourceLength=150000", "--useEagerCodeBlockJettisonTiming=true"]
     454BASE_OPTIONS = ["--useFTLJIT=false", "--useFunctionDotArguments=true", "--validateExceptionChecks=true", "--maxPerThreadStackUsage=1572864", "--usePolyProto=true"]
     455EAGER_OPTIONS = ["--thresholdForJITAfterWarmUp=10", "--thresholdForJITSoon=10", "--thresholdForOptimizeAfterWarmUp=20", "--thresholdForOptimizeAfterLongWarmUp=20", "--thresholdForOptimizeSoon=20", "--thresholdForFTLOptimizeAfterWarmUp=20", "--thresholdForFTLOptimizeSoon=20", "--maximumEvalCacheableSourceLength=150000", "--useEagerCodeBlockJettisonTiming=true", "--usePolyProto=true"]
    456456# NOTE: Tests rely on this using scribbleFreeCells.
    457 NO_CJIT_OPTIONS = ["--useConcurrentJIT=false", "--thresholdForJITAfterWarmUp=100", "--scribbleFreeCells=true"]
    458 B3O1_OPTIONS = ["--defaultB3OptLevel=1"]
    459 FTL_OPTIONS = ["--useFTLJIT=true"]
    460 PROBE_OSR_EXIT_OPTION = ["--useProbeOSRExit=true"]
     457NO_CJIT_OPTIONS = ["--useConcurrentJIT=false", "--thresholdForJITAfterWarmUp=100", "--scribbleFreeCells=true", "--usePolyProto=true"]
     458B3O1_OPTIONS = ["--defaultB3OptLevel=1", "--usePolyProto=true"]
     459FTL_OPTIONS = ["--useFTLJIT=true", "--usePolyProto=true"]
     460PROBE_OSR_EXIT_OPTION = ["--useProbeOSRExit=true", "--usePolyProto=true"]
    461461
    462462require_relative "webkitruby/jsc-stress-test-writer-#{$testWriter}"
Note: See TracChangeset for help on using the changeset viewer.