Changeset 223284 in webkit

Timestamp:

Oct 13, 2017 10:19:06 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Modernize LayoutTests/http/tests/cache-storage/cache-clearing-*.https.html
​https://bugs.webkit.org/show_bug.cgi?id=178245

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-13
Reviewed by Chris Dumez.

Using await/async to improve the testing.
Taking benefit of clearDOMCache to wait for completion to simplify both tests as well.

• http/tests/cache-storage/cache-clearing-all.https.html:
• http/tests/cache-storage/cache-clearing-origin.https.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/cache-storage/cache-clearing-all.https.html (modified) (1 diff)
• http/tests/cache-storage/cache-clearing-origin.https.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-10-13  Youenn Fablet  <youenn@apple.com>
+
+        Modernize LayoutTests/http/tests/cache-storage/cache-clearing-*.https.html
+        https://bugs.webkit.org/show_bug.cgi?id=178245
+
+        Reviewed by Chris Dumez.
+
+        Using await/async to improve the testing.
+        Taking benefit of clearDOMCache to wait for completion to simplify both tests as well.
+
+        * http/tests/cache-storage/cache-clearing-all.https.html:
+        * http/tests/cache-storage/cache-clearing-origin.https.html:
+
 2017-10-13  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/LayoutTests/http/tests/cache-storage/cache-clearing-all.https.html

@@ -17 +17 @@
 }, "Cleaning existing caches");
 
-function waitFor(delay)
-{
-    return new Promise(resolve => {
-        setTimeout(resolve, delay);
-    });
-}
+promise_test(async (test) => {
+    var cache = await self.caches.open("test-cache-records-persistency");
+    await cache.put("https://example.com/foo", new Response("body", { statusText: "status" }));
 
-async function validateCachesEmptyness(expected, counter)
-{
+    if (!window.testRunner)
+        return Promise.reject("test runner needed");
+    testRunner.clearDOMCache();
+
     var keys = await self.caches.keys();
+    assert_equals(keys.length, 0, "keys should be empty");
 
-    var isEmpty = keys.length === 0;
-    if (isEmpty === expected)
-        return true;
-
-    if (counter > 10)
-        return false;
-
-    await waitFor(100);
-    if (!counter)
-        counter = 0;
-    return validateCachesEmptyness(expected, ++counter);
-}
-
-promise_test(() => {
-    var test_url = 'https://example.com/foo';
-    var cache;
-    var cache_keys;
-    var first_response = new Response("Old body", { statusText: 'Old status' });
-    var alternate_response = new Response("New body", { statusText: 'New status' });
-    return self.caches.open("test-cache-records-persistency").then(c => {
-        cache = c;
-    }).then(() => {
-        return cache.put(test_url, first_response);
-    }).then(() => {
-        if (!window.testRunner)
-            return Promise.reject("test runner needed");
-        testRunner.clearDOMCache();
-        return validateCachesEmptyness(true);
-    }).then(result => {
-        assert_true(result, "caches should be empty");
-        return self.caches.open("test-cache-records-persistency");
-    }).then(cache => {
-        return cache.keys();
-    }).then(keys => {
-        assert_equals(keys.length, 0, "records should be empty");
-    });
+    cache = await self.caches.open("test-cache-records-persistency");
+    keys = await cache.keys();
+    assert_equals(keys.length, 0, "records should be empty");
 }, 'Clearing all disk cache');
     </script>

trunk/LayoutTests/http/tests/cache-storage/cache-clearing-origin.https.html

@@ -17 +17 @@
 }, "Cleaning existing caches");
 
-function waitFor(delay)
-{
-    return new Promise(resolve => {
-        setTimeout(resolve, delay);
-    });
-}
+promise_test(async test => {
+    var cache = await self.caches.open("test-cache-records-persistency");
+    await cache.put("https://example.com/foo", new Response("body", { statusText: "status" }));
 
-async function validateCachesEmptyness(expected, counter)
-{
+    if (!window.testRunner)
+        return Promise.reject("test runner needed");
+    testRunner.clearDOMCache('https://localhost:80');
+
     var keys = await self.caches.keys();
+    assert_not_equals(keys.length, 0, "keys should not be empty");
 
-    var isEmpty = keys.length === 0;
-    if (isEmpty === expected)
-        return true;
+    testRunner.clearDOMCache(window.location.origin);
+    keys = await self.caches.keys();
+    assert_equals(keys.length, 0, "keys should be empty");
 
-    if (counter > 10)
-        return false;
-
-    await waitFor(100);
-    if (!counter)
-        counter = 0;
-    return validateCachesEmptyness(expected, ++counter);
-}
-
-promise_test(() => {
-    var test_url = 'https://example.com/foo';
-    var cache;
-    var cache_keys;
-    var first_response = new Response("Old body", { statusText: 'Old status' });
-    var alternate_response = new Response("New body", { statusText: 'New status' });
-    return self.caches.open("test-cache-records-persistency").then(c => {
-        cache = c;
-    }).then(() => {
-        return cache.put(test_url, first_response);
-    }).then(() => {
-        if (!window.testRunner)
-            return Promise.reject("test runner needed");
-        testRunner.clearDOMCache('https://localhost:80');
-        return validateCachesEmptyness(false);
-    }).then(result => {
-        assert_true(result, "caches should not be empty");
-        testRunner.clearDOMCache(window.location.origin);
-        return validateCachesEmptyness(true);
-    }).then(result => {
-        assert_true(result, "caches should be empty");
-        return self.caches.open("test-cache-records-persistency");
-    }).then(cache => {
-        return cache.keys();
-    }).then(keys => {
-        assert_equals(keys.length, 0, "records should be empty");
-    });
+    cache = await self.caches.open("test-cache-records-persistency");
+    keys = await cache.keys();
+    assert_equals(keys.length, 0, "records should be empty");
 }, 'Clearing disk cache of a given origin');
     </script>