Changeset 223330 in webkit

Timestamp:

Oct 15, 2017 2:58:42 PM (7 years ago)

Author:

Chris Dumez

Message:

DOMTokenList shouldn't add empty attributes
​https://bugs.webkit.org/show_bug.cgi?id=178280
<rdar://problem/34987431>

Reviewed by Ryosuke Niwa.

Follow-up to r223306, reverse the check conditions to avoid attribute
lookup when possible. Also use m_tokens instead of tokens() to avoid
unnecessary branch.

• html/DOMTokenList.cpp:

(WebCore::DOMTokenList::updateAssociatedAttributeFromTokens):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/DOMTokenList.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-15  Chris Dumez  <cdumez@apple.com>
+
+        DOMTokenList shouldn't add empty attributes
+        https://bugs.webkit.org/show_bug.cgi?id=178280
+        <rdar://problem/34987431>
+
+        Reviewed by Ryosuke Niwa.
+
+        Follow-up to r223306, reverse the check conditions to avoid attribute
+        lookup when possible. Also use m_tokens instead of tokens() to avoid
+        unnecessary branch.
+
+        * html/DOMTokenList.cpp:
+        (WebCore::DOMTokenList::updateAssociatedAttributeFromTokens):
+
 2017-10-15  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/html/DOMTokenList.cpp

@@ -249 +249 @@
     ASSERT(!m_tokensNeedUpdating);
 
-    if (!m_element.hasAttribute(m_attributeName) && tokens().isEmpty())
+    if (m_tokens.isEmpty() && !m_element.hasAttribute(m_attributeName))
         return;