Changeset 223334 in webkit

Timestamp:

Oct 15, 2017 9:16:56 PM (7 years ago)

Author:

tpopela@redhat.com

Message:

DataTransfer.cpp triggers -Wunused-but-set-variable
​https://bugs.webkit.org/show_bug.cgi?id=178209

Reviewed by Wenson Hsieh.

Use the ASSERT_UNUSED to silence it.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::filesFromPasteboardAndItemList const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/DataTransfer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-16  Tomas Popela  <tpopela@redhat.com>
+
+        DataTransfer.cpp triggers -Wunused-but-set-variable
+        https://bugs.webkit.org/show_bug.cgi?id=178209
+
+        Reviewed by Wenson Hsieh.
+
+        Use the ASSERT_UNUSED to silence it.
+
+        * dom/DataTransfer.cpp:
+        (WebCore::DataTransfer::filesFromPasteboardAndItemList const):
+
 2017-10-15  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/dom/DataTransfer.cpp

@@ -305 +305 @@
     }
 
-    ASSERT(!itemListContainsItems || !addedFilesFromPasteboard);
+    bool containsItemsAndFiles = itemListContainsItems && addedFilesFromPasteboard;
+    ASSERT_UNUSED(containsItemsAndFiles, !containsItemsAndFiles);
     return files;
 }