Changeset 223448 in webkit


Ignore:
Timestamp:
Oct 16, 2017 5:03:30 PM (7 years ago)
Author:
Chris Dumez
Message:

DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]
​https://bugs.webkit.org/show_bug.cgi?id=178366

Reviewed by Youenn Fablet.

Source/WebCore:

DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]. We attempted to do so using JSDOMQuad::visitAdditionalChildren()
but the code did not work because we failed to generate a "isReachableFromOpaqueRoots()" function for JSDOMPoint.

Test: fast/css/DOMQuad-points-SameObject.html

  • dom/DOMPoint.idl:

LayoutTests:

Add layout test coverage.

  • fast/css/DOMQuad-points-SameObject.html: Added.
Location:
trunk
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r223447 r223448  
     12017-10-16  Chris Dumez  <cdumez@apple.com>
     2
     3        DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]
     4        https://bugs.webkit.org/show_bug.cgi?id=178366
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Add layout test coverage.
     9
     10        * fast/css/DOMQuad-points-SameObject.html: Added.
     11
    1122017-10-16  Andy Estes  <aestes@apple.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r223447 r223448  
     12017-10-16  Chris Dumez  <cdumez@apple.com>
     2
     3        DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]
     4        https://bugs.webkit.org/show_bug.cgi?id=178366
     5
     6        Reviewed by Youenn Fablet.
     7
     8        DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]. We attempted to do so using JSDOMQuad::visitAdditionalChildren()
     9        but the code did not work because we failed to generate a "isReachableFromOpaqueRoots()" function for JSDOMPoint.
     10
     11        Test: fast/css/DOMQuad-points-SameObject.html
     12
     13        * dom/DOMPoint.idl:
     14
    1152017-10-16  Andy Estes  <aestes@apple.com>
    216

  • trunk/Source/WebCore/dom/DOMPoint.idl

    r209677 r223448  
    3535        optional unrestricted double z = 0, optional unrestricted double w = 1),
    3636    Exposed=(Window,Worker),
     37    GenerateIsReachable=Impl,
    3738    ImplementationLacksVTable
    3839]
Note: See TracChangeset for help on using the changeset viewer.