Changeset 223459 in webkit

Timestamp:

Oct 16, 2017 11:21:46 PM (7 years ago)

Author:

dino@apple.com

Message:

WebGL clamps drawingBufferWidth to 4096 pixels on a 5120 monitor/canvas
​https://bugs.webkit.org/show_bug.cgi?id=178223
<rdar://problem/34597567>

Reviewed by Antoine Quint.

Source/WebCore:

Remove the limit of 4k on the width/height of the renderbuffer.

Test: fast/canvas/webgl/large-drawing-buffer-resize.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::reshape):

LayoutTests:

Test that resizes an already large buffer to make sure it
doesn't get clamped to 4k.

• fast/canvas/webgl/large-drawing-buffer-resize-expected.txt: Added.
• fast/canvas/webgl/large-drawing-buffer-resize.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/webgl/large-drawing-buffer-resize-expected.txt (added)
• LayoutTests/fast/canvas/webgl/large-drawing-buffer-resize.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-10-16  Dean Jackson  <dino@apple.com>
+
+        WebGL clamps drawingBufferWidth to 4096 pixels on a 5120 monitor/canvas
+        https://bugs.webkit.org/show_bug.cgi?id=178223
+        <rdar://problem/34597567>
+
+        Reviewed by Antoine Quint.
+
+        Test that resizes an already large buffer to make sure it
+        doesn't get clamped to 4k.
+
+        * fast/canvas/webgl/large-drawing-buffer-resize-expected.txt: Added.
+        * fast/canvas/webgl/large-drawing-buffer-resize.html: Added.
+
 2017-10-16  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-16  Dean Jackson  <dino@apple.com>
+
+        WebGL clamps drawingBufferWidth to 4096 pixels on a 5120 monitor/canvas
+        https://bugs.webkit.org/show_bug.cgi?id=178223
+        <rdar://problem/34597567>
+
+        Reviewed by Antoine Quint.
+
+        Remove the limit of 4k on the width/height of the renderbuffer.
+
+        Test: fast/canvas/webgl/large-drawing-buffer-resize.html
+
+        * html/canvas/WebGLRenderingContextBase.cpp:
+        (WebCore::WebGLRenderingContextBase::reshape):
+
 2017-10-16  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp

@@ -847 +847 @@
     // know if the underlying FBO uses textures or renderbuffers.
     GC3Dint maxSize = std::min(m_maxTextureSize, m_maxRenderbufferSize);
-    // Limit drawing buffer size to 4k to avoid memory exhaustion.
-    const int sizeUpperLimit = 4096;
-    maxSize = std::min(maxSize, sizeUpperLimit);
     GC3Dint maxWidth = std::min(maxSize, m_maxViewportDims[0]);
     GC3Dint maxHeight = std::min(maxSize, m_maxViewportDims[1]);