Changeset 223585 in webkit

Timestamp:

Oct 17, 2017 4:38:26 PM (7 years ago)

Author:

cpugh@apple.com

Message:

[iOS] Don't turn fields yellow after filling credentials
​https://bugs.webkit.org/show_bug.cgi?id=178411

Reviewed by Wenson Hsieh.

• editing/ios/AutofillElements.cpp:

(WebCore::AutofillElements::autofill): We don't want to turn fields yellow when filling the user name
and password. Remove the code that was causing that to happen.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/ios/AutofillElements.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-17  Chelsea Pugh  <cpugh@apple.com>
+
+        [iOS] Don't turn fields yellow after filling credentials
+        https://bugs.webkit.org/show_bug.cgi?id=178411
+
+        Reviewed by Wenson Hsieh.
+
+        * editing/ios/AutofillElements.cpp:
+        (WebCore::AutofillElements::autofill): We don't want to turn fields yellow when filling the user name
+        and password. Remove the code that was causing that to happen.
+
 2017-10-16  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/editing/ios/AutofillElements.cpp

@@ -120 +120 @@
 void AutofillElements::autofill(String username, String password)
 {
-    if (m_username) {
+    if (m_username)
         m_username->setValueForUser(username);
-        m_username->setAutoFilled();
-    }
-    if (m_password) {
+    if (m_password)
         m_password->setValueForUser(password);
-        m_password->setAutoFilled();
-    }
 }